-
Notifications
You must be signed in to change notification settings - Fork 912
[BRE-1333] Added permissions to token generation step to limit token scope #6171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6171 +/- ##
==========================================
+ Coverage 84.89% 85.38% +0.49%
==========================================
Files 724 755 +31
Lines 52778 54109 +1331
Branches 7672 7795 +123
==========================================
+ Hits 44807 46203 +1396
+ Misses 5279 5195 -84
- Partials 2692 2711 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Fixed Issues (22)Great job! The following issues were fixed in this Pull Request
|
39b3151 to
18f27a6
Compare
vvolkgang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gitclonebrian sorry for the late review. As C-dawg wrote, workflow permissions could be removed now.
…e` and pull-requests: write` from job. added `contents: read` to job.


🎟️ Tracking
BRE-1333
📔 Objective
Adding permissions to token generation step to limit token scope per least privilege best practice.
Changes were tested:
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes