Mark natvis file as PUBLIC in CMakeLists.txt #317
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #317 +/- ##
========================================
Coverage 98.23% 98.23%
========================================
Files 161 161
Lines 22239 22239
========================================
Hits 21847 21847
Misses 392 392 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…his is a no-op when the generator doesn't support it, however still gate the natvis file behind 'if(MSVC)'
pdimov
reviewed
Oct 19, 2025
|
|
||
| if(CMAKE_VERSION VERSION_GREATER 3.18 AND CMAKE_GENERATOR MATCHES "Visual Studio") | ||
|
|
||
| if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.12) |
There was a problem hiding this comment.
I mean, CONFIGURE_DEPENDS "works" on pre-3.12, because it's interpreted as a path, and doesn't do anything.
pdimov
reviewed
Oct 19, 2025
| file(GLOB_RECURSE boost_unordered_IDEFILES include/*.hpp) | ||
| endif() | ||
| target_sources(boost_unordered PRIVATE ${boost_unordered_IDEFILES}) | ||
| if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.18) |
There was a problem hiding this comment.
This is wrong. target_sources requires 3.19, not source_group and not 3.18.
|
This is what I arrived at, after a fair bit of experimentation: |
|
I will look into this more soon, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #307 , in tandem with boostorg/cmake#89