Skip to content

Mark natvis file as PUBLIC in CMakeLists.txt #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+9 −5
Open

Mark natvis file as PUBLIC in CMakeLists.txt #317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b89cbb
Mark natvis file as PUBLIC in CMakeLists.txt
k3DW Oct 5, 2025
37bd215
Grab the list of IDE files in the CMake regardless of generator, as t…
k3DW Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,17 @@ target_link_libraries(boost_unordered
Boost::throw_exception
)

if(CMAKE_VERSION VERSION_GREATER 3.18 AND CMAKE_GENERATOR MATCHES "Visual Studio")

if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.12)
Copy link
Member

@pdimov pdimov Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this check.

Copy link
Member

@pdimov pdimov Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, CONFIGURE_DEPENDS "works" on pre-3.12, because it's interpreted as a path, and doesn't do anything.

file(GLOB_RECURSE boost_unordered_IDEFILES CONFIGURE_DEPENDS include/*.hpp)
else()
file(GLOB_RECURSE boost_unordered_IDEFILES include/*.hpp)
endif()
target_sources(boost_unordered PRIVATE ${boost_unordered_IDEFILES})
if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.18)
Copy link
Member

@pdimov pdimov Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. target_sources requires 3.19, not source_group and not 3.18.

source_group(TREE ${PROJECT_SOURCE_DIR}/include FILES ${boost_unordered_IDEFILES} PREFIX "Header Files")
list(APPEND boost_unordered_IDEFILES extra/boost_unordered.natvis)
target_sources(boost_unordered PRIVATE ${boost_unordered_IDEFILES})

endif()
if(MSVC)
target_sources(boost_unordered PUBLIC extra/boost_unordered.natvis)
endif()

target_compile_features(boost_unordered INTERFACE cxx_std_11)
Expand Down