feat: Modernize project with UV backend, enhanced MCP integration, and Windows-optimized setup #693
+22,876
−1,704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_browser-use Fix/adapt latest browser use
…_browser-use Fix/adapt latest browser use
refactor: remove code duplication in get_next_action method
Modified Dockerfile and Dockerfile.arm64 to use port 5901 for VNC service maintaining consistency with supervisord.conf and docker-compose.yml configurations.
- Restore noVNC program section in supervisord.conf for web-based preview - Fix port mappings in docker-compose.yml for proper VNC access - Ensure correct configuration for web-based browser interaction preview
massage -> message
This PR introduces proper error handling in the UI for missing API keys, addressing issue browser-use#188. Previously, missing API keys resulted in tracebacks in the console, but no clear error was shown in the UI. This made it difficult to understand what went wrong. Now, API key checks are performed at the start of the `get_llm_model` function in `src/utils/utils.py`. I've also added a `PROVIDER_DISPLAY_NAMES` constant for more user-friendly error messages and a `handle_api_key_error` function that leverages `gr.Error` to display clear error messages directly in the UI. If an API key is missing, you'll now see an error message right away. The `run_browser_agent` and `run_with_stream` functions in `webui.py` have been adjusted to ensure these `gr.Error` exceptions are handled properly.
…idate-llm-tests refactor: simplify LLM tests and remove duplication
…-api-key-errors fix: display missing API key errors in UI
Update README.md minor grammar update
README states the default VNC password is `vncpassword` but it is actually `youvncpassword` in the env file
Features/mistralai intergrate
Fixing typo in README.md
- Add O3-mini model to OpenAI model options - Remove forced dark theme to allow system/light theme options - Fix JSON template escape sequence in custom prompts
…odel-support feat: add OpenAI O3-mini model support and fix theme handling
…ling - Updated the MCP tool registration logic to support individual server configurations. - Implemented retrieval of tools for each server based on the provided server configuration. - Improved logging to reflect the total number of tools registered across all servers. - Ensured compatibility with the new langchain-mcp-adapters 0.1.0+ API. This change optimizes the registration process and enhances the flexibility of tool management.
- Added .env.local, .env.development, and .env.production to the .gitignore file. - This change helps prevent sensitive environment configuration files from being tracked in version control. Enhances project security and maintains clean repository management.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
40 issues found across 83 files
Prompt for AI agents (all 40 issues)
Understand the root cause of the following 40 issues and fix them.
<file name=".claude/settings.local.json">
<violation number="1" location=".claude/settings.local.json:8">
This entry hard-codes a developer-specific `d:\Coding\...` path, so the deletion command only works on that machine and fails for other contributors. Please switch to a repo-relative path so the allow rule remains portable.</violation>
</file>
<file name="src/web_ui/webui/components/chat_formatter.py">
<violation number="1" location="src/web_ui/webui/components/chat_formatter.py:23">
Escape the agent message content before building the HTML; as written an agent can return markup like `<script>` and it will execute when the chat renders, exposing the UI to stored XSS.</violation>
</file>
<file name="src/web_ui/observability/cost_calculator.py">
<violation number="1" location="src/web_ui/observability/cost_calculator.py:54">
Returning 0 whenever either the input or output token count is zero hides legitimate charges; only skip billing when both are zero.</violation>
</file>
<file name=".claude/planning/08-QUICK-WINS-FIRST.md">
<violation number="1" location=".claude/planning/08-QUICK-WINS-FIRST.md:48">
The current code-block formatter replaces every ``` with a closing tag first, so the subsequent line never sees the original fence and the opening tag is never inserted. Any fenced block would render incorrectly.</violation>
</file>
<file name=".claude/planning/05-TECHNICAL-SPECS.md">
<violation number="1" location=".claude/planning/05-TECHNICAL-SPECS.md:623">
The BrowserConfig example disables Chromium web security and sandboxing by default, directly contradicting the surrounding guidance and exposing deployments to major security risks. Please remove these flags from the default configuration and document them only as optional for local development.</violation>
</file>
<file name=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md">
<violation number="1" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:598">
`base64` is referenced here without being imported, so recording will crash the first time a screenshot is encoded.</violation>
<violation number="2" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:830">
This lookup only searches the first step’s actions, so actions in later steps raise `ValueError` and halt replay.</violation>
</file>
<file name="src/web_ui/events/event_bus.py">
<violation number="1" location="src/web_ui/events/event_bus.py:135">
When EVENT_BUS_BACKEND is set to "redis", this branch publishes to Redis but never dispatches to the handlers registered in `_subscribers`, so local subscribers stop receiving events. Please also run the in-memory dispatch here (or add a redis-driven consumer that forwards messages).</violation>
</file>
<file name="src/web_ui/webui/webui_manager.py">
<violation number="1" location="src/web_ui/webui/webui_manager.py:76">
Changing save_config to accept *args makes it expect positional component values, but its caller still passes a single dict of Component→value. That dict becomes the first component's value and json.dump then sees Component keys, causing the save to crash instead of writing the config.</violation>
</file>
<file name=".claude/planning/09-DECISION-FRAMEWORK.md">
<violation number="1" location=".claude/planning/09-DECISION-FRAMEWORK.md:60">
The scoring explanation says complexity is inverted (11 - complexity), but the totals in the table use the raw complexity values, so the published priorities are mathematically incorrect.</violation>
</file>
<file name="src/web_ui/controller/custom_controller.py">
<violation number="1" location="src/web_ui/controller/custom_controller.py:70">
Handle `available_file_paths` being `None` before checking membership to avoid a TypeError.</violation>
</file>
<file name="src/web_ui/webui/components/browser_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/browser_settings_tab.py:198">
`close_wrapper` must accept the value emitted by these `.change()` events; otherwise toggling the controls will raise a TypeError and prevent closing the browser.</violation>
</file>
<file name=".claude/planning/04-PHASE4-ARCHITECTURE.md">
<violation number="1" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:137">
This code calls os.getenv but never imports os, so the Redis-backed event bus will crash at runtime.</violation>
<violation number="2" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:229">
This import still targets src.events.event_bus even though the event bus lives under src/web_ui/events/event_bus.py, so the module will fail to load.</violation>
<violation number="3" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:319">
logger is never defined in this module, so hitting this error path will raise NameError instead of logging the failure.</violation>
<violation number="4" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:396">
uuid.uuid4() is used here without importing uuid, so constructing the agent will immediately crash.</violation>
<violation number="5" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:431">
messages has never been defined in this scope, so iterating over self.llm.astream(messages) will crash immediately.</violation>
<violation number="6" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:440">
model_output is referenced here without being assigned any value, so this loop would crash before executing any actions.</violation>
<violation number="7" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:619">
This plugin still imports Plugin classes from src.plugins..., but the modules reside under src/web_ui/plugins/..., so loading the plugin will raise ModuleNotFoundError.</violation>
</file>
<file name=".claude/planning/10-TESTING-STRATEGY.md">
<violation number="1" location=".claude/planning/10-TESTING-STRATEGY.md:122">
Update the LLM provider example to import from the src.web_ui package so the documented tests match the current module layout.</violation>
<violation number="2" location=".claude/planning/10-TESTING-STRATEGY.md:190">
Align the cost calculator import with the new src.web_ui namespace so the sample test code runs against the refactored modules.</violation>
<violation number="3" location=".claude/planning/10-TESTING-STRATEGY.md:262">
Update the CustomBrowser import to reference the src.web_ui package so the instructions reflect the reorganized codebase.</violation>
<violation number="4" location=".claude/planning/10-TESTING-STRATEGY.md:263">
Point the CustomBrowserContext import at the src.web_ui namespace to keep the integration-test example accurate.</violation>
<violation number="5" location=".claude/planning/10-TESTING-STRATEGY.md:328">
Import tempfile in the example so the persistent-context test runs without raising NameError.</violation>
<violation number="6" location=".claude/planning/10-TESTING-STRATEGY.md:418">
Add an os import in the example so the environment-variable checks work when the snippet is run.</violation>
<violation number="7" location=".claude/planning/10-TESTING-STRATEGY.md:441">
Switch the BrowserUseAgent import to the src.web_ui namespace so the E2E test example uses the current module structure.</violation>
<violation number="8" location=".claude/planning/10-TESTING-STRATEGY.md:443">
Update the CustomController import to target the src.web_ui namespace to match the reorganized source tree.</violation>
<violation number="9" location=".claude/planning/10-TESTING-STRATEGY.md:461">
Import get_llm_model in the E2E example so the agent setup code executes successfully.</violation>
</file>
<file name="src/web_ui/utils/llm_provider.py">
<violation number="1" location="src/web_ui/utils/llm_provider.py:276">
The IBM provider ignores the supplied API key and always pulls from the environment, so providing the key via kwargs now results in an empty credential and the Watsonx client will fail to authenticate.</violation>
</file>
<file name=".claude/planning/PLANNING-SUMMARY.md">
<violation number="1" location=".claude/planning/PLANNING-SUMMARY.md:13">
The summary claims there are 11 planning documents, but the table directly below lists 12 entries, leading to an inaccurate document count that can confuse readers.</violation>
</file>
<file name="src/web_ui/utils/workflow_graph.py">
<violation number="1" location="src/web_ui/utils/workflow_graph.py:218">
Falsey results (0/False/"" etc.) are treated as missing, so successful actions that return those values will incorrectly show "No result" and lose the original payload. Please check for None instead when deciding whether to populate the fields.</violation>
</file>
<file name="setup-windows.bat">
<violation number="1" location="setup-windows.bat:10">
Inside the UV install branch, the `%errorlevel%` check keeps the original non-zero value from `uv --version`, so even a successful `winget install` is treated as a failure and the script exits. Replace it with the `if errorlevel 1` form so the runtime ERRORLEVEL from winget is evaluated.</violation>
</file>
<file name="src/web_ui/webui/components/load_save_config_tab.py">
<violation number="1" location="src/web_ui/webui/components/load_save_config_tab.py:40">
save_config expects positional component values, but this wrapper passes a single dict. That causes save_config to treat the whole dict as one component value and fail when dumping JSON.</violation>
</file>
<file name="pyproject.toml">
<violation number="1" location="pyproject.toml:52">
The console_script entry points to `webui:main`, but no `webui` module (or `main` function) exists in the installed package set, so running the `webui` command will crash with ModuleNotFoundError.</violation>
</file>
<file name="src/web_ui/observability/tracer.py">
<violation number="1" location="src/web_ui/observability/tracer.py:79">
Adding the span to the current trace before the async body executes means aggregate metrics (total tokens, cost, call counts) stay at zero because those fields are normally filled in inside the context after the yield. Move the add_span call until after the span completes so aggregates reflect the final span data.</violation>
</file>
<file name="mcp.example.json">
<violation number="1" location="mcp.example.json:120">
The desktop-commander MCP entry points to the unscoped package name, so npx desktop-commander will fail. Use the scoped @wonderwhy-er/desktop-commander package to match the actual server.</violation>
</file>
<file name="src/web_ui/observability/trace_models.py">
<violation number="1" location="src/web_ui/observability/trace_models.py:138">
Serializing final_output with str() and falling back to None on falsy results drops valid values and breaks structured payloads; keep the original object unless it is explicitly None.</violation>
</file>
<file name="src/web_ui/webui/components/mcp_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/mcp_settings_tab.py:34">
The docstring claims this function returns only three values, but the implementation returns four (including the server summary), so the documentation is inaccurate and can mislead callers.</violation>
<violation number="2" location="src/web_ui/webui/components/mcp_settings_tab.py:87">
This docstring mentions only two return values even though the function returns three (status, validation, and summary), which makes the documentation inaccurate.</violation>
<violation number="3" location="src/web_ui/webui/components/mcp_settings_tab.py:148">
The docstring claims this function returns only a single validation message, but it actually returns a two-item tuple (message and summary), so the documentation is inconsistent with the implementation.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| }, | ||
| "desktop-commander": { | ||
| "command": "npx", | ||
| "args": ["-y", "desktop-commander"], |
Contributor
There was a problem hiding this comment.
The desktop-commander MCP entry points to the unscoped package name, so npx desktop-commander will fail. Use the scoped @wonderwhy-er/desktop-commander package to match the actual server.
Prompt for AI agents
Address the following comment on mcp.example.json at line 120:
<comment>The desktop-commander MCP entry points to the unscoped package name, so npx desktop-commander will fail. Use the scoped @wonderwhy-er/desktop-commander package to match the actual server.</comment>
<file context>
@@ -0,0 +1,129 @@
+ },
+ "desktop-commander": {
+ "command": "npx",
+ "args": ["-y", "desktop-commander"],
+ "transport": "stdio"
+ },
</file context>
Suggested change
| "args": ["-y", "desktop-commander"], | |
| "args": ["-y", "@wonderwhy-er/desktop-commander"], |
| "llm_calls": self.llm_calls, | ||
| "actions_executed": self.actions_executed, | ||
| "success": self.success, | ||
| "final_output": str(self.final_output) if self.final_output else None, |
Contributor
There was a problem hiding this comment.
Serializing final_output with str() and falling back to None on falsy results drops valid values and breaks structured payloads; keep the original object unless it is explicitly None.
Prompt for AI agents
Address the following comment on src/web_ui/observability/trace_models.py at line 138:
<comment>Serializing final_output with str() and falling back to None on falsy results drops valid values and breaks structured payloads; keep the original object unless it is explicitly None.</comment>
<file context>
@@ -0,0 +1,167 @@
+ "llm_calls": self.llm_calls,
+ "actions_executed": self.actions_executed,
+ "success": self.success,
+ "final_output": str(self.final_output) if self.final_output else None,
+ "error": self.error,
+ }
</file context>
Suggested change
| "final_output": str(self.final_output) if self.final_output else None, | |
| "final_output": self.final_output if self.final_output is not None else None, |
| config_text: JSON configuration text | ||
| Returns: | ||
| Validation message |
Contributor
There was a problem hiding this comment.
The docstring claims this function returns only a single validation message, but it actually returns a two-item tuple (message and summary), so the documentation is inconsistent with the implementation.
Prompt for AI agents
Address the following comment on src/web_ui/webui/components/mcp_settings_tab.py at line 148:
<comment>The docstring claims this function returns only a single validation message, but it actually returns a two-item tuple (message and summary), so the documentation is inconsistent with the implementation.</comment>
<file context>
@@ -0,0 +1,407 @@
+ config_text: JSON configuration text
+
+ Returns:
+ Validation message
+ """
+ try:
</file context>
Suggested change
| Validation message | |
| Tuple of (validation_message, summary) |
| custom_path: Optional custom path to save to | ||
| Returns: | ||
| Tuple of (status_message, validation_message) |
Contributor
There was a problem hiding this comment.
This docstring mentions only two return values even though the function returns three (status, validation, and summary), which makes the documentation inaccurate.
Prompt for AI agents
Address the following comment on src/web_ui/webui/components/mcp_settings_tab.py at line 87:
<comment>This docstring mentions only two return values even though the function returns three (status, validation, and summary), which makes the documentation inaccurate.</comment>
<file context>
@@ -0,0 +1,407 @@
+ custom_path: Optional custom path to save to
+
+ Returns:
+ Tuple of (status_message, validation_message)
+ """
+ try:
</file context>
Suggested change
| Tuple of (status_message, validation_message) | |
| Tuple of (status_message, validation_message, summary) |
| custom_path: Optional custom path to load from | ||
| Returns: | ||
| Tuple of (config_json_str, status_message, validation_message) |
Contributor
There was a problem hiding this comment.
The docstring claims this function returns only three values, but the implementation returns four (including the server summary), so the documentation is inaccurate and can mislead callers.
Prompt for AI agents
Address the following comment on src/web_ui/webui/components/mcp_settings_tab.py at line 34:
<comment>The docstring claims this function returns only three values, but the implementation returns four (including the server summary), so the documentation is inaccurate and can mislead callers.</comment>
<file context>
@@ -0,0 +1,407 @@
+ custom_path: Optional custom path to load from
+
+ Returns:
+ Tuple of (config_json_str, status_message, validation_message)
+ """
+ try:
</file context>
Suggested change
| Tuple of (config_json_str, status_message, validation_message) | |
| Tuple of (config_json_str, status_message, validation_message, summary) |
Contributor
There was a problem hiding this comment.
26 issues found across 83 files
Prompt for AI agents (all 26 issues)
Understand the root cause of the following 26 issues and fix them.
<file name="src/web_ui/observability/cost_calculator.py">
<violation number="1" location="src/web_ui/observability/cost_calculator.py:54">
This guard returns zero cost whenever either input or output tokens is zero, so a request with only prompt or only completion tokens is incorrectly reported as free. Allow cost calculation when at least one token count is non-zero.</violation>
</file>
<file name=".claude/settings.local.json">
<violation number="1" location=".claude/settings.local.json:8">
Hardcoding this absolute D:\ path makes the allowance unusable for anyone cloning the repo elsewhere; prefer a repo-relative path so the command works across environments.</violation>
</file>
<file name=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md">
<violation number="1" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:161">
`NodeDetailsPanel` is used here without any import or definition, so the React code will not compile.</violation>
<violation number="2" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:598">
`base64` is referenced here without being imported, which will crash recording the first time a screenshot is encoded.</violation>
<violation number="3" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:612">
`logger` is used here without any definition or import, so exception handling will fail with a NameError instead of logging.</violation>
<violation number="4" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:830">
This lookup only searches the first step's actions; for actions in later steps it raises a ValueError, breaking replay for multi-step workflows.</violation>
</file>
<file name="src/web_ui/controller/custom_controller.py">
<violation number="1" location="src/web_ui/controller/custom_controller.py:70">
Guard against available_file_paths being None before checking membership; otherwise the upload action crashes when no list is provided.</violation>
</file>
<file name="src/web_ui/webui/components/agent_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/agent_settings_tab.py:123">
Accessing config.model_names[os.getenv("DEFAULT_LLM", "openai")] will raise a KeyError when DEFAULT_LLM is set to a provider that's not in the config list, breaking UI initialization. Add a safe lookup with a fallback provider.</violation>
</file>
<file name="src/web_ui/utils/workflow_graph.py">
<violation number="1" location="src/web_ui/utils/workflow_graph.py:218">
Please treat only None as "No result"; falsy outputs like 0, False, or "" should be preserved to avoid misreporting the agent's result.</violation>
</file>
<file name="src/web_ui/utils/mcp_config.py">
<violation number="1" location="src/web_ui/utils/mcp_config.py:32">
Please expand the MCP_CONFIG_PATH value so paths with '~' resolve to the user home directory; otherwise configs like '~/mcp.json' fail to load and save correctly.</violation>
</file>
<file name="README.md">
<violation number="1" location="README.md:74">
`playwright install --with-deps` is not supported on Windows, so the recommended Windows setup command fails and prevents installing the required browsers. Please drop the `--with-deps` flag for Windows instructions or note that it only applies to Linux.</violation>
</file>
<file name="src/web_ui/webui/webui_manager.py">
<violation number="1" location="src/web_ui/webui/webui_manager.py:76">
The new `save_config(*args)` signature assumes positional component values, but callers (e.g., load_save_config_tab) still pass a dict, causing the saved UI config to capture the entire dict under the first component and omit the rest. This breaks saving configs.</violation>
</file>
<file name="src/web_ui/webui/components/chat_formatter.py">
<violation number="1" location="src/web_ui/webui/components/chat_formatter.py:23">
User-supplied content is interpolated into HTML without escaping, allowing agent/error text to inject executable markup and trigger stored XSS.</violation>
<violation number="2" location="src/web_ui/webui/components/chat_formatter.py:597">
`copyToClipboard` reads `event.target` without receiving an event argument, which causes a ReferenceError in browsers that don’t expose a global `event`, breaking the copy button.</violation>
</file>
<file name="src/web_ui/events/event_bus.py">
<violation number="1" location="src/web_ui/events/event_bus.py:134">
Publishing with the Redis backend never invokes the in-process subscribers, so no handler runs when backend="redis". Please ensure you still dispatch to the registered handlers when redis is enabled.</violation>
</file>
<file name=".claude/planning/09-DECISION-FRAMEWORK.md">
<violation number="1" location=".claude/planning/09-DECISION-FRAMEWORK.md:46">
The total for this row still adds the raw complexity value even though the scoring rules say to invert it (11 - complexity), so the priority matrix overstates high-complexity work. Please recalculate using the documented formula (8 + 10 + (11-9) = 20).</violation>
</file>
<file name="setup-windows.bat">
<violation number="1" location="setup-windows.bat:47">
`playwright install --with-deps` fails on Windows because the `--with-deps` flag is only supported on Linux, so this Windows setup script will stop during browser installation. Replace it with a Windows-compatible command (e.g., just `playwright install`).</violation>
</file>
<file name=".claude/planning/06-DEPLOYMENT-GUIDE.md">
<violation number="1" location=".claude/planning/06-DEPLOYMENT-GUIDE.md:185">
The deployment guide instructs running `python -m src.storage.init_db`, but there is no `src.storage` module in the project, so this command will fail with ModuleNotFoundError.</violation>
</file>
<file name=".claude/planning/01-PHASE1-REALTIME-UX.md">
<violation number="1" location=".claude/planning/01-PHASE1-REALTIME-UX.md:460">
`run_with_status_updates` calls `agent.stream_execution()` even though no `agent` symbol is defined in this scope, so this would raise immediately. Please use the WebuiManager instance (`ui_manager.bu_agent`) instead.</violation>
</file>
<file name="src/web_ui/observability/trace_models.py">
<violation number="1" location="src/web_ui/observability/trace_models.py:102">
Aggregating tokens and cost inside add_span runs before those span fields are populated, so totals never reflect the actual values collected later in the span context.</violation>
<violation number="2" location="src/web_ui/observability/trace_models.py:138">
Serializing final_output only when it is truthy drops legitimate results like 0 or False, so traces lose the actual agent output.</violation>
</file>
<file name="pyproject.toml">
<violation number="1" location="pyproject.toml:52">
The `webui` console script targets `webui:main`, but no such module or callable exists in the packaged code, so running the installed CLI will raise ModuleNotFoundError.</violation>
</file>
<file name="setup-windows.ps1">
<violation number="1" location="setup-windows.ps1:78">
`playwright install --with-deps` fails on Windows because the `--with-deps` flag is Linux-only, so the scripted setup aborts before completion. Please drop the flag (or switch to a Windows-compatible command) to keep the installer working on Windows.</violation>
</file>
<file name=".claude/planning/03-PHASE3-OBSERVABILITY.md">
<violation number="1" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:35">
`ExecutionTrace.to_dict` calls `asdict(span)`, but the module never imports `asdict`, so the first trace serialization will raise a NameError.</violation>
<violation number="2" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:40">
Define `SpanType` as a `str, Enum` hybrid so spans serialize to simple strings; otherwise JSON serialization of traces fails.</violation>
</file>
<file name="src/web_ui/webui/components/deep_research_agent_tab.py">
<violation number="1" location="src/web_ui/webui/components/deep_research_agent_tab.py:488">
The Run button handler is now a synchronous function that returns an async generator object, so Gradio never iterates the generator and the deep-research task fails to start.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| Returns: | ||
| Cost in USD | ||
| """ | ||
| if not model or input_tokens == 0 or output_tokens == 0: |
Contributor
There was a problem hiding this comment.
This guard returns zero cost whenever either input or output tokens is zero, so a request with only prompt or only completion tokens is incorrectly reported as free. Allow cost calculation when at least one token count is non-zero.
Prompt for AI agents
Address the following comment on src/web_ui/observability/cost_calculator.py at line 54:
<comment>This guard returns zero cost whenever either input or output tokens is zero, so a request with only prompt or only completion tokens is incorrectly reported as free. Allow cost calculation when at least one token count is non-zero.</comment>
<file context>
@@ -0,0 +1,157 @@
+ Returns:
+ Cost in USD
+ """
+ if not model or input_tokens == 0 or output_tokens == 0:
+ return 0.0
+
</file context>
Suggested change
| if not model or input_tokens == 0 or output_tokens == 0: | |
| if not model or (input_tokens == 0 and output_tokens == 0): |
| ) -> Dict[str, Any] | None: | ||
| """Find parameter definition for an action.""" | ||
| for param in workflow["parameters"]: | ||
| if param["action_index"] == workflow["steps"][0]["actions"].index(action): |
Contributor
There was a problem hiding this comment.
This lookup only searches the first step's actions; for actions in later steps it raises a ValueError, breaking replay for multi-step workflows.
Prompt for AI agents
Address the following comment on .claude/planning/02-PHASE2-VISUAL-WORKFLOW.md at line 830:
<comment>This lookup only searches the first step's actions; for actions in later steps it raises a ValueError, breaking replay for multi-step workflows.</comment>
<file context>
@@ -0,0 +1,1057 @@
+ ) -> Dict[str, Any] | None:
+ """Find parameter definition for an action."""
+ for param in workflow["parameters"]:
+ if param["action_index"] == workflow["steps"][0]["actions"].index(action):
+ return param
+ return None
</file context>
✅ Addressed in 92001e4
| self.actions.append(action) | ||
|
|
||
| except Exception as e: | ||
| logger.warning(f"Failed to get recorded actions from page: {e}") |
Contributor
There was a problem hiding this comment.
logger is used here without any definition or import, so exception handling will fail with a NameError instead of logging.
Prompt for AI agents
Address the following comment on .claude/planning/02-PHASE2-VISUAL-WORKFLOW.md at line 612:
<comment>`logger` is used here without any definition or import, so exception handling will fail with a NameError instead of logging.</comment>
<file context>
@@ -0,0 +1,1057 @@
+ self.actions.append(action)
+
+ except Exception as e:
+ logger.warning(f"Failed to get recorded actions from page: {e}")
+
+ return self.actions
</file context>
✅ Addressed in 92001e4
| for action_data in recorded: | ||
| # Take screenshot at this point (or retrieve from history) | ||
| screenshot = await page.screenshot(type="png") | ||
| screenshot_b64 = base64.b64encode(screenshot).decode() |
Contributor
There was a problem hiding this comment.
base64 is referenced here without being imported, which will crash recording the first time a screenshot is encoded.
Prompt for AI agents
Address the following comment on .claude/planning/02-PHASE2-VISUAL-WORKFLOW.md at line 598:
<comment>`base64` is referenced here without being imported, which will crash recording the first time a screenshot is encoded.</comment>
<file context>
@@ -0,0 +1,1057 @@
+ for action_data in recorded:
+ # Take screenshot at this point (or retrieve from history)
+ screenshot = await page.screenshot(type="png")
+ screenshot_b64 = base64.b64encode(screenshot).decode()
+
+ action = RecordedAction(
</file context>
✅ Addressed in 92001e4
| Repository = "https://github.com/browser-use/web-ui" | ||
|
|
||
| [project.scripts] | ||
| webui = "webui:main" |
Contributor
There was a problem hiding this comment.
The webui console script targets webui:main, but no such module or callable exists in the packaged code, so running the installed CLI will raise ModuleNotFoundError.
Prompt for AI agents
Address the following comment on pyproject.toml at line 52:
<comment>The `webui` console script targets `webui:main`, but no such module or callable exists in the packaged code, so running the installed CLI will raise ModuleNotFoundError.</comment>
<file context>
@@ -0,0 +1,108 @@
+ Repository = "https://github.com/browser-use/web-ui"
+
+ [project.scripts]
+ webui = "webui:main"
+
+[dependency-groups]
</file context>
setup-windows.ps1
Outdated
|
|
||
| # Install Playwright browsers | ||
| Write-Host "Installing Playwright browsers..." | ||
| playwright install --with-deps |
Contributor
There was a problem hiding this comment.
playwright install --with-deps fails on Windows because the --with-deps flag is Linux-only, so the scripted setup aborts before completion. Please drop the flag (or switch to a Windows-compatible command) to keep the installer working on Windows.
Prompt for AI agents
Address the following comment on setup-windows.ps1 at line 78:
<comment>`playwright install --with-deps` fails on Windows because the `--with-deps` flag is Linux-only, so the scripted setup aborts before completion. Please drop the flag (or switch to a Windows-compatible command) to keep the installer working on Windows.</comment>
<file context>
@@ -0,0 +1,110 @@
+
+# Install Playwright browsers
+Write-Host "Installing Playwright browsers..."
+playwright install --with-deps
+
+Write-Host "`n⚙️ Setting up environment configuration..." -ForegroundColor Yellow
</file context>
✅ Addressed in f58c325
| from datetime import datetime | ||
| from enum import Enum | ||
|
|
||
| class SpanType(Enum): |
Contributor
There was a problem hiding this comment.
Define SpanType as a str, Enum hybrid so spans serialize to simple strings; otherwise JSON serialization of traces fails.
Prompt for AI agents
Address the following comment on .claude/planning/03-PHASE3-OBSERVABILITY.md at line 40:
<comment>Define `SpanType` as a `str, Enum` hybrid so spans serialize to simple strings; otherwise JSON serialization of traces fails.</comment>
<file context>
@@ -0,0 +1,738 @@
+from datetime import datetime
+from enum import Enum
+
+class SpanType(Enum):
+ """Types of execution spans."""
+ AGENT_RUN = "agent_run"
</file context>
Suggested change
| class SpanType(Enum): | |
| class SpanType(str, Enum): |
✅ Addressed in 92001e4
| #### Trace Data Structure | ||
|
|
||
| ```python | ||
| from dataclasses import dataclass, field |
Contributor
There was a problem hiding this comment.
ExecutionTrace.to_dict calls asdict(span), but the module never imports asdict, so the first trace serialization will raise a NameError.
Prompt for AI agents
Address the following comment on .claude/planning/03-PHASE3-OBSERVABILITY.md at line 35:
<comment>`ExecutionTrace.to_dict` calls `asdict(span)`, but the module never imports `asdict`, so the first trace serialization will raise a NameError.</comment>
<file context>
@@ -0,0 +1,738 @@
+#### Trace Data Structure
+
+```python
+from dataclasses import dataclass, field
+from typing import List, Dict, Any, Optional
+from datetime import datetime
</file context>
Suggested change
| from dataclasses import dataclass, field | |
| from dataclasses import dataclass, field, asdict |
✅ Addressed in 92001e4
| async def start_wrapper(comps: Dict[Component, Any]) -> AsyncGenerator[Dict[Component, Any], None]: | ||
| async for update in run_deep_research(webui_manager, comps): | ||
| yield update | ||
| def start_wrapper(*args) -> AsyncGenerator[dict[Component, Any]]: |
Contributor
There was a problem hiding this comment.
The Run button handler is now a synchronous function that returns an async generator object, so Gradio never iterates the generator and the deep-research task fails to start.
Prompt for AI agents
Address the following comment on src/web_ui/webui/components/deep_research_agent_tab.py at line 488:
<comment>The Run button handler is now a synchronous function that returns an async generator object, so Gradio never iterates the generator and the deep-research task fails to start.</comment>
<file context>
@@ -426,32 +478,32 @@ async def update_wrapper(mcp_file):
- async def start_wrapper(comps: Dict[Component, Any]) -> AsyncGenerator[Dict[Component, Any], None]:
- async for update in run_deep_research(webui_manager, comps):
- yield update
+ def start_wrapper(*args) -> AsyncGenerator[dict[Component, Any]]:
+ # Convert individual component values to components dict
+ comps = {}
</file context>
Contributor
There was a problem hiding this comment.
40 issues found across 83 files
Prompt for AI agents (all 40 issues)
Understand the root cause of the following 40 issues and fix them.
<file name=".claude/planning/04-PHASE4-ARCHITECTURE.md">
<violation number="1" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:137">
os.getenv is used here without importing os, so EventBus will crash when using the Redis backend. Please add the missing os import.</violation>
<violation number="2" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:229">
This import skips the web_ui package and will raise ImportError. Update it to import from src.web_ui.events.event_bus.</violation>
<violation number="3" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:319">
logger is undefined here, so handling a WebSocket error will raise NameError. Import logging and define logger before using it.</violation>
<violation number="4" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:396">
uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.</violation>
<violation number="5" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:431">
messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).</violation>
<violation number="6" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:440">
model_output is never defined before use, so this loop will raise NameError. Ensure you compute the model output before iterating over actions.</violation>
<violation number="7" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:619">
This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.</violation>
<violation number="8" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:784">
manifest_data contains fields (e.g., homepage, dependencies as dict) not defined on PluginManifest, so this call will raise TypeError. Normalize/trim the payload or extend PluginManifest before instantiating it.</violation>
<violation number="9" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:811">
The derived class name doesn't match the provided plugin (PDFExtractorPlugin), so this will raise AttributeError. Adjust the naming convention or provide an explicit class lookup.</violation>
</file>
<file name="src/web_ui/webui/webui_manager.py">
<violation number="1" location="src/web_ui/webui/webui_manager.py:85">
save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.</violation>
</file>
<file name="src/web_ui/observability/cost_calculator.py">
<violation number="1" location="src/web_ui/observability/cost_calculator.py:54">
`calculate_llm_cost` should only short-circuit when both input and output token counts are zero. As written it returns 0 for any call where one side is zero, misreporting cost for legitimate usage.</violation>
</file>
<file name="src/web_ui/events/event_bus.py">
<violation number="1" location="src/web_ui/events/event_bus.py:134">
When EVENT_BUS_BACKEND is set to "redis", publish() only pushes to Redis and never invokes the in-process subscribers stored by subscribe(), so handlers in the current process stop receiving events. Please still dispatch to local subscribers before (or in addition to) publishing to Redis.</violation>
</file>
<file name=".claude/planning/03-PHASE3-OBSERVABILITY.md">
<violation number="1" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:35">
ExecutionTrace.to_dict calls asdict(span), but this file only imports dataclass and field; running this code will throw a NameError. Please import asdict here so serialization works.</violation>
<violation number="2" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:245">
The observability modules live under src/web_ui/observability/, so importing from src.observability.tracer will fail at runtime. Please correct the path.</violation>
<violation number="3" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:316">
TraceStorage lives under src/web_ui/observability/, so importing from src.observability.trace_storage will fail. Please include the web_ui segment.</violation>
<violation number="4" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:355">
logger is never defined in this snippet, so calling logger.warning here will crash. Please define a logger or use logging.warning before logging unknown models.</violation>
</file>
<file name=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md">
<violation number="1" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:161">
`NodeDetailsPanel` is referenced here but no component or import with that name exists, so the React build will fail.</violation>
<violation number="2" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:474">
`chatbot_messages` is undefined in this context, so yielding it will raise a NameError during execution.</violation>
<violation number="3" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:598">
`base64` is used here without being imported, so this line raises a NameError when executed.</violation>
<violation number="4" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:661">
`RecordedAction` is referenced in this annotation without being imported or forward-declared, so class definition raises a NameError.</violation>
<violation number="5" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:830">
Looking up the action index only inside `steps[0]` raises `ValueError` for actions in later steps, breaking multi-step replays.</violation>
</file>
<file name="pyproject.toml">
<violation number="1" location="pyproject.toml:52">
The console script targets webui:main, but only packages named web_ui* are included, so the module webui is missing at runtime. Point the entry point at the actual installed module to avoid a ModuleNotFoundError.</violation>
</file>
<file name="src/web_ui/webui/components/agent_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/agent_settings_tab.py:123">
Indexing `config.model_names` with `DEFAULT_LLM` crashes startup whenever the env var points to an unsupported provider; consider using `.get(...)` with a safe fallback so custom providers don’t break the UI.</violation>
</file>
<file name="src/web_ui/webui/components/browser_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/browser_settings_tab.py:198">
The Gradio change handler close_wrapper is defined without accepting the value argument, but each .change(...) call will pass the component's new value, triggering a runtime TypeError and preventing the browser-close routine from running.</violation>
</file>
<file name="Dockerfile">
<violation number="1" location="Dockerfile:1">
Switching the base image to Python 3.14 keeps the apt-provided `python3-numpy`, whose binaries are built for CPython 3.11; under 3.14 the extension modules fail to load, so `import numpy` will break.</violation>
</file>
<file name="src/web_ui/utils/workflow_graph.py">
<violation number="1" location="src/web_ui/utils/workflow_graph.py:218">
Truthy checks here drop legitimate falsy results (0, False, ""), so result nodes incorrectly show “No result” and lose the actual value. Please guard specifically against None instead so real data is preserved.</violation>
</file>
<file name="setup-windows.ps1">
<violation number="1" location="setup-windows.ps1:40">
`winget install astral-sh.uv` needs explicit `$LASTEXITCODE` handling; otherwise we report success and continue even when the install fails and UV is still missing.</violation>
</file>
<file name=".claude/planning/01-PHASE1-REALTIME-UX.md">
<violation number="1" location=".claude/planning/01-PHASE1-REALTIME-UX.md:460">
run_with_status_updates references agent.stream_execution(), but no agent variable is defined in this scope. Use ui_manager.bu_agent (or the appropriate agent instance) to avoid a NameError at runtime.</violation>
</file>
<file name="src/web_ui/utils/mcp_config.py">
<violation number="1" location="src/web_ui/utils/mcp_config.py:32">
Please expand user home directories when resolving MCP_CONFIG_PATH so values like `~/...` work; otherwise the literal `~` path causes load/save to fail.</violation>
</file>
<file name="src/web_ui/observability/trace_models.py">
<violation number="1" location="src/web_ui/observability/trace_models.py:138">
Serializing final_output drops falsy but valid values (0, False, ""), causing loss of legitimate trace results. Replace the truthiness check with an explicit None check so only actual None becomes null.</violation>
</file>
<file name="src/web_ui/webui/components/browser_use_agent_tab.py">
<violation number="1" location="src/web_ui/webui/components/browser_use_agent_tab.py:760">
The final UI update always sets the progress banner to "Task completed successfully" even when the run ended with an error or cancellation because this assignment lives inside the finally block that executes for failure paths too. Please gate this status by the actual outcome (e.g., only show the success text when no error/cancellation occurred).</violation>
</file>
<file name=".claude/planning/08-QUICK-WINS-FIRST.md">
<violation number="1" location=".claude/planning/08-QUICK-WINS-FIRST.md:48">
The first replace call converts every ``` to a closing </code></pre>, leaving no opening tag and corrupting code blocks. Please replace this logic with a single regex substitution that wraps the block with both opening and closing tags.</violation>
</file>
<file name=".claude/planning/09-DECISION-FRAMEWORK.md">
<violation number="1" location=".claude/planning/09-DECISION-FRAMEWORK.md:60">
The complexity description says scores are inverted (11 - complexity), but the totals in the table are simple sums of the raw values. This mismatch will mislead anyone trying to recompute priorities.</violation>
</file>
<file name=".claude/settings.local.json">
<violation number="1" location=".claude/settings.local.json:8">
Hard-coding a personal D:\ path into this allow list makes the delete permission unusable anywhere else. Use a repository-relative or otherwise portable path so teammates/CI can run the same command.</violation>
</file>
<file name=".claude/planning/10-TESTING-STRATEGY.md">
<violation number="1" location=".claude/planning/10-TESTING-STRATEGY.md:122">
This example import still points to the old src.utils package; after the re-org the module lives under src/web_ui, so the documented snippet will fail with ModuleNotFoundError.</violation>
<violation number="2" location=".claude/planning/10-TESTING-STRATEGY.md:190">
The cost calculator import path is outdated; the module moved under src/web_ui, so this example would break when copied.</violation>
<violation number="3" location=".claude/planning/10-TESTING-STRATEGY.md:262">
The CustomBrowser import in this snippet targets the pre-refactor src.browser package; with code now under src/web_ui, the example will raise ModuleNotFoundError.</violation>
<violation number="4" location=".claude/planning/10-TESTING-STRATEGY.md:263">
This CustomBrowserContext import still points to src.browser, but the file now lives under src/web_ui/browser, so copying this example will fail.</violation>
<violation number="5" location=".claude/planning/10-TESTING-STRATEGY.md:441">
The BrowserUseAgent import still references src.agent, but the code now resides beneath src/web_ui after the refactor, so this guidance is incorrect.</violation>
<violation number="6" location=".claude/planning/10-TESTING-STRATEGY.md:443">
This CustomController import still targets the pre-reorg src.controller package; with files under src/web_ui/controller now, the example should be updated to the new path.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self.event_bus = get_event_bus() | ||
| self.session_id = kwargs.get("session_id", str(uuid.uuid4())) |
Contributor
There was a problem hiding this comment.
uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 396:
<comment>uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.</comment>
<file context>
@@ -0,0 +1,949 @@
+ def __init__(self, *args, **kwargs):
+ super().__init__(*args, **kwargs)
+ self.event_bus = get_event_bus()
+ self.session_id = kwargs.get("session_id", str(uuid.uuid4()))
+
+ async def run(self, max_steps: int = 100):
</file context>
| import asyncio | ||
| from datetime import datetime | ||
|
|
||
| from src.events.event_bus import get_event_bus, Event, EventType |
Contributor
There was a problem hiding this comment.
This import skips the web_ui package and will raise ImportError. Update it to import from src.web_ui.events.event_bus.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 229:
<comment>This import skips the web_ui package and will raise ImportError. Update it to import from src.web_ui.events.event_bus.</comment>
<file context>
@@ -0,0 +1,949 @@
+import asyncio
+from datetime import datetime
+
+from src.events.event_bus import get_event_bus, Event, EventType
+
+app = FastAPI(title="Browser Use Web UI API")
</file context>
Suggested change
| from src.events.event_bus import get_event_bus, Event, EventType | |
| from src.web_ui.events.event_bus import get_event_bus, Event, EventType |
| **File:** `src/web_ui/plugins/builtin/pdf_extractor/plugin.py` | ||
|
|
||
| ```python | ||
| from src.plugins.plugin_interface import Plugin, PluginManifest |
Contributor
There was a problem hiding this comment.
This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 619:
<comment>This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.</comment>
<file context>
@@ -0,0 +1,949 @@
+**File:** `src/web_ui/plugins/builtin/pdf_extractor/plugin.py`
+
+```python
+from src.plugins.plugin_interface import Plugin, PluginManifest
+from browser_use.controller.views import ActionResult
+from browser_use.browser.context import BrowserContext
</file context>
Suggested change
| from src.plugins.plugin_interface import Plugin, PluginManifest | |
| from src.web_ui.plugins.plugin_interface import Plugin, PluginManifest |
| all_components = list(self.id_to_component.values()) | ||
| for i, comp in enumerate(all_components): | ||
| if i < len(args): | ||
| components[comp] = args[i] |
Contributor
There was a problem hiding this comment.
save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.
Prompt for AI agents
Address the following comment on src/web_ui/webui/webui_manager.py at line 85:
<comment>save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.</comment>
<file context>
@@ -59,32 +55,42 @@ def add_components(self, tab_name: str, components_dict: dict[str, "Component"])
+ all_components = list(self.id_to_component.values())
+ for i, comp in enumerate(all_components):
+ if i < len(args):
+ components[comp] = args[i]
+
cur_settings = {}
</file context>
| )) | ||
|
|
||
| # Stream LLM tokens | ||
| async for token in self.llm.astream(messages): |
Contributor
There was a problem hiding this comment.
messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 431:
<comment>messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).</comment>
<file context>
@@ -0,0 +1,949 @@
+ ))
+
+ # Stream LLM tokens
+ async for token in self.llm.astream(messages):
+ await self.event_bus.publish(Event(
+ event_type=EventType.LLM_TOKEN,
</file context>
|
|
||
| ```python | ||
| import pytest | ||
| from src.observability.cost_calculator import calculate_llm_cost |
Contributor
There was a problem hiding this comment.
The cost calculator import path is outdated; the module moved under src/web_ui, so this example would break when copied.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 190:
<comment>The cost calculator import path is outdated; the module moved under src/web_ui, so this example would break when copied.</comment>
<file context>
@@ -0,0 +1,837 @@
+
+```python
+import pytest
+from src.observability.cost_calculator import calculate_llm_cost
+
+class TestCostCalculator:
</file context>
|
|
||
| ```python | ||
| import pytest | ||
| from src.utils.llm_provider import get_llm_model |
Contributor
There was a problem hiding this comment.
This example import still points to the old src.utils package; after the re-org the module lives under src/web_ui, so the documented snippet will fail with ModuleNotFoundError.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 122:
<comment>This example import still points to the old src.utils package; after the re-org the module lives under src/web_ui, so the documented snippet will fail with ModuleNotFoundError.</comment>
<file context>
@@ -0,0 +1,837 @@
+
+```python
+import pytest
+from src.utils.llm_provider import get_llm_model
+from unittest.mock import patch, MagicMock
+
</file context>
| import pytest | ||
| from src.agent.browser_use.browser_use_agent import BrowserUseAgent | ||
| from src.browser.custom_browser import CustomBrowser | ||
| from src.controller.custom_controller import CustomController |
Contributor
There was a problem hiding this comment.
This CustomController import still targets the pre-reorg src.controller package; with files under src/web_ui/controller now, the example should be updated to the new path.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 443:
<comment>This CustomController import still targets the pre-reorg src.controller package; with files under src/web_ui/controller now, the example should be updated to the new path.</comment>
<file context>
@@ -0,0 +1,837 @@
+import pytest
+from src.agent.browser_use.browser_use_agent import BrowserUseAgent
+from src.browser.custom_browser import CustomBrowser
+from src.controller.custom_controller import CustomController
+
[email protected]
</file context>
|
|
||
| ```python | ||
| import pytest | ||
| from src.agent.browser_use.browser_use_agent import BrowserUseAgent |
Contributor
There was a problem hiding this comment.
The BrowserUseAgent import still references src.agent, but the code now resides beneath src/web_ui after the refactor, so this guidance is incorrect.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 441:
<comment>The BrowserUseAgent import still references src.agent, but the code now resides beneath src/web_ui after the refactor, so this guidance is incorrect.</comment>
<file context>
@@ -0,0 +1,837 @@
+
+```python
+import pytest
+from src.agent.browser_use.browser_use_agent import BrowserUseAgent
+from src.browser.custom_browser import CustomBrowser
+from src.controller.custom_controller import CustomController
</file context>
| import pytest | ||
| from playwright.async_api import async_playwright | ||
| from src.browser.custom_browser import CustomBrowser | ||
| from src.browser.custom_context import CustomBrowserContext |
Contributor
There was a problem hiding this comment.
This CustomBrowserContext import still points to src.browser, but the file now lives under src/web_ui/browser, so copying this example will fail.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 263:
<comment>This CustomBrowserContext import still points to src.browser, but the file now lives under src/web_ui/browser, so copying this example will fail.</comment>
<file context>
@@ -0,0 +1,837 @@
+import pytest
+from playwright.async_api import async_playwright
+from src.browser.custom_browser import CustomBrowser
+from src.browser.custom_context import CustomBrowserContext
+
[email protected]
</file context>
Contributor
There was a problem hiding this comment.
40 issues found across 83 files
Prompt for AI agents (all 40 issues)
Understand the root cause of the following 40 issues and fix them.
<file name=".claude/planning/04-PHASE4-ARCHITECTURE.md">
<violation number="1" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:137">
os.getenv is used here without importing os, so EventBus will crash when using the Redis backend. Please add the missing os import.</violation>
<violation number="2" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:229">
This import skips the web_ui package and will raise ImportError. Update it to import from src.web_ui.events.event_bus.</violation>
<violation number="3" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:319">
logger is undefined here, so handling a WebSocket error will raise NameError. Import logging and define logger before using it.</violation>
<violation number="4" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:396">
uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.</violation>
<violation number="5" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:431">
messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).</violation>
<violation number="6" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:440">
model_output is never defined before use, so this loop will raise NameError. Ensure you compute the model output before iterating over actions.</violation>
<violation number="7" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:619">
This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.</violation>
<violation number="8" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:784">
manifest_data contains fields (e.g., homepage, dependencies as dict) not defined on PluginManifest, so this call will raise TypeError. Normalize/trim the payload or extend PluginManifest before instantiating it.</violation>
<violation number="9" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:811">
The derived class name doesn't match the provided plugin (PDFExtractorPlugin), so this will raise AttributeError. Adjust the naming convention or provide an explicit class lookup.</violation>
</file>
<file name="src/web_ui/webui/webui_manager.py">
<violation number="1" location="src/web_ui/webui/webui_manager.py:85">
save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.</violation>
</file>
<file name="src/web_ui/observability/cost_calculator.py">
<violation number="1" location="src/web_ui/observability/cost_calculator.py:54">
`calculate_llm_cost` should only short-circuit when both input and output token counts are zero. As written it returns 0 for any call where one side is zero, misreporting cost for legitimate usage.</violation>
</file>
<file name="src/web_ui/events/event_bus.py">
<violation number="1" location="src/web_ui/events/event_bus.py:134">
When EVENT_BUS_BACKEND is set to "redis", publish() only pushes to Redis and never invokes the in-process subscribers stored by subscribe(), so handlers in the current process stop receiving events. Please still dispatch to local subscribers before (or in addition to) publishing to Redis.</violation>
</file>
<file name=".claude/planning/03-PHASE3-OBSERVABILITY.md">
<violation number="1" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:35">
ExecutionTrace.to_dict calls asdict(span), but this file only imports dataclass and field; running this code will throw a NameError. Please import asdict here so serialization works.</violation>
<violation number="2" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:245">
The observability modules live under src/web_ui/observability/, so importing from src.observability.tracer will fail at runtime. Please correct the path.</violation>
<violation number="3" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:316">
TraceStorage lives under src/web_ui/observability/, so importing from src.observability.trace_storage will fail. Please include the web_ui segment.</violation>
<violation number="4" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:355">
logger is never defined in this snippet, so calling logger.warning here will crash. Please define a logger or use logging.warning before logging unknown models.</violation>
</file>
<file name=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md">
<violation number="1" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:161">
`NodeDetailsPanel` is referenced here but no component or import with that name exists, so the React build will fail.</violation>
<violation number="2" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:474">
`chatbot_messages` is undefined in this context, so yielding it will raise a NameError during execution.</violation>
<violation number="3" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:598">
`base64` is used here without being imported, so this line raises a NameError when executed.</violation>
<violation number="4" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:661">
`RecordedAction` is referenced in this annotation without being imported or forward-declared, so class definition raises a NameError.</violation>
<violation number="5" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:830">
Looking up the action index only inside `steps[0]` raises `ValueError` for actions in later steps, breaking multi-step replays.</violation>
</file>
<file name="pyproject.toml">
<violation number="1" location="pyproject.toml:52">
The console script targets webui:main, but only packages named web_ui* are included, so the module webui is missing at runtime. Point the entry point at the actual installed module to avoid a ModuleNotFoundError.</violation>
</file>
<file name="src/web_ui/webui/components/agent_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/agent_settings_tab.py:123">
Indexing `config.model_names` with `DEFAULT_LLM` crashes startup whenever the env var points to an unsupported provider; consider using `.get(...)` with a safe fallback so custom providers don’t break the UI.</violation>
</file>
<file name="src/web_ui/webui/components/browser_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/browser_settings_tab.py:198">
The Gradio change handler close_wrapper is defined without accepting the value argument, but each .change(...) call will pass the component's new value, triggering a runtime TypeError and preventing the browser-close routine from running.</violation>
</file>
<file name="Dockerfile">
<violation number="1" location="Dockerfile:1">
Switching the base image to Python 3.14 keeps the apt-provided `python3-numpy`, whose binaries are built for CPython 3.11; under 3.14 the extension modules fail to load, so `import numpy` will break.</violation>
</file>
<file name="src/web_ui/utils/workflow_graph.py">
<violation number="1" location="src/web_ui/utils/workflow_graph.py:218">
Truthy checks here drop legitimate falsy results (0, False, ""), so result nodes incorrectly show “No result” and lose the actual value. Please guard specifically against None instead so real data is preserved.</violation>
</file>
<file name="setup-windows.ps1">
<violation number="1" location="setup-windows.ps1:40">
`winget install astral-sh.uv` needs explicit `$LASTEXITCODE` handling; otherwise we report success and continue even when the install fails and UV is still missing.</violation>
</file>
<file name=".claude/planning/01-PHASE1-REALTIME-UX.md">
<violation number="1" location=".claude/planning/01-PHASE1-REALTIME-UX.md:460">
run_with_status_updates references agent.stream_execution(), but no agent variable is defined in this scope. Use ui_manager.bu_agent (or the appropriate agent instance) to avoid a NameError at runtime.</violation>
</file>
<file name="src/web_ui/utils/mcp_config.py">
<violation number="1" location="src/web_ui/utils/mcp_config.py:32">
Please expand user home directories when resolving MCP_CONFIG_PATH so values like `~/...` work; otherwise the literal `~` path causes load/save to fail.</violation>
</file>
<file name="src/web_ui/observability/trace_models.py">
<violation number="1" location="src/web_ui/observability/trace_models.py:138">
Serializing final_output drops falsy but valid values (0, False, ""), causing loss of legitimate trace results. Replace the truthiness check with an explicit None check so only actual None becomes null.</violation>
</file>
<file name="src/web_ui/webui/components/browser_use_agent_tab.py">
<violation number="1" location="src/web_ui/webui/components/browser_use_agent_tab.py:760">
The final UI update always sets the progress banner to "Task completed successfully" even when the run ended with an error or cancellation because this assignment lives inside the finally block that executes for failure paths too. Please gate this status by the actual outcome (e.g., only show the success text when no error/cancellation occurred).</violation>
</file>
<file name=".claude/planning/08-QUICK-WINS-FIRST.md">
<violation number="1" location=".claude/planning/08-QUICK-WINS-FIRST.md:48">
The first replace call converts every ``` to a closing </code></pre>, leaving no opening tag and corrupting code blocks. Please replace this logic with a single regex substitution that wraps the block with both opening and closing tags.</violation>
</file>
<file name=".claude/planning/09-DECISION-FRAMEWORK.md">
<violation number="1" location=".claude/planning/09-DECISION-FRAMEWORK.md:60">
The complexity description says scores are inverted (11 - complexity), but the totals in the table are simple sums of the raw values. This mismatch will mislead anyone trying to recompute priorities.</violation>
</file>
<file name=".claude/settings.local.json">
<violation number="1" location=".claude/settings.local.json:8">
Hard-coding a personal D:\ path into this allow list makes the delete permission unusable anywhere else. Use a repository-relative or otherwise portable path so teammates/CI can run the same command.</violation>
</file>
<file name=".claude/planning/10-TESTING-STRATEGY.md">
<violation number="1" location=".claude/planning/10-TESTING-STRATEGY.md:122">
This example import still points to the old src.utils package; after the re-org the module lives under src/web_ui, so the documented snippet will fail with ModuleNotFoundError.</violation>
<violation number="2" location=".claude/planning/10-TESTING-STRATEGY.md:190">
The cost calculator import path is outdated; the module moved under src/web_ui, so this example would break when copied.</violation>
<violation number="3" location=".claude/planning/10-TESTING-STRATEGY.md:262">
The CustomBrowser import in this snippet targets the pre-refactor src.browser package; with code now under src/web_ui, the example will raise ModuleNotFoundError.</violation>
<violation number="4" location=".claude/planning/10-TESTING-STRATEGY.md:263">
This CustomBrowserContext import still points to src.browser, but the file now lives under src/web_ui/browser, so copying this example will fail.</violation>
<violation number="5" location=".claude/planning/10-TESTING-STRATEGY.md:441">
The BrowserUseAgent import still references src.agent, but the code now resides beneath src/web_ui after the refactor, so this guidance is incorrect.</violation>
<violation number="6" location=".claude/planning/10-TESTING-STRATEGY.md:443">
This CustomController import still targets the pre-reorg src.controller package; with files under src/web_ui/controller now, the example should be updated to the new path.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self.event_bus = get_event_bus() | ||
| self.session_id = kwargs.get("session_id", str(uuid.uuid4())) |
Contributor
There was a problem hiding this comment.
uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 396:
<comment>uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.</comment>
<file context>
@@ -0,0 +1,949 @@
+ def __init__(self, *args, **kwargs):
+ super().__init__(*args, **kwargs)
+ self.event_bus = get_event_bus()
+ self.session_id = kwargs.get("session_id", str(uuid.uuid4()))
+
+ async def run(self, max_steps: int = 100):
</file context>
| import asyncio | ||
| from datetime import datetime | ||
|
|
||
| from src.events.event_bus import get_event_bus, Event, EventType |
Contributor
There was a problem hiding this comment.
This import skips the web_ui package and will raise ImportError. Update it to import from src.web_ui.events.event_bus.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 229:
<comment>This import skips the web_ui package and will raise ImportError. Update it to import from src.web_ui.events.event_bus.</comment>
<file context>
@@ -0,0 +1,949 @@
+import asyncio
+from datetime import datetime
+
+from src.events.event_bus import get_event_bus, Event, EventType
+
+app = FastAPI(title="Browser Use Web UI API")
</file context>
Suggested change
| from src.events.event_bus import get_event_bus, Event, EventType | |
| from src.web_ui.events.event_bus import get_event_bus, Event, EventType |
| **File:** `src/web_ui/plugins/builtin/pdf_extractor/plugin.py` | ||
|
|
||
| ```python | ||
| from src.plugins.plugin_interface import Plugin, PluginManifest |
Contributor
There was a problem hiding this comment.
This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 619:
<comment>This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.</comment>
<file context>
@@ -0,0 +1,949 @@
+**File:** `src/web_ui/plugins/builtin/pdf_extractor/plugin.py`
+
+```python
+from src.plugins.plugin_interface import Plugin, PluginManifest
+from browser_use.controller.views import ActionResult
+from browser_use.browser.context import BrowserContext
</file context>
Suggested change
| from src.plugins.plugin_interface import Plugin, PluginManifest | |
| from src.web_ui.plugins.plugin_interface import Plugin, PluginManifest |
| all_components = list(self.id_to_component.values()) | ||
| for i, comp in enumerate(all_components): | ||
| if i < len(args): | ||
| components[comp] = args[i] |
Contributor
There was a problem hiding this comment.
save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.
Prompt for AI agents
Address the following comment on src/web_ui/webui/webui_manager.py at line 85:
<comment>save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.</comment>
<file context>
@@ -59,32 +55,42 @@ def add_components(self, tab_name: str, components_dict: dict[str, "Component"])
+ all_components = list(self.id_to_component.values())
+ for i, comp in enumerate(all_components):
+ if i < len(args):
+ components[comp] = args[i]
+
cur_settings = {}
</file context>
| )) | ||
|
|
||
| # Stream LLM tokens | ||
| async for token in self.llm.astream(messages): |
Contributor
There was a problem hiding this comment.
messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 431:
<comment>messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).</comment>
<file context>
@@ -0,0 +1,949 @@
+ ))
+
+ # Stream LLM tokens
+ async for token in self.llm.astream(messages):
+ await self.event_bus.publish(Event(
+ event_type=EventType.LLM_TOKEN,
</file context>
|
|
||
| ```python | ||
| import pytest | ||
| from src.observability.cost_calculator import calculate_llm_cost |
Contributor
There was a problem hiding this comment.
The cost calculator import path is outdated; the module moved under src/web_ui, so this example would break when copied.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 190:
<comment>The cost calculator import path is outdated; the module moved under src/web_ui, so this example would break when copied.</comment>
<file context>
@@ -0,0 +1,837 @@
+
+```python
+import pytest
+from src.observability.cost_calculator import calculate_llm_cost
+
+class TestCostCalculator:
</file context>
|
|
||
| ```python | ||
| import pytest | ||
| from src.utils.llm_provider import get_llm_model |
Contributor
There was a problem hiding this comment.
This example import still points to the old src.utils package; after the re-org the module lives under src/web_ui, so the documented snippet will fail with ModuleNotFoundError.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 122:
<comment>This example import still points to the old src.utils package; after the re-org the module lives under src/web_ui, so the documented snippet will fail with ModuleNotFoundError.</comment>
<file context>
@@ -0,0 +1,837 @@
+
+```python
+import pytest
+from src.utils.llm_provider import get_llm_model
+from unittest.mock import patch, MagicMock
+
</file context>
| import pytest | ||
| from src.agent.browser_use.browser_use_agent import BrowserUseAgent | ||
| from src.browser.custom_browser import CustomBrowser | ||
| from src.controller.custom_controller import CustomController |
Contributor
There was a problem hiding this comment.
This CustomController import still targets the pre-reorg src.controller package; with files under src/web_ui/controller now, the example should be updated to the new path.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 443:
<comment>This CustomController import still targets the pre-reorg src.controller package; with files under src/web_ui/controller now, the example should be updated to the new path.</comment>
<file context>
@@ -0,0 +1,837 @@
+import pytest
+from src.agent.browser_use.browser_use_agent import BrowserUseAgent
+from src.browser.custom_browser import CustomBrowser
+from src.controller.custom_controller import CustomController
+
[email protected]
</file context>
|
|
||
| ```python | ||
| import pytest | ||
| from src.agent.browser_use.browser_use_agent import BrowserUseAgent |
Contributor
There was a problem hiding this comment.
The BrowserUseAgent import still references src.agent, but the code now resides beneath src/web_ui after the refactor, so this guidance is incorrect.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 441:
<comment>The BrowserUseAgent import still references src.agent, but the code now resides beneath src/web_ui after the refactor, so this guidance is incorrect.</comment>
<file context>
@@ -0,0 +1,837 @@
+
+```python
+import pytest
+from src.agent.browser_use.browser_use_agent import BrowserUseAgent
+from src.browser.custom_browser import CustomBrowser
+from src.controller.custom_controller import CustomController
</file context>
| import pytest | ||
| from playwright.async_api import async_playwright | ||
| from src.browser.custom_browser import CustomBrowser | ||
| from src.browser.custom_context import CustomBrowserContext |
Contributor
There was a problem hiding this comment.
This CustomBrowserContext import still points to src.browser, but the file now lives under src/web_ui/browser, so copying this example will fail.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 263:
<comment>This CustomBrowserContext import still points to src.browser, but the file now lives under src/web_ui/browser, so copying this example will fail.</comment>
<file context>
@@ -0,0 +1,837 @@
+import pytest
+from playwright.async_api import async_playwright
+from src.browser.custom_browser import CustomBrowser
+from src.browser.custom_context import CustomBrowserContext
+
[email protected]
</file context>
Contributor
There was a problem hiding this comment.
40 issues found across 83 files
Prompt for AI agents (all 40 issues)
Understand the root cause of the following 40 issues and fix them.
<file name=".claude/planning/04-PHASE4-ARCHITECTURE.md">
<violation number="1" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:137">
os.getenv is used here without importing os, so EventBus will crash when using the Redis backend. Please add the missing os import.</violation>
<violation number="2" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:229">
This import skips the web_ui package and will raise ImportError. Update it to import from src.web_ui.events.event_bus.</violation>
<violation number="3" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:319">
logger is undefined here, so handling a WebSocket error will raise NameError. Import logging and define logger before using it.</violation>
<violation number="4" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:396">
uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.</violation>
<violation number="5" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:431">
messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).</violation>
<violation number="6" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:440">
model_output is never defined before use, so this loop will raise NameError. Ensure you compute the model output before iterating over actions.</violation>
<violation number="7" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:619">
This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.</violation>
<violation number="8" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:784">
manifest_data contains fields (e.g., homepage, dependencies as dict) not defined on PluginManifest, so this call will raise TypeError. Normalize/trim the payload or extend PluginManifest before instantiating it.</violation>
<violation number="9" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:811">
The derived class name doesn't match the provided plugin (PDFExtractorPlugin), so this will raise AttributeError. Adjust the naming convention or provide an explicit class lookup.</violation>
</file>
<file name="src/web_ui/webui/webui_manager.py">
<violation number="1" location="src/web_ui/webui/webui_manager.py:85">
save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.</violation>
</file>
<file name="src/web_ui/observability/cost_calculator.py">
<violation number="1" location="src/web_ui/observability/cost_calculator.py:54">
`calculate_llm_cost` should only short-circuit when both input and output token counts are zero. As written it returns 0 for any call where one side is zero, misreporting cost for legitimate usage.</violation>
</file>
<file name="src/web_ui/events/event_bus.py">
<violation number="1" location="src/web_ui/events/event_bus.py:134">
When EVENT_BUS_BACKEND is set to "redis", publish() only pushes to Redis and never invokes the in-process subscribers stored by subscribe(), so handlers in the current process stop receiving events. Please still dispatch to local subscribers before (or in addition to) publishing to Redis.</violation>
</file>
<file name=".claude/planning/03-PHASE3-OBSERVABILITY.md">
<violation number="1" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:35">
ExecutionTrace.to_dict calls asdict(span), but this file only imports dataclass and field; running this code will throw a NameError. Please import asdict here so serialization works.</violation>
<violation number="2" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:245">
The observability modules live under src/web_ui/observability/, so importing from src.observability.tracer will fail at runtime. Please correct the path.</violation>
<violation number="3" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:316">
TraceStorage lives under src/web_ui/observability/, so importing from src.observability.trace_storage will fail. Please include the web_ui segment.</violation>
<violation number="4" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:355">
logger is never defined in this snippet, so calling logger.warning here will crash. Please define a logger or use logging.warning before logging unknown models.</violation>
</file>
<file name=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md">
<violation number="1" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:161">
`NodeDetailsPanel` is referenced here but no component or import with that name exists, so the React build will fail.</violation>
<violation number="2" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:474">
`chatbot_messages` is undefined in this context, so yielding it will raise a NameError during execution.</violation>
<violation number="3" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:598">
`base64` is used here without being imported, so this line raises a NameError when executed.</violation>
<violation number="4" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:661">
`RecordedAction` is referenced in this annotation without being imported or forward-declared, so class definition raises a NameError.</violation>
<violation number="5" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:830">
Looking up the action index only inside `steps[0]` raises `ValueError` for actions in later steps, breaking multi-step replays.</violation>
</file>
<file name="pyproject.toml">
<violation number="1" location="pyproject.toml:52">
The console script targets webui:main, but only packages named web_ui* are included, so the module webui is missing at runtime. Point the entry point at the actual installed module to avoid a ModuleNotFoundError.</violation>
</file>
<file name="src/web_ui/webui/components/agent_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/agent_settings_tab.py:123">
Indexing `config.model_names` with `DEFAULT_LLM` crashes startup whenever the env var points to an unsupported provider; consider using `.get(...)` with a safe fallback so custom providers don’t break the UI.</violation>
</file>
<file name="src/web_ui/webui/components/browser_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/browser_settings_tab.py:198">
The Gradio change handler close_wrapper is defined without accepting the value argument, but each .change(...) call will pass the component's new value, triggering a runtime TypeError and preventing the browser-close routine from running.</violation>
</file>
<file name="Dockerfile">
<violation number="1" location="Dockerfile:1">
Switching the base image to Python 3.14 keeps the apt-provided `python3-numpy`, whose binaries are built for CPython 3.11; under 3.14 the extension modules fail to load, so `import numpy` will break.</violation>
</file>
<file name="src/web_ui/utils/workflow_graph.py">
<violation number="1" location="src/web_ui/utils/workflow_graph.py:218">
Truthy checks here drop legitimate falsy results (0, False, ""), so result nodes incorrectly show “No result” and lose the actual value. Please guard specifically against None instead so real data is preserved.</violation>
</file>
<file name="setup-windows.ps1">
<violation number="1" location="setup-windows.ps1:40">
`winget install astral-sh.uv` needs explicit `$LASTEXITCODE` handling; otherwise we report success and continue even when the install fails and UV is still missing.</violation>
</file>
<file name=".claude/planning/01-PHASE1-REALTIME-UX.md">
<violation number="1" location=".claude/planning/01-PHASE1-REALTIME-UX.md:460">
run_with_status_updates references agent.stream_execution(), but no agent variable is defined in this scope. Use ui_manager.bu_agent (or the appropriate agent instance) to avoid a NameError at runtime.</violation>
</file>
<file name="src/web_ui/utils/mcp_config.py">
<violation number="1" location="src/web_ui/utils/mcp_config.py:32">
Please expand user home directories when resolving MCP_CONFIG_PATH so values like `~/...` work; otherwise the literal `~` path causes load/save to fail.</violation>
</file>
<file name="src/web_ui/observability/trace_models.py">
<violation number="1" location="src/web_ui/observability/trace_models.py:138">
Serializing final_output drops falsy but valid values (0, False, ""), causing loss of legitimate trace results. Replace the truthiness check with an explicit None check so only actual None becomes null.</violation>
</file>
<file name="src/web_ui/webui/components/browser_use_agent_tab.py">
<violation number="1" location="src/web_ui/webui/components/browser_use_agent_tab.py:760">
The final UI update always sets the progress banner to "Task completed successfully" even when the run ended with an error or cancellation because this assignment lives inside the finally block that executes for failure paths too. Please gate this status by the actual outcome (e.g., only show the success text when no error/cancellation occurred).</violation>
</file>
<file name=".claude/planning/08-QUICK-WINS-FIRST.md">
<violation number="1" location=".claude/planning/08-QUICK-WINS-FIRST.md:48">
The first replace call converts every ``` to a closing </code></pre>, leaving no opening tag and corrupting code blocks. Please replace this logic with a single regex substitution that wraps the block with both opening and closing tags.</violation>
</file>
<file name=".claude/planning/09-DECISION-FRAMEWORK.md">
<violation number="1" location=".claude/planning/09-DECISION-FRAMEWORK.md:60">
The complexity description says scores are inverted (11 - complexity), but the totals in the table are simple sums of the raw values. This mismatch will mislead anyone trying to recompute priorities.</violation>
</file>
<file name=".claude/settings.local.json">
<violation number="1" location=".claude/settings.local.json:8">
Hard-coding a personal D:\ path into this allow list makes the delete permission unusable anywhere else. Use a repository-relative or otherwise portable path so teammates/CI can run the same command.</violation>
</file>
<file name=".claude/planning/10-TESTING-STRATEGY.md">
<violation number="1" location=".claude/planning/10-TESTING-STRATEGY.md:122">
This example import still points to the old src.utils package; after the re-org the module lives under src/web_ui, so the documented snippet will fail with ModuleNotFoundError.</violation>
<violation number="2" location=".claude/planning/10-TESTING-STRATEGY.md:190">
The cost calculator import path is outdated; the module moved under src/web_ui, so this example would break when copied.</violation>
<violation number="3" location=".claude/planning/10-TESTING-STRATEGY.md:262">
The CustomBrowser import in this snippet targets the pre-refactor src.browser package; with code now under src/web_ui, the example will raise ModuleNotFoundError.</violation>
<violation number="4" location=".claude/planning/10-TESTING-STRATEGY.md:263">
This CustomBrowserContext import still points to src.browser, but the file now lives under src/web_ui/browser, so copying this example will fail.</violation>
<violation number="5" location=".claude/planning/10-TESTING-STRATEGY.md:441">
The BrowserUseAgent import still references src.agent, but the code now resides beneath src/web_ui after the refactor, so this guidance is incorrect.</violation>
<violation number="6" location=".claude/planning/10-TESTING-STRATEGY.md:443">
This CustomController import still targets the pre-reorg src.controller package; with files under src/web_ui/controller now, the example should be updated to the new path.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self.event_bus = get_event_bus() | ||
| self.session_id = kwargs.get("session_id", str(uuid.uuid4())) |
Contributor
There was a problem hiding this comment.
uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 396:
<comment>uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.</comment>
<file context>
@@ -0,0 +1,949 @@
+ def __init__(self, *args, **kwargs):
+ super().__init__(*args, **kwargs)
+ self.event_bus = get_event_bus()
+ self.session_id = kwargs.get("session_id", str(uuid.uuid4()))
+
+ async def run(self, max_steps: int = 100):
</file context>
| import asyncio | ||
| from datetime import datetime | ||
|
|
||
| from src.events.event_bus import get_event_bus, Event, EventType |
Contributor
There was a problem hiding this comment.
This import skips the web_ui package and will raise ImportError. Update it to import from src.web_ui.events.event_bus.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 229:
<comment>This import skips the web_ui package and will raise ImportError. Update it to import from src.web_ui.events.event_bus.</comment>
<file context>
@@ -0,0 +1,949 @@
+import asyncio
+from datetime import datetime
+
+from src.events.event_bus import get_event_bus, Event, EventType
+
+app = FastAPI(title="Browser Use Web UI API")
</file context>
Suggested change
| from src.events.event_bus import get_event_bus, Event, EventType | |
| from src.web_ui.events.event_bus import get_event_bus, Event, EventType |
| **File:** `src/web_ui/plugins/builtin/pdf_extractor/plugin.py` | ||
|
|
||
| ```python | ||
| from src.plugins.plugin_interface import Plugin, PluginManifest |
Contributor
There was a problem hiding this comment.
This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 619:
<comment>This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.</comment>
<file context>
@@ -0,0 +1,949 @@
+**File:** `src/web_ui/plugins/builtin/pdf_extractor/plugin.py`
+
+```python
+from src.plugins.plugin_interface import Plugin, PluginManifest
+from browser_use.controller.views import ActionResult
+from browser_use.browser.context import BrowserContext
</file context>
Suggested change
| from src.plugins.plugin_interface import Plugin, PluginManifest | |
| from src.web_ui.plugins.plugin_interface import Plugin, PluginManifest |
| all_components = list(self.id_to_component.values()) | ||
| for i, comp in enumerate(all_components): | ||
| if i < len(args): | ||
| components[comp] = args[i] |
Contributor
There was a problem hiding this comment.
save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.
Prompt for AI agents
Address the following comment on src/web_ui/webui/webui_manager.py at line 85:
<comment>save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.</comment>
<file context>
@@ -59,32 +55,42 @@ def add_components(self, tab_name: str, components_dict: dict[str, "Component"])
+ all_components = list(self.id_to_component.values())
+ for i, comp in enumerate(all_components):
+ if i < len(args):
+ components[comp] = args[i]
+
cur_settings = {}
</file context>
| )) | ||
|
|
||
| # Stream LLM tokens | ||
| async for token in self.llm.astream(messages): |
Contributor
There was a problem hiding this comment.
messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 431:
<comment>messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).</comment>
<file context>
@@ -0,0 +1,949 @@
+ ))
+
+ # Stream LLM tokens
+ async for token in self.llm.astream(messages):
+ await self.event_bus.publish(Event(
+ event_type=EventType.LLM_TOKEN,
</file context>
Contributor
There was a problem hiding this comment.
40 issues found across 83 files
Prompt for AI agents (all 40 issues)
Understand the root cause of the following 40 issues and fix them.
<file name=".claude/planning/04-PHASE4-ARCHITECTURE.md">
<violation number="1" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:137">
os.getenv is used here without importing os, so EventBus will crash when using the Redis backend. Please add the missing os import.</violation>
<violation number="2" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:229">
This import skips the web_ui package and will raise ImportError. Update it to import from src.web_ui.events.event_bus.</violation>
<violation number="3" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:319">
logger is undefined here, so handling a WebSocket error will raise NameError. Import logging and define logger before using it.</violation>
<violation number="4" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:396">
uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.</violation>
<violation number="5" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:431">
messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).</violation>
<violation number="6" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:440">
model_output is never defined before use, so this loop will raise NameError. Ensure you compute the model output before iterating over actions.</violation>
<violation number="7" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:619">
This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.</violation>
<violation number="8" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:784">
manifest_data contains fields (e.g., homepage, dependencies as dict) not defined on PluginManifest, so this call will raise TypeError. Normalize/trim the payload or extend PluginManifest before instantiating it.</violation>
<violation number="9" location=".claude/planning/04-PHASE4-ARCHITECTURE.md:811">
The derived class name doesn't match the provided plugin (PDFExtractorPlugin), so this will raise AttributeError. Adjust the naming convention or provide an explicit class lookup.</violation>
</file>
<file name="src/web_ui/webui/webui_manager.py">
<violation number="1" location="src/web_ui/webui/webui_manager.py:85">
save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.</violation>
</file>
<file name="src/web_ui/observability/cost_calculator.py">
<violation number="1" location="src/web_ui/observability/cost_calculator.py:54">
`calculate_llm_cost` should only short-circuit when both input and output token counts are zero. As written it returns 0 for any call where one side is zero, misreporting cost for legitimate usage.</violation>
</file>
<file name="src/web_ui/events/event_bus.py">
<violation number="1" location="src/web_ui/events/event_bus.py:134">
When EVENT_BUS_BACKEND is set to "redis", publish() only pushes to Redis and never invokes the in-process subscribers stored by subscribe(), so handlers in the current process stop receiving events. Please still dispatch to local subscribers before (or in addition to) publishing to Redis.</violation>
</file>
<file name=".claude/planning/03-PHASE3-OBSERVABILITY.md">
<violation number="1" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:35">
ExecutionTrace.to_dict calls asdict(span), but this file only imports dataclass and field; running this code will throw a NameError. Please import asdict here so serialization works.</violation>
<violation number="2" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:245">
The observability modules live under src/web_ui/observability/, so importing from src.observability.tracer will fail at runtime. Please correct the path.</violation>
<violation number="3" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:316">
TraceStorage lives under src/web_ui/observability/, so importing from src.observability.trace_storage will fail. Please include the web_ui segment.</violation>
<violation number="4" location=".claude/planning/03-PHASE3-OBSERVABILITY.md:355">
logger is never defined in this snippet, so calling logger.warning here will crash. Please define a logger or use logging.warning before logging unknown models.</violation>
</file>
<file name=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md">
<violation number="1" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:161">
`NodeDetailsPanel` is referenced here but no component or import with that name exists, so the React build will fail.</violation>
<violation number="2" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:474">
`chatbot_messages` is undefined in this context, so yielding it will raise a NameError during execution.</violation>
<violation number="3" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:598">
`base64` is used here without being imported, so this line raises a NameError when executed.</violation>
<violation number="4" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:661">
`RecordedAction` is referenced in this annotation without being imported or forward-declared, so class definition raises a NameError.</violation>
<violation number="5" location=".claude/planning/02-PHASE2-VISUAL-WORKFLOW.md:830">
Looking up the action index only inside `steps[0]` raises `ValueError` for actions in later steps, breaking multi-step replays.</violation>
</file>
<file name="pyproject.toml">
<violation number="1" location="pyproject.toml:52">
The console script targets webui:main, but only packages named web_ui* are included, so the module webui is missing at runtime. Point the entry point at the actual installed module to avoid a ModuleNotFoundError.</violation>
</file>
<file name="src/web_ui/webui/components/agent_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/agent_settings_tab.py:123">
Indexing `config.model_names` with `DEFAULT_LLM` crashes startup whenever the env var points to an unsupported provider; consider using `.get(...)` with a safe fallback so custom providers don’t break the UI.</violation>
</file>
<file name="src/web_ui/webui/components/browser_settings_tab.py">
<violation number="1" location="src/web_ui/webui/components/browser_settings_tab.py:198">
The Gradio change handler close_wrapper is defined without accepting the value argument, but each .change(...) call will pass the component's new value, triggering a runtime TypeError and preventing the browser-close routine from running.</violation>
</file>
<file name="Dockerfile">
<violation number="1" location="Dockerfile:1">
Switching the base image to Python 3.14 keeps the apt-provided `python3-numpy`, whose binaries are built for CPython 3.11; under 3.14 the extension modules fail to load, so `import numpy` will break.</violation>
</file>
<file name="src/web_ui/utils/workflow_graph.py">
<violation number="1" location="src/web_ui/utils/workflow_graph.py:218">
Truthy checks here drop legitimate falsy results (0, False, ""), so result nodes incorrectly show “No result” and lose the actual value. Please guard specifically against None instead so real data is preserved.</violation>
</file>
<file name="setup-windows.ps1">
<violation number="1" location="setup-windows.ps1:40">
`winget install astral-sh.uv` needs explicit `$LASTEXITCODE` handling; otherwise we report success and continue even when the install fails and UV is still missing.</violation>
</file>
<file name=".claude/planning/01-PHASE1-REALTIME-UX.md">
<violation number="1" location=".claude/planning/01-PHASE1-REALTIME-UX.md:460">
run_with_status_updates references agent.stream_execution(), but no agent variable is defined in this scope. Use ui_manager.bu_agent (or the appropriate agent instance) to avoid a NameError at runtime.</violation>
</file>
<file name="src/web_ui/utils/mcp_config.py">
<violation number="1" location="src/web_ui/utils/mcp_config.py:32">
Please expand user home directories when resolving MCP_CONFIG_PATH so values like `~/...` work; otherwise the literal `~` path causes load/save to fail.</violation>
</file>
<file name="src/web_ui/observability/trace_models.py">
<violation number="1" location="src/web_ui/observability/trace_models.py:138">
Serializing final_output drops falsy but valid values (0, False, ""), causing loss of legitimate trace results. Replace the truthiness check with an explicit None check so only actual None becomes null.</violation>
</file>
<file name="src/web_ui/webui/components/browser_use_agent_tab.py">
<violation number="1" location="src/web_ui/webui/components/browser_use_agent_tab.py:760">
The final UI update always sets the progress banner to "Task completed successfully" even when the run ended with an error or cancellation because this assignment lives inside the finally block that executes for failure paths too. Please gate this status by the actual outcome (e.g., only show the success text when no error/cancellation occurred).</violation>
</file>
<file name=".claude/planning/08-QUICK-WINS-FIRST.md">
<violation number="1" location=".claude/planning/08-QUICK-WINS-FIRST.md:48">
The first replace call converts every ``` to a closing </code></pre>, leaving no opening tag and corrupting code blocks. Please replace this logic with a single regex substitution that wraps the block with both opening and closing tags.</violation>
</file>
<file name=".claude/planning/09-DECISION-FRAMEWORK.md">
<violation number="1" location=".claude/planning/09-DECISION-FRAMEWORK.md:60">
The complexity description says scores are inverted (11 - complexity), but the totals in the table are simple sums of the raw values. This mismatch will mislead anyone trying to recompute priorities.</violation>
</file>
<file name=".claude/settings.local.json">
<violation number="1" location=".claude/settings.local.json:8">
Hard-coding a personal D:\ path into this allow list makes the delete permission unusable anywhere else. Use a repository-relative or otherwise portable path so teammates/CI can run the same command.</violation>
</file>
<file name=".claude/planning/10-TESTING-STRATEGY.md">
<violation number="1" location=".claude/planning/10-TESTING-STRATEGY.md:122">
This example import still points to the old src.utils package; after the re-org the module lives under src/web_ui, so the documented snippet will fail with ModuleNotFoundError.</violation>
<violation number="2" location=".claude/planning/10-TESTING-STRATEGY.md:190">
The cost calculator import path is outdated; the module moved under src/web_ui, so this example would break when copied.</violation>
<violation number="3" location=".claude/planning/10-TESTING-STRATEGY.md:262">
The CustomBrowser import in this snippet targets the pre-refactor src.browser package; with code now under src/web_ui, the example will raise ModuleNotFoundError.</violation>
<violation number="4" location=".claude/planning/10-TESTING-STRATEGY.md:263">
This CustomBrowserContext import still points to src.browser, but the file now lives under src/web_ui/browser, so copying this example will fail.</violation>
<violation number="5" location=".claude/planning/10-TESTING-STRATEGY.md:441">
The BrowserUseAgent import still references src.agent, but the code now resides beneath src/web_ui after the refactor, so this guidance is incorrect.</violation>
<violation number="6" location=".claude/planning/10-TESTING-STRATEGY.md:443">
This CustomController import still targets the pre-reorg src.controller package; with files under src/web_ui/controller now, the example should be updated to the new path.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self.event_bus = get_event_bus() | ||
| self.session_id = kwargs.get("session_id", str(uuid.uuid4())) |
Contributor
There was a problem hiding this comment.
uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 396:
<comment>uuid is not imported, so creating an EventDrivenAgent without session_id will raise NameError. Please add the missing import.</comment>
<file context>
@@ -0,0 +1,949 @@
+ def __init__(self, *args, **kwargs):
+ super().__init__(*args, **kwargs)
+ self.event_bus = get_event_bus()
+ self.session_id = kwargs.get("session_id", str(uuid.uuid4()))
+
+ async def run(self, max_steps: int = 100):
</file context>
| **File:** `src/web_ui/plugins/builtin/pdf_extractor/plugin.py` | ||
|
|
||
| ```python | ||
| from src.plugins.plugin_interface import Plugin, PluginManifest |
Contributor
There was a problem hiding this comment.
This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 619:
<comment>This module is under src.web_ui.plugins, so importing from src.plugins.plugin_interface will fail. Update the path to src.web_ui.plugins.plugin_interface.</comment>
<file context>
@@ -0,0 +1,949 @@
+**File:** `src/web_ui/plugins/builtin/pdf_extractor/plugin.py`
+
+```python
+from src.plugins.plugin_interface import Plugin, PluginManifest
+from browser_use.controller.views import ActionResult
+from browser_use.browser.context import BrowserContext
</file context>
Suggested change
| from src.plugins.plugin_interface import Plugin, PluginManifest | |
| from src.web_ui.plugins.plugin_interface import Plugin, PluginManifest |
| all_components = list(self.id_to_component.values()) | ||
| for i, comp in enumerate(all_components): | ||
| if i < len(args): | ||
| components[comp] = args[i] |
Contributor
There was a problem hiding this comment.
save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.
Prompt for AI agents
Address the following comment on src/web_ui/webui/webui_manager.py at line 85:
<comment>save_config now assumes positional values, but callers still pass a components dict. The first component therefore receives the entire dict, leading to non-serializable component objects in cur_settings and causing json.dump to fail.</comment>
<file context>
@@ -59,32 +55,42 @@ def add_components(self, tab_name: str, components_dict: dict[str, "Component"])
+ all_components = list(self.id_to_component.values())
+ for i, comp in enumerate(all_components):
+ if i < len(args):
+ components[comp] = args[i]
+
cur_settings = {}
</file context>
| )) | ||
|
|
||
| # Stream LLM tokens | ||
| async for token in self.llm.astream(messages): |
Contributor
There was a problem hiding this comment.
messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).
Prompt for AI agents
Address the following comment on .claude/planning/04-PHASE4-ARCHITECTURE.md at line 431:
<comment>messages is undefined here. Capture the message list before streaming (e.g., messages = self.message_manager.get_messages()).</comment>
<file context>
@@ -0,0 +1,949 @@
+ ))
+
+ # Stream LLM tokens
+ async for token in self.llm.astream(messages):
+ await self.event_bus.publish(Event(
+ event_type=EventType.LLM_TOKEN,
</file context>
|
|
||
| ```python | ||
| import pytest | ||
| from src.observability.cost_calculator import calculate_llm_cost |
Contributor
There was a problem hiding this comment.
The cost calculator import path is outdated; the module moved under src/web_ui, so this example would break when copied.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 190:
<comment>The cost calculator import path is outdated; the module moved under src/web_ui, so this example would break when copied.</comment>
<file context>
@@ -0,0 +1,837 @@
+
+```python
+import pytest
+from src.observability.cost_calculator import calculate_llm_cost
+
+class TestCostCalculator:
</file context>
|
|
||
| ```python | ||
| import pytest | ||
| from src.utils.llm_provider import get_llm_model |
Contributor
There was a problem hiding this comment.
This example import still points to the old src.utils package; after the re-org the module lives under src/web_ui, so the documented snippet will fail with ModuleNotFoundError.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 122:
<comment>This example import still points to the old src.utils package; after the re-org the module lives under src/web_ui, so the documented snippet will fail with ModuleNotFoundError.</comment>
<file context>
@@ -0,0 +1,837 @@
+
+```python
+import pytest
+from src.utils.llm_provider import get_llm_model
+from unittest.mock import patch, MagicMock
+
</file context>
| import pytest | ||
| from src.agent.browser_use.browser_use_agent import BrowserUseAgent | ||
| from src.browser.custom_browser import CustomBrowser | ||
| from src.controller.custom_controller import CustomController |
Contributor
There was a problem hiding this comment.
This CustomController import still targets the pre-reorg src.controller package; with files under src/web_ui/controller now, the example should be updated to the new path.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 443:
<comment>This CustomController import still targets the pre-reorg src.controller package; with files under src/web_ui/controller now, the example should be updated to the new path.</comment>
<file context>
@@ -0,0 +1,837 @@
+import pytest
+from src.agent.browser_use.browser_use_agent import BrowserUseAgent
+from src.browser.custom_browser import CustomBrowser
+from src.controller.custom_controller import CustomController
+
[email protected]
</file context>
|
|
||
| ```python | ||
| import pytest | ||
| from src.agent.browser_use.browser_use_agent import BrowserUseAgent |
Contributor
There was a problem hiding this comment.
The BrowserUseAgent import still references src.agent, but the code now resides beneath src/web_ui after the refactor, so this guidance is incorrect.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 441:
<comment>The BrowserUseAgent import still references src.agent, but the code now resides beneath src/web_ui after the refactor, so this guidance is incorrect.</comment>
<file context>
@@ -0,0 +1,837 @@
+
+```python
+import pytest
+from src.agent.browser_use.browser_use_agent import BrowserUseAgent
+from src.browser.custom_browser import CustomBrowser
+from src.controller.custom_controller import CustomController
</file context>
| import pytest | ||
| from playwright.async_api import async_playwright | ||
| from src.browser.custom_browser import CustomBrowser | ||
| from src.browser.custom_context import CustomBrowserContext |
Contributor
There was a problem hiding this comment.
This CustomBrowserContext import still points to src.browser, but the file now lives under src/web_ui/browser, so copying this example will fail.
Prompt for AI agents
Address the following comment on .claude/planning/10-TESTING-STRATEGY.md at line 263:
<comment>This CustomBrowserContext import still points to src.browser, but the file now lives under src/web_ui/browser, so copying this example will fail.</comment>
<file context>
@@ -0,0 +1,837 @@
+import pytest
+from playwright.async_api import async_playwright
+from src.browser.custom_browser import CustomBrowser
+from src.browser.custom_context import CustomBrowserContext
+
[email protected]
</file context>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
- Deleted multiple planning documents related to the enhancement overview, phases, technical specifications, deployment guide, and testing strategy. - Removed associated images that were no longer needed for the project. This cleanup helps streamline the repository and focuses on the current implementation needs.
- Added '.claude/' to the .gitignore file to prevent tracking of generated files. - Retained existing entry for 'workflow' to maintain clean repository management. This change helps ensure that unnecessary files are not included in version control.
…ed user experience - Added a new dashboard component consolidating agent selection, task input, and control buttons for both Browser Use Agent and Deep Research Agent. - Implemented a collapsible settings panel with configurations for LLM, Browser, and MCP, allowing for streamlined user adjustments. - Enhanced UI with responsive design, improved navigation, and integrated help modal for user guidance. - Introduced new components for status display, quick presets, and task history, improving overall usability and accessibility. - Established a robust event-driven architecture for managing interactions and state across the dashboard. This update significantly enhances the user interface and experience, making it easier for users to manage tasks and configurations effectively.
- Updated PowerShell commands for terminating processes on ports 7788 and 8080 to use a more efficient method for retrieving the process ID. - Replaced the previous method of handling multiple lines with a streamlined approach that selects the first matching line and splits it for the process ID extraction. This change enhances the reliability and clarity of the process termination logic in the development environment.
- Deleted the BACKEND_IMPROVEMENTS.md, DEBUG_SETTINGS_BUTTON.md, SESSION_SUMMARY.md, and test_dashboard.py files as they are no longer relevant to the current project structure and implementation. - This cleanup helps streamline the repository and focuses on maintaining only necessary and up-to-date documentation and test cases.
savagelysubtle
commented
Oct 28, 2025
Author
savagelysubtle
left a comment
savagelysubtle
left a comment
There was a problem hiding this comment.
I checked through this the AI is looking at a .claude doc
- Commented out the previous entry for 'data/' to reflect its new usage for settings. - Added specific ignore rules for the 'data/' directory, allowing only '.gitkeep' and 'README.md' to be tracked. - Updated ignore patterns for '.claude/' to prevent tracking of generated files. These changes enhance repository cleanliness and ensure proper management of configuration files.
…directories - Added entries for '.claude/' and '.cursor/' to prevent tracking of IDE and editor configuration files. - This change helps maintain a clean repository by excluding unnecessary files from version control.
removing all .claude from pull request
deleting all .claude from pull request
…tool - Updated MCP configuration paths to use `data/mcp.json` instead of the root directory, ensuring better organization of settings. - Added a new diagnostic tool (`diagnose_dropdown_issue.py`) to assist in troubleshooting LLM provider dropdown issues, enhancing user support. - Created a `data` directory with a README to document its purpose and structure for persistent settings. - Improved the settings management in the Web UI, including migration of old settings and default settings loading. - Enhanced logging and error handling for MCP client setup and model dropdown updates, improving overall reliability.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
savagelysubtle
commented
Nov 9, 2025
Author
savagelysubtle
left a comment
savagelysubtle
left a comment
There was a problem hiding this comment.
I reviewed the agents comments they are mostly on planning which I have deleted the entire .clude folder which has removed many comments and issues
Contributor
There was a problem hiding this comment.
Reviewed changes from recent commits (found 8 issues).
8 issues found across 34 files
Prompt for AI agents (all 8 issues)
Understand the root cause of the following 8 issues and fix them.
<file name="tests/test_controller.py">
<violation number="1" location="tests/test_controller.py:71">
Calling `tool_param_model()` here raises a ValidationError whenever the generated schema defines required fields, so the fallback path still fails. Call `schema()` on the model class instead of instantiating it.</violation>
</file>
<file name="diagnose_dropdown_issue.py">
<violation number="1" location="diagnose_dropdown_issue.py:74">
This file open relies on the current working directory instead of the computed project_root, so running the diagnostic from another directory fails. Use project_root to build the path.</violation>
<violation number="2" location="diagnose_dropdown_issue.py:83">
Like the previous open(), this relative path breaks when the script is run outside the repo root. Build the path from project_root to keep the diagnostic portable.</violation>
</file>
<file name="src/web_ui/webui/webui_manager.py">
<violation number="1" location="src/web_ui/webui/webui_manager.py:194">
`comp.value` ends up storing the new Component object instead of the underlying value, corrupting the UI state when default settings load. Use the component's value payload instead.</violation>
<violation number="2" location="src/web_ui/webui/webui_manager.py:208">
The model dropdown lookup uses the stale `comp_id` from the last loop iteration, so default settings often skip updating the model list for the selected provider.</violation>
</file>
<file name="src/web_ui/webui/components/dashboard_settings.py">
<violation number="1" location="src/web_ui/webui/components/dashboard_settings.py:461">
We still need to register these components under the legacy `agent_settings` namespace—other tabs (e.g., Deep Research) call `get_setting("agent_settings", ...)` and will now receive `None`, causing their LLM setup to fail.</violation>
</file>
<file name="docs/LANGGRAPH_MIGRATION_PLAN.md">
<violation number="1" location="docs/LANGGRAPH_MIGRATION_PLAN.md:359">
Token trimming assumes message.content is always a string. LangChain tool-call replies give BaseMessage.content as structured data, so this implementation will crash when tiktoken.encode sees a list/dict.</violation>
</file>
<file name="src/web_ui/webui/components/dashboard_sidebar.py">
<violation number="1" location="src/web_ui/webui/components/dashboard_sidebar.py:177">
Task descriptions from recent_tasks are rendered without escaping, so HTML or script content in a task will execute when the history list renders. Please HTML-escape these values before inserting them.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| print(tool_param_model.model_json_schema()) | ||
| except AttributeError: | ||
| # Fallback for older Pydantic versions | ||
| print(tool_param_model().schema()) # type: ignore[deprecated] |
Contributor
There was a problem hiding this comment.
Calling tool_param_model() here raises a ValidationError whenever the generated schema defines required fields, so the fallback path still fails. Call schema() on the model class instead of instantiating it.
Prompt for AI agents
Address the following comment on tests/test_controller.py at line 71:
<comment>Calling `tool_param_model()` here raises a ValidationError whenever the generated schema defines required fields, so the fallback path still fails. Call `schema()` on the model class instead of instantiating it.</comment>
<file context>
@@ -65,10 +65,10 @@ async def test_mcp_client():
except AttributeError:
# Fallback for older Pydantic versions
- print(tool_param_model().schema())
+ print(tool_param_model().schema()) # type: ignore[deprecated]
pdb.set_trace()
</file context>
Suggested change
| print(tool_param_model().schema()) # type: ignore[deprecated] | |
| print(tool_param_model.schema()) # type: ignore[deprecated] |
diagnose_dropdown_issue.py
Outdated
| else: | ||
| print("✅ Event handlers removed from dashboard_settings.py") | ||
|
|
||
| with open("src/web_ui/webui/interface.py") as f: |
Contributor
There was a problem hiding this comment.
Like the previous open(), this relative path breaks when the script is run outside the repo root. Build the path from project_root to keep the diagnostic portable.
Prompt for AI agents
Address the following comment on diagnose_dropdown_issue.py at line 83:
<comment>Like the previous open(), this relative path breaks when the script is run outside the repo root. Build the path from project_root to keep the diagnostic portable.</comment>
<file context>
@@ -0,0 +1,165 @@
+ else:
+ print("✅ Event handlers removed from dashboard_settings.py")
+
+ with open("src/web_ui/webui/interface.py") as f:
+ content = f.read()
+
</file context>
Suggested change
| with open("src/web_ui/webui/interface.py") as f: | |
| with open(project_root / "src/web_ui/webui/interface.py") as f: |
✅ Addressed in a84e164
diagnose_dropdown_issue.py
Outdated
| # Step 4: Check if dashboard_settings.py has event handlers removed | ||
| print("\n[STEP 4] Verifying event handlers are in interface.py (not dashboard_settings.py)...") | ||
| try: | ||
| with open("src/web_ui/webui/components/dashboard_settings.py") as f: |
Contributor
There was a problem hiding this comment.
This file open relies on the current working directory instead of the computed project_root, so running the diagnostic from another directory fails. Use project_root to build the path.
Prompt for AI agents
Address the following comment on diagnose_dropdown_issue.py at line 74:
<comment>This file open relies on the current working directory instead of the computed project_root, so running the diagnostic from another directory fails. Use project_root to build the path.</comment>
<file context>
@@ -0,0 +1,165 @@
+# Step 4: Check if dashboard_settings.py has event handlers removed
+print("\n[STEP 4] Verifying event handlers are in interface.py (not dashboard_settings.py)...")
+try:
+ with open("src/web_ui/webui/components/dashboard_settings.py") as f:
+ content = f.read()
+
</file context>
Suggested change
| with open("src/web_ui/webui/components/dashboard_settings.py") as f: | |
| with open(project_root / "src/web_ui/webui/components/dashboard_settings.py") as f: |
✅ Addressed in a84e164
| model_update = update_model_dropdown(provider_value) | ||
|
|
||
| # Find and update the model component | ||
| model_comp_id = comp_id.replace("llm_provider", "llm_model_name") |
Contributor
There was a problem hiding this comment.
The model dropdown lookup uses the stale comp_id from the last loop iteration, so default settings often skip updating the model list for the selected provider.
Prompt for AI agents
Address the following comment on src/web_ui/webui/webui_manager.py at line 208:
<comment>The model dropdown lookup uses the stale `comp_id` from the last loop iteration, so default settings often skip updating the model list for the selected provider.</comment>
<file context>
@@ -128,3 +156,165 @@ def load_config(self, config_path: str):
+ model_update = update_model_dropdown(provider_value)
+
+ # Find and update the model component
+ model_comp_id = comp_id.replace("llm_provider", "llm_model_name")
+ if model_comp_id in self.id_to_component:
+ model_comp = self.id_to_component[model_comp_id]
</file context>
|
|
||
| # Apply updates without yielding (blocking update) | ||
| for comp, val in update_components.items(): | ||
| comp.value = val |
Contributor
There was a problem hiding this comment.
comp.value ends up storing the new Component object instead of the underlying value, corrupting the UI state when default settings load. Use the component's value payload instead.
Prompt for AI agents
Address the following comment on src/web_ui/webui/webui_manager.py at line 194:
<comment>`comp.value` ends up storing the new Component object instead of the underlying value, corrupting the UI state when default settings load. Use the component's value payload instead.</comment>
<file context>
@@ -128,3 +156,165 @@ def load_config(self, config_path: str):
+
+ # Apply updates without yielding (blocking update)
+ for comp, val in update_components.items():
+ comp.value = val
+
+ # Manually trigger provider change to update model dropdown
</file context>
Suggested change
| comp.value = val | |
| comp.value = val.value |
| "mcp_server_config": mcp_server_config, | ||
| } | ||
| # Duplicate registration removed - only register under dashboard_settings | ||
| # webui_manager.add_components("agent_settings", agent_settings_components) |
Contributor
There was a problem hiding this comment.
We still need to register these components under the legacy agent_settings namespace—other tabs (e.g., Deep Research) call get_setting("agent_settings", ...) and will now receive None, causing their LLM setup to fail.
Prompt for AI agents
Address the following comment on src/web_ui/webui/components/dashboard_settings.py at line 461:
<comment>We still need to register these components under the legacy `agent_settings` namespace—other tabs (e.g., Deep Research) call `get_setting("agent_settings", ...)` and will now receive `None`, causing their LLM setup to fail.</comment>
<file context>
@@ -0,0 +1,547 @@
+ "mcp_server_config": mcp_server_config,
+ }
+ # Duplicate registration removed - only register under dashboard_settings
+ # webui_manager.add_components("agent_settings", agent_settings_components)
+
+ # Register browser settings components with old-style IDs for compatibility
</file context>
| return True | ||
|
|
||
| total_tokens = sum( | ||
| len(self.tokenizer.encode(msg.content)) |
Contributor
There was a problem hiding this comment.
Token trimming assumes message.content is always a string. LangChain tool-call replies give BaseMessage.content as structured data, so this implementation will crash when tiktoken.encode sees a list/dict.
Prompt for AI agents
Address the following comment on docs/LANGGRAPH_MIGRATION_PLAN.md at line 359:
<comment>Token trimming assumes message.content is always a string. LangChain tool-call replies give BaseMessage.content as structured data, so this implementation will crash when tiktoken.encode sees a list/dict.</comment>
<file context>
@@ -0,0 +1,1086 @@
+ return True
+
+ total_tokens = sum(
+ len(self.tokenizer.encode(msg.content))
+ for msg in self.hot_memory
+ )
</file context>
| f""" | ||
| <div class="history-item" title="{task.get("task", "")}"> | ||
| {status_icon} <span style="font-size: 0.85em; opacity: 0.7;">{timestamp}</span><br/> | ||
| <span style="font-size: 0.9em;">{task_text}</span> |
Contributor
There was a problem hiding this comment.
Task descriptions from recent_tasks are rendered without escaping, so HTML or script content in a task will execute when the history list renders. Please HTML-escape these values before inserting them.
Prompt for AI agents
Address the following comment on src/web_ui/webui/components/dashboard_sidebar.py at line 177:
<comment>Task descriptions from recent_tasks are rendered without escaping, so HTML or script content in a task will execute when the history list renders. Please HTML-escape these values before inserting them.</comment>
<file context>
@@ -0,0 +1,359 @@
+ f"""
+ <div class="history-item" title="{task.get("task", "")}">
+ {status_icon} <span style="font-size: 0.85em; opacity: 0.7;">{timestamp}</span><br/>
+ <span style="font-size: 0.9em;">{task_text}</span>
+ </div>
+ """
</file context>
…e_dropdown_issue.py`) as it is no longer needed. This cleanup helps streamline the repository by eliminating obsolete files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
41 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the browser-use-web-ui project with significant enhancements including UV backend integration, enhanced MCP support, improved UI components, Windows-optimized setup, and modern Python tooling.
Summary by cubic
Modernizes the project with UV-based Python 3.14t, deeper MCP support, and a Windows-optimized setup, plus foundations for event-driven execution and observability. Adds a Deep Research agent, workflow visualization, expanded LLM support, and Docker/noVNC previews for faster onboarding and better runtime feedback.
New Features
Migration
Written for commit a84e164. Summary will update automatically on new commits.