Skip to content

fix(ui-tars): improve settings diagnostics and build filtering #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JUZI0303 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(ui-tars): improve settings diagnostics and build filtering #1945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/ui-tars/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"coverage": "vitest run --coverage",
"build:e2e": "npm run build:dist && cross-env CI=e2e npm run package",
"test:e2e": "playwright test",
"build:deps": "pnpm --filter \"!ui-tars-desktop,ui-tars-desktop...\" build && cd packages/visualizer && pnpm install --ignore-workspace",
"build:deps": "pnpm --filter \"!ui-tars-desktop\" --filter \"!ui-tars-desktop...\" build && cd packages/visualizer && pnpm install --ignore-workspace",
"build:dist": "cross-env NODE_ENV=production electron-vite build",
"build": "npm run clean && npm run typecheck && cross-env NODE_ENV=production electron-vite build && electron-forge make --enable-logging",
"make": "electron-forge make",
Expand Down
4 changes: 4 additions & 0 deletions apps/ui-tars/src/renderer/src/components/Settings/category/general.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ export const GeneralSettings = () => {
}
} catch (error) {
console.error('Failed to check for updates:', error);
toast.error('Failed to check for updates', {
description:
error instanceof Error ? error.message : 'Unknown error occurred',
});
} finally {
setUpdateLoading(false);
}
Expand Down
6 changes: 2 additions & 4 deletions apps/ui-tars/src/renderer/src/components/Settings/category/remoteComputer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,7 @@ export function RemoteComputerSettings({
form,
]);

const onSubmit = async (values: z.infer<typeof formSchema>) => {
console.log('onSubmit', values);

const onSubmit = async () => {
// updateSetting({ ...settings, ...values });
toast.success('Settings saved successfully');
};
Expand All @@ -129,7 +127,7 @@ export function RemoteComputerSettings({
return new Promise<z.infer<typeof formSchema>>((resolve, reject) => {
form.handleSubmit(
(values) => {
onSubmit(values);
onSubmit();
resolve(values);
},
(errors) => {
Expand Down
11 changes: 7 additions & 4 deletions apps/ui-tars/src/renderer/src/components/Settings/category/vlm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,6 @@ export function VLMSettings({
};

const onSubmit = async (values: z.infer<typeof formSchema>) => {
console.log('onSubmit', values);

updateSetting({ ...settings, ...values });
toast.success('Settings saved successfully');
};
Expand Down Expand Up @@ -519,7 +517,9 @@ export function ModelAvailabilityCheck({
message: successMessage,
responseApiSupported,
});
console.log('[VLM Model Check] Success:', modelConfig, {
console.log('[VLM Model Check] Success:', {
baseUrl,
modelName,
responseApiSupported,
});
} else {
Expand All @@ -529,7 +529,10 @@ export function ModelAvailabilityCheck({
message: errorMessage,
responseApiSupported,
});
console.error('[VLM Model Check] Model not responding:', modelConfig);
console.error('[VLM Model Check] Model not responding:', {
baseUrl,
modelName,
});
}
} catch (error) {
const errorMessage =
Expand Down
2 changes: 0 additions & 2 deletions apps/ui-tars/src/renderer/src/pages/settings/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,6 @@ export default function Settings() {
};

const onSubmit = async (values: z.infer<typeof formSchema>) => {
console.log('onSubmit', values);

updateSetting(values);
// toast.success('Settings saved successfully');
// await api.closeSettingsWindow();
Expand Down