Repository navigation
feat: Add more features and tests to MF2 test app - #1514
Conversation
# Conflicts: # apps/tester-federation-v2/package.json # pnpm-lock.yaml
|
@MrMuzyk is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
|
…ures-to-mf2-testing-app
…es-to-mf2-testing-app
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 1 no longer raised No open findings. Not in the reviewers' prompt (8 files)
2 findings below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
apps/tester-federation-v2/src/host/screens/RuntimeEventsScreen.tsx:12 |
🆕 runtime-events pipeline row never updates after mount, so its 30 s retry is dead |
apps/tester-federation-v2/src/host/setup.ts:19 |
Release branch of the resolver is dead code: every release chunk resolves to localhost:9999 |
5 findings below minor not shown (user_settings.min_severity).
Not in the reviewers' prompt (8 files)
apps/tester-federation-v2/src/host/assets/inlineAssets/webpack.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/localAssets/webpack.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/localAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/localAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/pic_3.jpg: no text diff (a binary, empty or mode-only change)pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (499679feaa85).
Review of 4db27ce7 · 10.11.2026 10:39 UTC
Apex Sentinel
Verdict: request_changes
Since the last review: 5 new · 2 still open · 2 no longer raised
7 finding(s): 1 major, 6 minor.
Required fixes
- Decide between: useAnimatedReaction args swapped: reported width is the previous frame, not the current / useAnimatedReaction null-check tests the non-nullable argument, so it never fires
🟠 Major (1)
| Where | Finding |
|---|---|
apps/tester-federation-v2/src/host/features/reanimated/ReanimatedBox.tsx:26 |
🆕 useAnimatedReaction args swapped: reported width is the previous frame, not the current |
🟡 Minor (6)
| Where | Finding |
|---|---|
apps/tester-federation-v2/src/host/features/miniapp/MiniAppSection.tsx:17 |
install() after Clear cache re-runs import(), which stays in the chunk cache |
apps/tester-federation-v2/src/host/features/miniapp/MiniAppSection.tsx:17 |
🆕 Mini-app install and clear-cache have no catch: a rejection becomes an unhandled rejection |
apps/tester-federation-v2/src/host/features/reanimated/ReanimatedBox.tsx:25 |
🆕 useAnimatedReaction null-check tests the non-nullable argument, so it never fires |
apps/tester-federation-v2/src/host/features/runtime/events.ts:72 |
getPipelineStatus counts a prefetched script as a settled load |
apps/tester-federation-v2/src/host/index.js:6 |
🆕 LogBox.ignoreLogs runs too late: css-interop's injection already locks it |
apps/tester-federation-v2/src/host/setup.ts:26 |
🆕 setup.ts resolver points release builds at http://localhost:9999, a port nothing serves |
5 findings below minor not shown (user_settings.min_severity).
Not in the reviewers' prompt (8 files)
apps/tester-federation-v2/src/host/assets/inlineAssets/webpack.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/localAssets/webpack.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/localAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/localAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/pic_3.jpg: no text diff (a binary, empty or mode-only change)pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (499679feaa85).
Review of b2772fee · 09.11.2026 14:48 UTC
Apex Sentinel
Verdict: approve
4 finding(s): 4 minor.
🟡 Minor (4)
| Where | Finding |
|---|---|
apps/tester-federation-v2/src/host/navigation/MainNavigator.tsx:10 |
MiniAppInstallScreen imported with a literal .tsx extension in MainNavigator |
apps/tester-federation-v2/src/host/features/miniapp/MiniAppSection.tsx:15 |
install() re-runs import() after invalidateScripts, which stays in the webpack chunk cache |
apps/tester-federation-v2/src/host/features/runtime/events.ts:67 |
getPipelineStatus counts a prefetched script as a settled load |
apps/tester-federation-v2/src/host/screens/HostAssetsScreen.tsx:128 |
HostAssetsScreen truncates the local asset URI with '…' when it is inlined, breaking the fetch assertion |
6 findings below minor not shown (user_settings.min_severity).
Not in the reviewers' prompt (8 files)
apps/tester-federation-v2/src/host/assets/inlineAssets/webpack.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/localAssets/webpack.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/localAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/localAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)apps/tester-federation-v2/src/host/assets/pic_3.jpg: no text diff (a binary, empty or mode-only change)pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (a09c6307c057).
There was a problem hiding this comment.
Apex Sentinel: 4 new findings on b2772fe. The verdict and the full list are in the summary comment.
…uzyk/repack into add-more-features-to-mf2-testing-app
There was a problem hiding this comment.
Apex Sentinel: 5 new findings on 4db27ce. The verdict and the full list are in the summary comment.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on ff52ef6. The verdict and the full list are in the summary comment.
dannyhw
left a comment
There was a problem hiding this comment.
Ran this locally at ff52ef66: 8/8 on Android (API 35 emulator) and iOS (26.4 simulator), on Rspack and on webpack. I also broke a few things on purpose (inline gate 90 → 80 KB, skipping the afterLoad hook in ScriptManager, NativeWind inlineRem 16 → 14) and each time only the matching spec went red, at its own assert. That's exactly what the design doc promises, nice work.
A few things before this goes in, none of them big:
1. The webpack command in the test plan doesn't run webpack. USE_WEBPACK=1 pnpm start:hostapp picks the webpack config, but webpack-start chooses the engine from the config filename, and config.host-app.mts doesn't start with webpack, so it falls back to Rspack. The result is the webpack config running inside Rspack: the mini app throws in webpack/lib/IgnorePlugin.js, the host hangs at 9%, and all 8 specs fail at the boot anchor. With --bundler webpack on both servers I get 8/8 on both platforms. This gap is older than this PR, but since the test plan and design doc point people at it, could you either document USE_WEBPACK=1 pnpm start:hostapp --bundler webpack (same for start:miniapp) or add start:hostapp:webpack / start:miniapp:webpack scripts?
2. CI at the head. The last green run on your fork is 66a9047e, and 6578bebb and ff52ef66 changed app code after it. I'll approve the workflow run here; once it's green, please replace the <link the e2e run here> placeholder in the description. That run is also the only evidence for the 30 s / 45 s timeout overrides: locally Home shows in under 2 s and the gallery in under 1 s.
3. Small description fix. The reason given for anchoring the extraChunks pattern ("an unanchored pattern also matches numeric chunk ids") isn't quite right: /host-async-local/ can't match a number. The real risk is another chunk name containing that string, which is what design.md already says.
The rest is inline.
|
@dannyhw Fixed and corrected everything. I did trigger one more run on fork and both android and ios passed - linked it in the PR description. |
Summary
Grows
apps/tester-federation-v2into the app that covers Re.Pack's bundling and runtime surface on a device, so checking a change means booting one app instead of several. Six new feature screens (NativeWind, Reanimated, runtime events, async chunk, remote chunk, mini-app install), a FEATURES.ts registry driving Home, typed against the navigator’s routes, and one e2e spec per feature replacingsmoke.e2e.ts— every spec owns one distinct way to fail, with one documented exception (miniapp-install overlaps remote-chunk, kept as the manual install / clear-cache demo)..svg,localAssetsalways emitted,inlineAssetsalways inlined), and the Host Assets spec asserts each one produces what it claims, including the emitted URI actually served (fetch→ 200 built from the on-screen URI, never hardcoded).NativeWindPluginandReanimatedPluginwired into both rspack and webpack configs (kept in parity), with the NativeWind toolchain and a host-scoped JSX retag in babel.extraChunksgains alocalrule for the async chunk (/^host-async-local$/— anchored so a chunk whose name only contains host-async-local doesn’t become local too).ScriptManagerhooks:resolve/loadare bail hooks, so a counting tap would replace the built-in loop instead of observing it.home-screenafterapp.open()) asserts at 30 s:app.open()returns when the window draws, and a cold JS boot on the CI emulator needs more than the 5 s default. Two more overrides, both with a named cause in design.md: 45 s on miniapp-gallery, 30 s on pipeline: settled.agent_context/e2e-oct2026/design.mddocuments layout, conventions and the traps worth knowing before editing this app.Test plan
Demo video:
mf2-upgraded-v2.mp4
CI: https://github.com/MrMuzyk/repack/actions/runs/43412470991 — Android + iOS, artifacts carry junit, screenshots and dev-server logs on failure.
Locally (boot an emulator/simulator first; Node ≥ 24.8):
The Debug build loads JS from the two dev servers, so both must stay up. Warm the platform bundle on a fresh server before the first run (curl the
index.bundleURL the workflow uses), otherwise the cold compile eats the boot anchor.Every spec owns one distinct way to fail, with one documented exception (miniapp-install overlaps remote-chunk, kept as the manual install / clear-cache demo).
Webpack config is maintained in parity but the CI lane runs rspack only;
pnpm start:hostapp:webpack+pnpm start:miniapp:webpackrun the suite against it.