Skip to content

feat: Add more features and tests to MF2 test app - #1514

Merged
dannyhw merged 34 commits into
callstack:mainfrom
MrMuzyk:add-more-features-to-mf2-testing-app
Nov 16, 2026
Merged

dannyhw merged 34 commits into
callstack:mainfrom
MrMuzyk:add-more-features-to-mf2-testing-app

fix: CR fixes v2

9c28bcf
Select commit
Loading
Failed to load commit list.
apex-sentinel-staging / Apex Sentinel succeeded Nov 13, 2026 in 9m 22s

Verdict: approve

Apex Sentinel · ✅ Approve

Since the last review: 0 new · 0 still open · 1 no longer raised

No open findings.

Not in the reviewers' prompt (8 files)
  • apps/tester-federation-v2/src/host/assets/inlineAssets/webpack.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/localAssets/webpack.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/localAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/localAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/pic_3.jpg: no text diff (a binary, empty or mode-only change)
  • pnpm-lock.yaml: generated or a lockfile, so its lines were left out

2 findings below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (499679feaa85).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.