Skip to content

Feat/sentinel e2e persona - #1531

Open
MrMuzyk wants to merge 35 commits into
callstack:mainfrom
MrMuzyk:feat/sentinel-e2e-persona
Open

MrMuzyk wants to merge 35 commits into
callstack:mainfrom
MrMuzyk:feat/sentinel-e2e-persona

Conversation

@MrMuzyk

@MrMuzyk MrMuzyk commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

@vercel

vercel Bot commented Nov 12, 2026

Copy link
Copy Markdown

@MrMuzyk is attempting to deploy a commit to the Callstack Team on Vercel.

A member of the Team first needs to authorize it.

@MrMuzyk

MrMuzyk commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Purely for test pruposes

@changeset-bot

changeset-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7aeb22c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel

Verdict: approve

1 finding(s): 1 minor.

🟡 Minor (1)

Where Finding
apps/tester-federation-v2/src/host/features/reanimated/ReanimatedBox.tsx:26 useAnimatedReaction callback reports the previous frame's width

7 findings below minor not shown (user_settings.min_severity).

Not in the reviewers' prompt (8 files)
  • apps/tester-federation-v2/src/host/assets/inlineAssets/webpack.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/localAssets/webpack.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/localAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/localAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/pic_3.jpg: no text diff (a binary, empty or mode-only change)
  • pnpm-lock.yaml: generated or a lockfile, so its lines were left out

Reviewed with this repository's own Sentinel configuration (499679feaa85).

Feedback goes in the review comment threads, as a reply under the inline comment of a finding:

Reply @apex-sentinel-staging note ... to add context, or @apex-sentinel-staging pivot ... if it is wrong — I will re-check the cited code.

Useful? Reply @apex-sentinel-staging like, or @apex-sentinel-staging dislike <why> if it is not.

Comment @apex-sentinel-staging review on this conversation to run a full review.

@apex-sentinel-staging apex-sentinel-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex Sentinel: 1 new finding on 7aeb22c. The verdict and the full list are in the summary comment.

Comment on lines +26 to +35
useAnimatedReaction(
() => width.value,
(_previous, next) => {
'worklet';
if (next !== null) {
scheduleOnRN(onWidthChange, Math.round(next));
}
}
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Minor · useAnimatedReaction callback reports the previous frame's width

useAnimatedReaction passes (current, previous), but the parameters are named _previous, next, so the code schedules next — the previous frame's width. reanimated.e2e.ts passes only because the last two frames of a settling spring round to the same integer.

Suggested change
useAnimatedReaction(
() => width.value,
(_previous, next) => {
'worklet';
if (next !== null) {
scheduleOnRN(onWidthChange, Math.round(next));
}
}
);
useAnimatedReaction(
() => width.value,
(next, _previous) => {
'worklet';
if (next !== null) {
scheduleOnRN(onWidthChange, Math.round(next));
}
}
);
Details

persona: maintainability

Useful? Reply @apex-sentinel-staging like, or @apex-sentinel-staging dislike <why> if it is not.

Reply @apex-sentinel-staging note ... to add context, or @apex-sentinel-staging pivot ... if it is wrong — I will re-check the cited code.

@artus9033 artus9033 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes on the persona's decision rules. The main ones are mixed PRs and how strict covered is: both can produce a confident wrong "already covered".

lane apps, opt-in features the lanes do not enable). Also when the PR
changes only the tester apps themselves (`apps/**`) and no Re.Pack package:
the lanes test Re.Pack, not their own apps.
2. **`covered`**: the lines this PR edits execute during an existing e2e

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when only part of the PR is covered? If a PR edits two runtime files and a lane runs only one of them, "pick the first that fits" will most likely land on covered. Then the green run looks like proof for the other file too. Suggest: covered only when every edit that runs on the device is covered; otherwise answer for the uncovered part and mention the covered files in the reason.

Judge the code this PR edits, not only the bug it says it fixes. A PR can fix
a bug that shows only on real devices and still edit code the lanes run in
every test. A PR can also fix one thing and break another. So ask: if this
edit were wrong in any way, including side effects on behaviour the PR does

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Wrong in any way" is a bar nothing passes. Meanwhile line 50 ("runs on every build and a wrong edit would stop … loading") is a bar almost everything passes in a bundler, even though a subtle wrong edit (a chunk name, a lost option) won't stop loading. Maybe "the plausible ways this edit could be wrong", and have the every-build route name what, if wrong, breaks loading?

not mention, would an existing e2e file go red?

1. **`not_useful`**: the change cannot alter what runs on the device
(docs, CI, types only, tests only, tooling, log text, examples outside the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two items in this list:

  • "tooling": Re.Pack is build tooling, so its CLI, plugins and loaders could all be read as this. Maybe "repo tooling (lint, release scripts)".
  • "opt-in features the lanes do not enable": these do change what runs on the device, just not in the lanes. Since step 1 comes first, they can never reach would_help (a lane screen could enable the option) or out_of_reach. I'd let steps 3 and 5 decide them.

the lanes test Re.Pack, not their own apps.
2. **`covered`**: the lines this PR edits execute during an existing e2e
file's run, and that file checks what they produce, so a wrong edit would
turn it red. This holds even when the bug the PR fixes shows only outside

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the bug only shows outside the lanes, a reader will still take "already covered" to mean the fix was checked. Maybe have the reason say "a regression here would show; the fix itself isn't exercised".

lane screen could make them execute: the lanes never run that setup (see
"What the lanes never reach" in `AGENTS.md`), or no emulator test could
exercise it at all. A green e2e run says nothing here. Name the reason.
4. **`not_useful`**: the change is logic that does not depend on the device,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cases with no clear answer:

  • Deletions: there are no edited lines left to execute. Ask instead whether a test checked the removed behaviour.
  • PRs that add or weaken an e2e test: is a newly added test "existing"? And "tests only → not useful" hides a PR that loosens an assertion.
  • Device-independent logic with no unit test: this falls through to would_help with an e2e sketch, when "add a unit test" is the honest answer.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants