Skip to content

Feat/sentinel e2e persona - #1531

Open
MrMuzyk wants to merge 35 commits into
callstack:mainfrom
MrMuzyk:feat/sentinel-e2e-persona
Open

MrMuzyk wants to merge 35 commits into
callstack:mainfrom
MrMuzyk:feat/sentinel-e2e-persona

Merge branch 'tester-expo-app-e2e' of github.com:MrMuzyk/repack into …

7aeb22c
Select commit
Loading
Failed to load commit list.
apex-sentinel-staging / Apex Sentinel succeeded Nov 12, 2026 in 9m 39s

1 finding(s) · approve

Apex Sentinel

Verdict: approve

1 finding(s): 1 minor.

🟡 Minor (1)

Where Finding
apps/tester-federation-v2/src/host/features/reanimated/ReanimatedBox.tsx:26 useAnimatedReaction callback reports the previous frame's width

7 findings below minor not shown (user_settings.min_severity).

Not in the reviewers' prompt (8 files)
  • apps/tester-federation-v2/src/host/assets/inlineAssets/webpack.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/inlineAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/localAssets/webpack.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/localAssets/webpack@2x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/localAssets/webpack@3x.png: no text diff (a binary, empty or mode-only change)
  • apps/tester-federation-v2/src/host/assets/pic_3.jpg: no text diff (a binary, empty or mode-only change)
  • pnpm-lock.yaml: generated or a lockfile, so its lines were left out

Reviewed with this repository's own Sentinel configuration (499679feaa85).

Feedback goes in the review comment threads, as a reply under the inline comment of a finding:

Reply @apex-sentinel-staging note ... to add context, or @apex-sentinel-staging pivot ... if it is wrong — I will re-check the cited code.

Useful? Reply @apex-sentinel-staging like, or @apex-sentinel-staging dislike <why> if it is not.

Comment @apex-sentinel-staging review on this conversation to run a full review.

Annotations

Check warning on line 35 in apps/tester-federation-v2/src/host/features/reanimated/ReanimatedBox.tsx

See this annotation in the file changed.

@apex-sentinel-staging apex-sentinel-staging / Apex Sentinel

minor: useAnimatedReaction callback reports the previous frame's width

`useAnimatedReaction` passes `(current, previous)`, but the parameters are named `_previous, next`, so the code schedules `next` — the previous frame's width. `reanimated.e2e.ts` passes only because the last two frames of a settling spring round to the same integer.