Add spans #3
Merged
Add spans #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muripic
force-pushed
the
add-grape-instrumentation
branch
from
9ef4f61 to
6543d8b
Compare
muripic
force-pushed
the
add-spans
branch
3 times, most recently
from
f4972eb to
708cc90
Compare
muripic
force-pushed
the
add-grape-instrumentation
branch
from
6543d8b to
5826715
Compare
muripic
commented
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/instrumentation.rb
Show resolved
Hide resolved
muripic
commented
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/instrumentation.rb
Show resolved
Hide resolved
muripic
commented
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/instrumentation.rb
Show resolved
Hide resolved
muripic
commented
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/instrumentation.rb
Show resolved
Hide resolved
muripic
commented
Mar 20, 2023
muripic
commented
Mar 20, 2023
muripic
commented
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/event_handler.rb
Outdated
Show resolved
Hide resolved
muripic
commented
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/event_handler.rb
Outdated
Show resolved
Hide resolved
muripic
commented
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/event_handler.rb
Show resolved
Hide resolved
added 2 commits
March 20, 2023 15:27
muripic
commented
Mar 20, 2023
dhruvCW
reviewed
Mar 20, 2023
dhruvCW
reviewed
Mar 20, 2023
dhruvCW
reviewed
Mar 20, 2023
dhruvCW
reviewed
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/event_handler.rb
Show resolved
Hide resolved
dhruvCW
reviewed
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/event_handler.rb
Show resolved
Hide resolved
dhruvCW
reviewed
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/event_handler.rb
Outdated
Show resolved
Hide resolved
dhruvCW
reviewed
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/event_handler.rb
Outdated
Show resolved
Hide resolved
dhruvCW
reviewed
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/instrumentation.rb
Outdated
Show resolved
Hide resolved
dhruvCW
reviewed
Mar 20, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/subscriber.rb
Outdated
Show resolved
Hide resolved
dhruvCW
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
some minor nitpicks (like really nitpicky) but this is beautifully written, kudos 🍻
for me the instrumentation seems to be on point, the only addition I would say is the context is missing i.e. the request parameters and the user session information. These can of course be something added with a future PR. They will also need us to implement a filtering mechanism so as not to leak PII info (especially for the session info).
b-n
suggested changes
Mar 21, 2023
instrumentation/grape/lib/opentelemetry/instrumentation/grape/subscriber.rb
Outdated
Show resolved
Hide resolved
instrumentation/grape/lib/opentelemetry/instrumentation/grape/event_handler.rb
Outdated
Show resolved
Hide resolved
instrumentation/grape/lib/opentelemetry/instrumentation/grape/subscriber.rb
Show resolved
Hide resolved
instrumentation/grape/lib/opentelemetry/instrumentation/grape/subscriber.rb
Show resolved
Hide resolved
instrumentation/grape/lib/opentelemetry/instrumentation/grape/event_handler.rb
Outdated
Show resolved
Hide resolved
b-n
reviewed
Mar 21, 2023
b-n
reviewed
Mar 21, 2023
dhruvCW
reviewed
Mar 22, 2023
b-n
reviewed
Mar 23, 2023
dhruvCW
reviewed
Mar 23, 2023
| @@ -41,11 +34,12 @@ def gem_version | |||
| end | |||
|
|
|||
| def require_dependencies | |||
| require_relative 'handler' | |||
| require_relative 'subscriber' | |||
| require_relative 'event_handler' | |||
There was a problem hiding this comment.
You could also move this into subscriber
|
I'll merge it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like to write PR descriptions but there's no reasonable description I could write to capture all the context needed here 😅
I'll still give it a shot:
Description
The goal of this PR is to implement the Grape instrumentation for OpenTelemetry. It borrows (or steals) a lot from the Datadog implementation but also differs in some substantial aspects that I tried to explain in comments throughout the PR.
This PR completes the changes made in the
add-grape-instrumentationbranch. That branch had the autogenerated files with some basic changes. This branch contains the "meat" of the implementation and the goal is to merge it intoadd-grape-instrumentationto have a complete PR we can send upstream.Last but not least, remember that this will still go through code review by the maintainers so if we can't choose among alternatives or have uncertainties, we can still raise them up to them and ask for comments or advice.