Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide Debug.Mode.None in enum and use same numbers as in shader #258

Merged
merged 2 commits into from
Jul 9, 2020
Merged

provide Debug.Mode.None in enum and use same numbers as in shader #258

merged 2 commits into from
Jul 9, 2020

Conversation

anne-gropler
Copy link
Collaborator

@anne-gropler anne-gropler commented Jul 9, 2020 •
edited
Loading

This fixes #257 by providing a None mode (0).
Not having None means that the user needs to use any number outside the enum (to reset the debug mode), which seems hacky to me.

@anne-gropler anne-gropler changed the title fix mode numbers (starting at 0) fix mode numbers in shader for DebugPass.Mode Jul 9, 2020
@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 20.213% when pulling fabab20 on fix-debugPassMode into d44f481 on master.

@anne-gropler anne-gropler requested a review from cgcostume July 9, 2020 11:40
@anne-gropler anne-gropler self-assigned this Jul 9, 2020
@anne-gropler anne-gropler added the bug Something isn't working label Jul 9, 2020
@anne-gropler anne-gropler changed the title fix mode numbers in shader for DebugPass.Mode provide Debug.Mode.None in enum and use same numbers as in shader Jul 9, 2020
@cgcostume cgcostume merged commit d115578 into master Jul 9, 2020
@cgcostume cgcostume deleted the fix-debugPassMode branch July 9, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgcostume cgcostume Awaiting requested review from cgcostume

@MartinBuessemeyer MartinBuessemeyer Awaiting requested review from MartinBuessemeyer

Assignees

@anne-gropler anne-gropler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DebugPass.Mode enum is not used correctly in blit_debug.frag
3 participants
@anne-gropler @coveralls @cgcostume