-
Notifications
You must be signed in to change notification settings - Fork 18
refactor: example projects [tra-1519] #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: example projects [tra-1519] #1163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MariadeAnton was this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxigimenez found another folder with more tests to tweak. Putting this back in draft. I think we are also not supposed to target the marketing page, right? I remember changing all the browser check templates at one point to go to https://welcome.checklyhq.com
to reduce traffic and the influence on metrics. Should I replace that in the PW config and tweak the test to target that instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that, yes. We'll change that in the @stefanjudis examples as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also empty
@maxigimenez @MariadeAnton @ferrandiaz I think I fixed all issues with the PW templates that I found, let me know if there is more 🙏 |
🎉 Experimental release successfully published on npm
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Checkly CLI automatically creates this when initiating a git repo. Let's keep it at that instead of having various versions in the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
@sorccu Do you have an idea why the test is failing? I only touched the examples which do not seem to be referenced in the E2E tests, so not sure if this is related to my changes. |
@MariadeAnton @maxigimenez I kind of opened pandoras box here. Sorry for the big PR but the examples were very neglected and all were slightly (or very) different from each other. Some weren't even working, missing crucial dependencies or using the outdated check group v1 construct which led to a big warning in the terminal. I tried to improve all these issues and ensure all tests pass. Also added additional comments to highlight difference between browser and Playwright checks.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small comments
Affected Components
Notes for the Reviewer
Summary
This PR updates all example projects to target the Danube Web Shop demo site (https://danube-web.shop) instead of Checkly's marketing site, improving the relevance and maintainability of example tests. It includes comprehensive test suite updates, project structure reorganization, configuration fixes, and documentation improvements.
Test Creation & Updates
Test Improvements:
Configuration Updates
Playwright Config:
Checkly Config:
Dependencies:
Documentation Updates
All project READMEs updated with:
Cleanup
New Dependency Submission