feat: fix specs & skip copy PW config when using examples [kit-2292] #1166
Conversation
maxigimenez
requested review from
MariadeAnton,
ferrandiaz,
miliberlin and
sorccu
|
|
||
| const playwrightConfig = getPlaywrightConfig(projectDirectory) | ||
| if (playwrightConfig) { | ||
| // Only prompt playwright copy when not using exampels |
There was a problem hiding this comment.
@maxigimenez the config is not copied at all anymore then, right?
I just encountered this issue when using the advanced-project-js and prompting to copy the config, but that should go away with this change then?
There was a problem hiding this comment.
@maxigimenez the config is not copied at all anymore then, right? I just encountered this issue when using the advanced-project-js and prompting to copy the config, but that should go away with this change then?
@miliberlin you need to install the dependencies in order to copy the config from the playwright file
There was a problem hiding this comment.
hmm, from the screenshot looks like you did installed the devs, which version of the CLI are you using?
There was a problem hiding this comment.
this will go away, with the new changes whenever using examples codes it will skip the copy playwrigth step
There was a problem hiding this comment.
@maxigimenez That was latest. I found that the jiti version is also causing issues in that project. Updated in my PR #1163
maxigimenez
deleted the
maxi/kit-2292-playwright-config-should-automatically-be-applied-to-checkly
branch
4 participants
Affected Components
Notes for the Reviewer