Skip to content

feat: fix specs & skip copy PW config when using examples [kit-2292] #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

feat: fix specs & skip copy PW config when using examples [kit-2292] #1166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/advanced-project-js/checkly.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ const config = defineConfig({
//Use `testCommand: npx playwright test` to filter the tests you want to run
}
],
],
},
cli: {
/* The default datacenter location to use when running npx checkly test */
Expand Down
0 ...roject-js/src/playwright/homepage.spec.js → ...ced-project-js/src/tests/homepage.spec.js
View file
Open in desktop
File renamed without changes.
0 ...d-project-js/src/playwright/login.spec.js → ...vanced-project-js/src/tests/login.spec.js
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions examples/advanced-project/checkly.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ const config = defineConfig({
playwrightConfig: {
timeout: 30000,
use: {
baseURL: 'https://www.danube-web.shop',
baseURL: "https://www.checklyhq.com",
viewport: { width: 1280, height: 720 },
}
},
},
browserChecks: {
/* A glob pattern matches any Playwright .spec.ts files and automagically creates a Browser Check. This way, you
Expand Down
1 change: 0 additions & 1 deletion examples/advanced-project/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export default defineConfig({
baseURL: "https://www.checklyhq.com",
viewport: { width: 1280, height: 720 },
trace: "on",

},
projects: [
{
Expand Down
7 changes: 6 additions & 1 deletion examples/boilerplate-project-js/checkly.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ const config = defineConfig({
/* A glob pattern that matches the Checks inside your repo, see https://www.checklyhq.com/docs/cli/using-check-test-match/ */
checkMatch: '**/__checks__/**/*.check.js',
/* Global configuration option for Playwright-powered checks. See https://www.checklyhq.com/docs/browser-checks/playwright-test/#global-configuration */
playwrightConfig: {},
playwrightConfig: {
use: {
baseURL: "https://www.checklyhq.com",
viewport: { width: 1280, height: 720 },
},
},
browserChecks: {
/* A glob pattern matches any Playwright .spec.js files and automagically creates a Browser Check. This way, you
* can just write native Playwright code. See https://www.checklyhq.com/docs/cli/using-check-test-match/
Expand Down
7 changes: 6 additions & 1 deletion examples/boilerplate-project/checkly.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ const config = defineConfig({
/* A glob pattern that matches the Checks inside your repo, see https://www.checklyhq.com/docs/cli/using-check-test-match/ */
checkMatch: '**/__checks__/**/*.check.ts',
/* Global configuration option for Playwright-powered checks. See https://www.checklyhq.com/docs/browser-checks/playwright-test/#global-configuration */
playwrightConfig: {},
playwrightConfig: {
use: {
baseURL: "https://www.checklyhq.com",
viewport: { width: 1280, height: 720 },
},
},
browserChecks: {
/* A glob pattern matches any Playwright .spec.ts files and automagically creates a Browser Check. This way, you
* can just write native Playwright code. See https://www.checklyhq.com/docs/cli/using-check-test-match/
Expand Down
6 changes: 4 additions & 2 deletions packages/create-cli/src/commands/bootstrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,9 @@ export default class Bootstrap extends Command {
}

const projectDirectory = await getProjectDirectory({ onCancel })
const existingProject = hasPackageJsonFile(projectDirectory)

if (hasPackageJsonFile(projectDirectory)) {
if (existingProject) {
// Init Checkly CLI for an existing project
await installWithinProject({ projectDirectory, version, onCancel })
} else {
Expand All @@ -115,7 +116,8 @@ export default class Bootstrap extends Command {
await installDependenciesAndInitGit({ projectDirectory })

const playwrightConfig = getPlaywrightConfig(projectDirectory)
if (playwrightConfig) {
// Only prompt playwright copy when not using exampels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxigimenez the config is not copied at all anymore then, right?
I just encountered this issue when using the advanced-project-js and prompting to copy the config, but that should go away with this change then?

Screenshot 2025-10-17 at 10 50 16

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxigimenez the config is not copied at all anymore then, right? I just encountered this issue when using the advanced-project-js and prompting to copy the config, but that should go away with this change then?

Screenshot 2025-10-17 at 10 50 16

@miliberlin you need to install the dependencies in order to copy the config from the playwright file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, from the screenshot looks like you did installed the devs, which version of the CLI are you using?

Copy link
Member Author

@maxigimenez maxigimenez Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will go away, with the new changes whenever using examples codes it will skip the copy playwrigth step

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxigimenez That was latest. I found that the jiti version is also causing issues in that project. Updated in my PR #1163

if (playwrightConfig && existingProject) {
await copyPlaywrightConfig({ projectDirectory, playwrightConfig })
}

Expand Down