Fix CI lint step to properly handle clj-kondo exit code 1

[Copilot]

Problem

The CI pipeline was failing when lein lint (clj-kondo) exited with code 1, even though the previous fix attempted to handle warnings by checking for exit code 2. The issue was with the command structure:

lein lint || test $? -eq 2

This approach has a critical flaw: when lein lint fails with exit code 1, the test $? -eq 2 command executes, but by then $? contains the exit code from lein lint (which is 1), so test 1 -eq 2 fails, causing the entire step to fail.

Solution

Replaced the fragile one-liner with a robust multi-step script that:

1. Captures the exit code immediately: EXIT_CODE=$? preserves the linter's actual exit code
2. Provides clear logging: Shows exactly what exit code was returned for easier debugging
3. Implements proper logic:
   • Exit codes 0 (success) and 2 (warnings only) → Build passes
   • All other exit codes (including 1 for errors) → Build fails

Changes

# Before
- name: Run linter
  run: lein lint || test $? -eq 2

# After  
- name: Lint
  run: |
    lein lint
    EXIT_CODE=$?
    echo "Linter exited with code: $EXIT_CODE"
    if [ $EXIT_CODE -eq 0 ] || [ $EXIT_CODE -eq 2 ]; then
      echo "Success or warnings only, passing build."
      exit 0
    else
      echo "Error detected (exit code $EXIT_CODE), failing build."
      exit 1
    fi

This ensures the CI pipeline behaves correctly regardless of whether clj-kondo returns warnings (code 2) or actual linting errors (code 1), while maintaining the desired behavior of allowing builds to pass when only warnings are present.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• my.datomic.com
  • Triggering command: java -Dfile.encoding=UTF-8 -Dmaven.wagon.http.ssl.easy=false -Dmaven.wagon.rto=10000 -Xbootclasspath/a:/home/REDACTED/.lein/self-installs/leiningen-2.11.2-standalone.jar -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -Dleiningen.input-checksum= -Dleiningen.original.pwd=/home/REDACTED/work/orcpub/orcpub -Dleiningen.script=/usr/local/bin/lein -classpath /home/REDACTED/.lein/self-installs/leiningen-2.11.2-standalone.jar clojure.main -m leiningen.core.main -v (dns block)
• repo.clojars.org
  • Triggering command: java -Dfile.encoding=UTF-8 -Dmaven.wagon.http.ssl.easy=false -Dmaven.wagon.rto=10000 -Xbootclasspath/a:/home/REDACTED/.lein/self-installs/leiningen-2.11.2-standalone.jar -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -Dleiningen.input-checksum= -Dleiningen.original.pwd=/home/REDACTED/work/orcpub/orcpub -Dleiningen.script=/usr/local/bin/lein -classpath /home/REDACTED/.lein/self-installs/leiningen-2.11.2-standalone.jar clojure.main -m leiningen.core.main -v (dns block)
• repository.apache.org
  • Triggering command: java -Dfile.encoding=UTF-8 -Dmaven.wagon.http.ssl.easy=false -Dmaven.wagon.rto=10000 -Xbootclasspath/a:/home/REDACTED/.lein/self-installs/leiningen-2.11.2-standalone.jar -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -Dleiningen.input-checksum= -Dleiningen.original.pwd=/home/REDACTED/work/orcpub/orcpub -Dleiningen.script=/usr/local/bin/lein -classpath /home/REDACTED/.lein/self-installs/leiningen-2.11.2-standalone.jar clojure.main -m leiningen.core.main -v (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

This pull request was created as a result of the following prompt from Copilot chat.

The current CI process is failing because the lein lint command is exiting with code 1, even when only warnings are present. The previous fix (... || test $? -eq 2) was insufficient because it doesn't handle exit code 1.

Modify the .github/workflows/continuous-integration.yml file to implement a more robust script for the 'Lint' step.

The new script should:

1. Run lein lint.
2. Capture the exit code.
3. If the exit code is 0 (success) or 2 (warnings), the step should succeed (exit 0).
4. If the exit code is anything else (e.g., 1 for an error, 3 for linting errors), the step should fail (exit 1).

This is the code that should be used:

      - name: Lint
        run: |
          lein lint
          EXIT_CODE=$?
          echo "Linter exited with code: $EXIT_CODE"
          if [ $EXIT_CODE -eq 0 ] || [ $EXIT_CODE -eq 2 ]; then
            echo "Success or warnings only, passing build."
            exit 0
          else
            echo "Error detected (exit code $EXIT_CODE), failing build."
            exit 1
          fi

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.