Skip to content

Fix CI lint step to properly handle clj-kondo exit code 1 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: fix-ignore-CI-linting-warnings
Choose a base branch
from
Draft

Fix CI lint step to properly handle clj-kondo exit code 1 #5

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
39751a7
Initial plan
Copilot Sep 11, 2025
6418103
Fix CI lint step to handle exit code 1 properly
Copilot Sep 11, 2025
b73071b
Update lint command to include LEIN_SNAPSHOTS_IN_RELEASE
codeGlaze Sep 11, 2025
a9691c4
Update CI workflow to use clj-kondo for linting
codeGlaze Sep 11, 2025
6d7660a
Replace clj-kondo with lein lint in CI
codeGlaze Sep 11, 2025
55fa228
Enhance linting process with clj-kondo
codeGlaze Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,26 @@ jobs:
boot: 2.8.3 # or use 'latest' to always provision latest version of boot
- name: Get leiningen version
run: lein -v
- name: Run linter
run: lein lint || test $? -eq 2
- name: Lint
run: |
# Force lein to download the clj-kondo dependency
lein with-profile lint deps :tree

# Find the exact path to the clj-kondo uberjar
CLJ_KONDO_PATH=$(find ~/.m2/repository/clj-kondo -name "*standalone.jar")
echo "Found clj-kondo at: $CLJ_KONDO_PATH"

# Run clj-kondo directly using the uberjar
java -jar $CLJ_KONDO_PATH --lint src
EXIT_CODE=$?
echo "Linter exited with code: $EXIT_CODE"

if [ $EXIT_CODE -eq 0 ] || [ $EXIT_CODE -eq 2 ]; then
echo "Success or warnings only, passing build."
exit 0
else
echo "Error detected (exit code $EXIT_CODE), failing build."
exit 1
fi
- name: Run tests
run: lein test
Loading