Skip to content

Conversation

@chiroptical
Copy link
Collaborator

Summary

In Slack, https://cfb-public.slack.com/archives/C06A1S35Y56/p1762995502273639?thread_ts=1762910709.216609&cid=C06A1S35Y56, we agreed to set up some ruff CI checks. That would mean we also fix ruff checks in the current code.

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.
  • If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Screenshots

Add some screenshots highlighting your changes.

Known issues

If you've run against limitations or caveats, include them here. Include follow-up issues as well.

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Go to the home page
  2. Click on a testimony
  3. See that it's loaded with a loading spinner

@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
maple-dev Ready Ready Preview Comment Nov 19, 2025 1:28am

Comment on lines +16 to +17
- run: ruff check llm/
- run: ruff format --check llm/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we like to do this on the analysis/ directory too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our Zoom discussion, lets scope it to llm/ since that's where we expect all of our python analysis scripts to live for now and we do not want to apply ruff to ipynb's that live elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants