Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create & delete sync sessions over gRPC #119

Merged
merged 6 commits into from
Mar 28, 2025
Merged

chore: create & delete sync sessions over gRPC #119

merged 6 commits into from
Mar 28, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Mar 24, 2025 •
edited
Loading

Closes #63.

This was referenced Mar 24, 2025
Merged
Merged
Merged
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Mar 24, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson mentioned this pull request Mar 24, 2025
Merged
@ethanndickson ethanndickson self-assigned this Mar 24, 2025
@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from c11bc07 to 1cac28d Compare March 24, 2025 07:09
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from 84e4daa to 4581c1e Compare March 24, 2025 07:09
@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from 1cac28d to 015cd0c Compare March 24, 2025 09:47
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from 4581c1e to 7ca5e28 Compare March 24, 2025 09:48
@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from 015cd0c to 6a40c66 Compare March 24, 2025 09:50
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from 7ca5e28 to 2b848e9 Compare March 24, 2025 09:51
@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from 6a40c66 to 257499f Compare March 24, 2025 09:51
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from 2b848e9 to 94f7e77 Compare March 24, 2025 09:51
@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from 257499f to 12fa59f Compare March 24, 2025 10:51
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from 94f7e77 to e6b0bc3 Compare March 24, 2025 10:51
@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from 12fa59f to af6ba71 Compare March 24, 2025 12:32
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from e6b0bc3 to 080528a Compare March 24, 2025 12:32
@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from af6ba71 to ae06ba2 Compare March 24, 2025 13:12
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch 2 times, most recently from c215f63 to a27014a Compare March 24, 2025 13:19
@ethanndickson ethanndickson marked this pull request as ready for review March 24, 2025 13:19
ethanndickson
ethanndickson commented Mar 24, 2025
View reviewed changes
Coder-Desktop/VPNLib/FileSync/FileSyncDaemon.swift
@@ -162,7 +168,7 @@ public class MutagenDaemon: FileSyncDaemon {
// Already connected
return
}
group = MultiThreadedEventLoopGroup(numberOfThreads: 1)
group = MultiThreadedEventLoopGroup(numberOfThreads: 2)
Copy link
Member Author

@ethanndickson ethanndickson Mar 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always have two outgoing gRPC requests at once, the prompter, and the actual request we're trying to make. This creates a second OS thread for gRPC to use.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh 2 os threads might be overkill

@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from ae06ba2 to 68dae7d Compare March 25, 2025 01:52
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from a27014a to 126e84f Compare March 25, 2025 01:52
@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from 68dae7d to c7018ec Compare March 25, 2025 02:10
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from 126e84f to ba8bd98 Compare March 25, 2025 02:10
@ethanndickson ethanndickson linked an issue Mar 25, 2025 that may be closed by this pull request
Add basic file sync support using GUI with manually entered paths #63
Closed
@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from c7018ec to 820bace Compare March 26, 2025 05:55
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from bc0d1e3 to 660e1df Compare March 26, 2025 05:55
@ethanndickson ethanndickson mentioned this pull request Mar 26, 2025
Merged
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from 032237c to eb29807 Compare March 27, 2025 03:06
@ethanndickson ethanndickson mentioned this pull request Mar 27, 2025
Merged
@ethanndickson ethanndickson force-pushed the ethan/mutagen-prompting branch from 820bace to 93667f7 Compare March 27, 2025 07:43
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from eb29807 to 58c4ff5 Compare March 27, 2025 07:43
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Mar 28, 2025 •
edited
Loading

Merge activity

  • Mar 27, 10:47 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 27, 10:54 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 27, 10:56 PM EDT: A user merged this pull request with Graphite.

@ethanndickson ethanndickson changed the base branch from ethan/mutagen-prompting to graphite-base/119 March 28, 2025 02:51
@ethanndickson ethanndickson changed the base branch from graphite-base/119 to main March 28, 2025 02:53
@ethanndickson ethanndickson force-pushed the ethan/create-delete-grpc branch from 58c4ff5 to 58f9775 Compare March 28, 2025 02:54
@ethanndickson ethanndickson merged commit 6463de0 into main Mar 28, 2025
3 of 4 checks passed
@ethanndickson ethanndickson deleted the ethan/create-delete-grpc branch March 28, 2025 02:56
@ethanndickson ethanndickson mentioned this pull request Mar 28, 2025
Merged
@sreya sreya mentioned this pull request Apr 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

@ThomasK33 ThomasK33 Awaiting requested review from ThomasK33

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add basic file sync support using GUI with manually entered paths
2 participants
@ethanndickson @deansheather