feat: add stubbed file sync UI #116
Merged
+415
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
force-pushed
the
ethan/stubbed-fs-ui
branch
from
43498ed to
e25df16
Compare
|
How come is there a dot on the menu to open the file sync list? |
|
|
Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift
Outdated
Show resolved
Hide resolved
Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift
Outdated
Show resolved
Hide resolved
Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift
Outdated
Show resolved
Hide resolved
Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift
Outdated
Show resolved
Hide resolved
|
Oh... it's kinda weird to have a green dot as if it's a workspace. I'll ping Rachel about the design I guess |
ethanndickson
force-pushed
the
ethan/stubbed-fs-ui
branch
from
64c54d6 to
0451742
Compare
ethanndickson
force-pushed
the
ethan/stubbed-fs-ui
branch
2 times, most recently
from
5fca50f to
fceb8a5
Compare
ethanndickson
changed the base branch from
ethan/conditionally-start-daemon
to
graphite-base/116
ethanndickson
force-pushed
the
ethan/stubbed-fs-ui
branch
from
fceb8a5 to
380047c
Compare
ethanndickson
force-pushed
the
graphite-base/116
branch
from
66a1c04 to
4fb7970
Compare
ethanndickson
force-pushed
the
ethan/stubbed-fs-ui
branch
4 times, most recently
from
227d056 to
93a8e1c
Compare
ethanndickson
commented
Mar 24, 2025
| @@ -48,10 +48,8 @@ struct LoginForm: View { | |||
| loginError = nil | |||
| } | |||
| } | |||
| )) { | |||
| Button("OK", role: .cancel) {}.keyboardShortcut(.defaultAction) | |||
There was a problem hiding this comment.
I discovered this was unnecessary and removed it everywhere. An OK button always appears on alerts, and it always gets selected by pressing enter.
ethanndickson
force-pushed
the
ethan/stubbed-fs-ui
branch
2 times, most recently
from
9f92961 to
82cc4ba
Compare
deansheather
approved these changes
Mar 25, 2025
Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift
Outdated
Show resolved
Hide resolved
Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncSessionModal.swift
Outdated
Show resolved
Hide resolved
ethanndickson
force-pushed
the
ethan/stubbed-fs-ui
branch
from
82cc4ba to
0fcce8a
Compare
This was referenced Mar 26, 2025
ethanndickson
force-pushed
the
ethan/stubbed-fs-ui
branch
from
0fcce8a to
da2fb7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
Relates to #63
The UI differs a fair bit from the wireframes & figma designs in the interest of being able to use the stock SwiftUI Table view. The biggest difference is that a modal is used to insert new file syncs, as opposed to creating them inline. This was done as it's a lot harder to do that within a SwiftUI table. This design is also consistent with tables used in Apple's own settings pages, and the HTTP header table in app settings.
Screen.Recording.2025-03-20.at.1.55.34.pm.mov
The UI is mostly non-functional, it still needs to be wired up over gRPC, including conversions from Mutagen data types.
As a result, the file sync button on the menu will not appear unless the file sync feature flag is enabled in settings.
Right now, the workspace dropdown menu is populated from the online agents (any row with a coloured dot on the menubar menu)
There's no tests for this since ViewInspector still does not support Tables.