feat: add file sync daemon error handling to the UI #122
Conversation
ethanndickson
force-pushed
the
ethan/fsd-error-handling
branch
2 times, most recently
from
f7f2242 to
9025d6d
Compare
ethanndickson
force-pushed
the
ethan/create-delete-grpc
branch
from
032237c to
eb29807
Compare
ethanndickson
force-pushed
the
ethan/fsd-error-handling
branch
from
9025d6d to
be70ade
Compare
ethanndickson
force-pushed
the
ethan/create-delete-grpc
branch
from
eb29807 to
58c4ff5
Compare
ethanndickson
force-pushed
the
ethan/fsd-error-handling
branch
from
be70ade to
8d3ca31
Compare
Coder-Desktop/Coder-Desktop/Preview Content/PreviewFileSync.swift
Outdated
Show resolved
Hide resolved
| @@ -2,6 +2,8 @@ import VPNLib | |||
|
|
|||
| @MainActor | |||
| final class PreviewFileSync: FileSyncDaemon { | |||
| var logFile: URL = .init(filePath: "~/log.txt")! | |||
There was a problem hiding this comment.
On Windows we are putting this in $MUTAGEN_DATA_DIR/daemon.log. It shouldn't go in the home directory
There was a problem hiding this comment.
Just a note that when it's a .log file there most likely isn't an associated program for .log, so you could either leave it as .txt e.g. daemon-log.txt or just open the directory (which is what I'll do on Windows)
There was a problem hiding this comment.
That's a class for mocking previews, but in the real class it's going in $MUTAGEN_DATA_DIR/daemon.log
There was a problem hiding this comment.
Oh, you're right mb. As long as we're not creating a file in ~/ when using the preview version then it's fine.
There was a problem hiding this comment.
By default on macOS .log files are opened in Console.app
ethanndickson
changed the base branch from
ethan/create-delete-grpc
to
graphite-base/122
ethanndickson
force-pushed
the
ethan/fsd-error-handling
branch
from
28e2003 to
595c010
Compare
ethanndickson
force-pushed
the
graphite-base/122
branch
from
58c4ff5 to
6463de0
Compare
ethanndickson
force-pushed
the
ethan/fsd-error-handling
branch
from
595c010 to
4537dbc
Compare
If file sync is working, but a session has errored, an icon will be displayed on the main menu.
e.g. for:
This icon & tooltip are displayed:
If file sync is not working altogether, due to the daemon crashing, the same icon will be displayed with a different tooltip on hover:
Once the config menu is opened, an alert is displayed, and the daemon log file is opened.
From there, the Daemon can be restarted, or the alert can be dismissed without restarting. The latter provides users an out if the daemon were to crash on launch repeatedly.