fix: concurrently open tunnel & handshake #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
commented
Jan 23, 2025
| @@ -12,5 +12,7 @@ | |||
| <array> | |||
| <string>$(TeamIdentifierPrefix)com.coder.Coder-Desktop</string> | |||
| </array> | |||
| <key>com.apple.security.network.client</key> | |||
There was a problem hiding this comment.
Entitlement required for the network extension to be able to reach the internet, i.e. download the dylib,.
Comment on lines
+69
to
+71
| Task { | ||
| await loadNetworkExtension() | ||
| } |
There was a problem hiding this comment.
This avoids prompting the user to configure the system VPN each time they launch the app.
coadler
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go dylib
OpenTunnelfunction blocks until the handshake is performed over the file descriptors, so we'll run that function on a different thread, and then await that it returns.A few other cleanups throughout to get Manager's
initto run to completion: downloading and validating the dylib and starting the tunnel.