Skip to content

Conversation

@TheSecurityDev
Copy link
Contributor

@TheSecurityDev TheSecurityDev commented Oct 14, 2025

Implements the onroad screenshots for raylib that were in the old UI test previews.

Doesn't include the alerts, but that will be easy to add next (#36353)

@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 05:36
@github-actions github-actions bot added the ui label Oct 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements onroad camera screenshots for the raylib UI test framework, expanding the existing offroad test coverage to include driving scenarios. This allows testing of the UI while openpilot is actively running with camera feeds.

  • Adds onroad test scenarios including engaged, disengaged, override, and wide camera modes
  • Implements camera frame loading and caching system for test data
  • Integrates VisionIpcServer to simulate real camera feeds during testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

raylib UI Preview

driver_camera : $${\color{cyan}\text{NEW}}$$
homescreen : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_paired : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_prime : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_update_available : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
offroad_alert : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad : $${\color{cyan}\text{NEW}}$$
onroad_disengaged : $${\color{cyan}\text{NEW}}$$
onroad_override : $${\color{cyan}\text{NEW}}$$
onroad_sidebar : $${\color{cyan}\text{NEW}}$$
onroad_wide : $${\color{cyan}\text{NEW}}$$
onroad_wide_sidebar : $${\color{cyan}\text{NEW}}$$
settings_firehose : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

@TheSecurityDev
Copy link
Contributor Author

TheSecurityDev commented Oct 14, 2025

It looks like the changes to the UI (signal strength and firehose active -> inactive) were like this in the old screenshots.

To fix the Firehose page, we can set deviceState.networkMetered = False, if that's what we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant