Skip to content

Conversation

TheSecurityDev
Copy link
Contributor

Includes #36340, but also adds the alert screenshots.

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 00:16
@github-actions github-actions bot added the ui label Oct 15, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds automated onroad UI screenshot generation by feeding the UI with real route data and VisionIPC frames, and introduces cases for onroad alerts and states.

  • Initialize VisionIPC and publish migrated log events to drive the UI for onroad screenshots
  • Add helpers for onroad alert scenarios (small/mid/full, disengaged, override, wide, sidebar, driver cam)
  • Cache and reuse a set of camera frames for faster test execution

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


# Ensure cache directory exists
os.makedirs(DEFAULT_CACHE_DIR, exist_ok=True)
frames_cache = f"{DEFAULT_CACHE_DIR}/test_ui_frames"
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache filename is not specific to the route/segment; running tests with different routes or segments risks stale or mismatched frames. Include route name and segment (and optionally camera profile) in the cache key, e.g., DEFAULT_CACHE_DIR/test_ui_frames_{route.fullname}_{segnum}.npz.

Suggested change
frames_cache = f"{DEFAULT_CACHE_DIR}/test_ui_frames"
# Make cache filename specific to route and segment
safe_route_name = route.fullname.replace("/", "_")
frames_cache = f"{DEFAULT_CACHE_DIR}/test_ui_frames_{safe_route_name}_{segnum}.pkl"

Copilot uses AI. Check for mistakes.

Copy link
Contributor

github-actions bot commented Oct 15, 2025

raylib UI Preview

driver_camera : $${\color{cyan}\text{NEW}}$$
homescreen : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_paired : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_prime : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_update_available : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
offroad_alert : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad : $${\color{cyan}\text{NEW}}$$
onroad_alert_full_critical : $${\color{cyan}\text{NEW}}$$
onroad_alert_mid_warning : $${\color{cyan}\text{NEW}}$$
onroad_alert_small_normal : $${\color{cyan}\text{NEW}}$$
onroad_disengaged : $${\color{cyan}\text{NEW}}$$
onroad_override : $${\color{cyan}\text{NEW}}$$
onroad_sidebar : $${\color{cyan}\text{NEW}}$$
onroad_wide : $${\color{cyan}\text{NEW}}$$
onroad_wide_sidebar : $${\color{cyan}\text{NEW}}$$
settings_firehose : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant