-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add screenshots for more keyboard layouts #36342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add screenshots for more keyboard layouts #36342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds screenshot test coverage for additional keyboard states including uppercase, numbers, and symbols modes with typed text examples.
- Adds helper functions to interact with different keyboard modes (shift, numbers toggle)
- Creates setup functions for three new keyboard test scenarios with different states
- Registers the new keyboard test scenarios in the setup function mapping
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This would actually be quite useful for the keyboard bug fixes |
Screenshots for uppercase, number, and symbol layouts. There should also be one with text, which I had but reverted for simplicity.
We could also add one for password mode, but it might not be as important.