fix(pg-cache): allow cache to reopen after close for process survival#787
Open
pyramation wants to merge 1 commit intomainfrom
Open
fix(pg-cache): allow cache to reopen after close for process survival#787pyramation wants to merge 1 commit intomainfrom
pyramation wants to merge 1 commit intomainfrom
Conversation
The PgPoolCacheManager.close() permanently set closed=true with no way to reopen. If the process received SIGTERM but didn't exit (e.g. during provisioning or restart under load), all subsequent getPgPool() calls threw 'Cannot add to cache after it has been closed'. Changes: - Reset closed=false after disposal completes in PgPoolCacheManager.close() - Reset closePromise in module-level close() via finally block (matching the pattern already used in graphile-cache.ts) This allows the cache to accept new entries if the process survives the shutdown signal.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(pg-cache): allow cache to reopen after close for process survival
Summary
Fixes a server crash:
Error: Cannot add to cache after it has been closed (key: postgres).PgPoolCacheManager.close()permanently setclosed = truewith no reset path. When SIGTERM fires but the process doesn't exit (e.g., during provisioning or restart under load), all subsequentgetPgPool()calls throw becauseset()is guarded by theclosedflag. The module-levelclosePromisewas also never reset, preventing futureclose()cycles from running.Changes (2 lines of logic in
postgres/pg-cache/src/lru.ts):this.closed = falseafterwaitForDisposals()completes inPgPoolCacheManager.close(), so the cache can accept new entries post-shutdownclose()body intry/finallyto resetclosePromise.promise = null, matching the existing pattern ingraphile-cache.tsReview & Testing Checklist for Human
set()call arriving during an activeclose()(betweenthis.closed = trueandthis.closed = false) still correctly throws, and only succeeds after disposal completesclosePromisereset +closed = falseshould allow this)Notes
try/finallywrappergraphile-cachepackage already uses thisfinallyreset pattern (line 283 ofgraphile-cache.ts); this PR alignspg-cachewith that conventionRequested by: @pyramation
Link to Devin Session