Skip to content

fix(pg-cache): allow cache to reopen after close for process survival #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pyramation wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pg-cache): allow cache to reopen after close for process survival #787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions postgres/pg-cache/src/lru.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ export class PgPoolCacheManager {
this.closed = true;
this.clear();
await this.waitForDisposals();
// Re-open the cache so it can accept new entries if the process
// survives the shutdown signal (e.g. during provisioning or restart).
this.closed = false;
}

async waitForDisposals(): Promise<void> {
Expand Down Expand Up @@ -141,9 +144,14 @@ export const close = async (verbose = false): Promise<void> => {
if (closePromise.promise) return closePromise.promise;

closePromise.promise = (async () => {
if (verbose) log.info('Closing pg cache...');
await pgCache.close();
if (verbose) log.success('PG cache disposed.');
try {
if (verbose) log.info('Closing pg cache...');
await pgCache.close();
if (verbose) log.success('PG cache disposed.');
} finally {
// Reset so close() can be called again if the process survives.
closePromise.promise = null;
}
})();

return closePromise.promise;
Expand All @@ -158,4 +166,4 @@ SYS_EVENTS.forEach(event => {

export const teardownPgPools = async (verbose = false): Promise<void> => {
return close(verbose);
};
};