-
Notifications
You must be signed in to change notification settings - Fork 184
chore(deps): update dependency fedora to v43 #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh03 <206760901+red-hat-konflux-kflux-prd-rh03[bot]@users.noreply.github.com>
|
@aaradhak - there are some manual steps required here. Let me know if you need help. |
|
I think @marmijo is looking into this cosa bump part. |
I think #4366 should unblock this PR. |
|
I think the prow jobs need some updates too so we'll probably have to ignore/override those tests to merge this. Not sure if we have that documented anywhere. |
build.sh
Outdated
| # code on the system first: | ||
| rmdir /usr/lib/osbuild/osbuild | ||
| mv /usr/lib/python3.13/site-packages/osbuild /usr/lib/osbuild/ | ||
| mv /usr/lib/python3.14/site-packages/osbuild /usr/lib/osbuild/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might be able to not have this problem in the future if we do some dynamic detection here:
python_lib_dir=$(ls -d /usr/lib/python*)
and then use that var in the below code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note.. if we merged this change first then the prow jobs mentioned in #4348 (comment) would probably succeed.
However it was good that they failed so we'd know to go update them. Would you mind adding a step to that to the rebase checklist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing! I'll update the checklist and I'll update this PR to dynamically detect the python dir.
dustymabe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Fedora 43 now includes Python 3.14, which broke patch_upload since the python3.13 directory was hard-coded. Dynamically detect the python lib directory to avoid this in the future. https://fedoraproject.org/wiki/Changes/Python3.14
3986428 to
5784f71
Compare
dustymabe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
looks like newer versions of linting libraries in F43 are stricter and there's a little cleanup for us to do. |
This PR contains the following updates:
42->43Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.