Add parquet convert failure, block delay and total block to convert metrics #6821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
component/compactor
type/observability
SungJin1212
reviewed
Jun 17, 2025
metrics Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 <[email protected]>
yeya24
force-pushed
the
converter-metrics
branch
from
3bbdf9b to
cfd5a08
Compare
|
LGTM! |
SungJin1212
approved these changes
Jun 17, 2025
Signed-off-by: yeya24 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR tries to add more Parquet metrics.
Cleaner:
cortex_bucket_parquet_unconverted_blocks_countmetric for total number of TSDB blocks that should be converted to Parquet but not available yet. This can be useful to see the backlog.Converter:
cortex_parquet_converter_convert_block_delay_minuteshistogram metric. This is to track the delay from the time when TSDB block is uploaded to the time the block is converted to Parquet format.cortex_parquet_converter_block_convert_failures_totalmetric for number of failed block conversions. This tracks all conversion failures except context cancellation error.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]