[5.x] Fixed saving product and variant UI label formats#4329
Merged
nfourtythree merged 1 commit intoJun 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Craft Commerce 5.x product type settings so the Product UI Label Format and Variant UI Label Format values entered in the CP are persisted (addresses #4324).
Changes:
- Marks
productUiLabelFormatandvariantUiLabelFormatas safe attributes onProductTypeso they can be populated via mass assignment. - Maps
productUiLabelFormatandvariantUiLabelFormatrequest params onto theProductTypemodel inProductTypesController::actionSaveProductType(). - Adds a changelog entry for the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/models/ProductType.php | Allows UI label format fields to be assigned when constructing the model from arrays/config. |
| src/controllers/ProductTypesController.php | Ensures the two UI label format fields are read from the POST body and saved. |
| CHANGELOG.md | Documents the fix in Unreleased notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Unreleased | ||
|
|
||
| - Fixed a bug where a Twig error would occur when creating or editing a shipping rule. ([#4321](https://github.com/craftcms/commerce/issues/4321)) | ||
| - Fixed a bug where settings weren’t being saved to the project config. ([#4324](https://github.com/craftcms/commerce/issues/4324)) |
nfourtythree
deleted the
nathaniel/com-585-5x-product-type-ui-label-format-fields-are-not-persisted-on
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
#4324