Skip to content

[5.x] Fixed saving product and variant UI label formats #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfourtythree merged 1 commit into from
Jun 29, 2026
+4 −1
Merged

[5.x] Fixed saving product and variant UI label formats #4329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- Fixed a bug where a Twig error would occur when creating or editing a shipping rule. ([#4321](https://github.com/craftcms/commerce/issues/4321))
- Fixed a bug where settings weren’t being saved to the project config. ([#4324](https://github.com/craftcms/commerce/issues/4324))

## 5.6.6.1 - 2026-06-18

Expand Down
2 changes: 2 additions & 0 deletions src/controllers/ProductTypesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ public function actionSaveProductType(): ?Response
$productType->hasDimensions = (bool)$this->request->getBodyParam('hasDimensions');
$productType->hasProductTitleField = (bool)$this->request->getBodyParam('hasProductTitleField');
$productType->productTitleFormat = $this->request->getBodyParam('productTitleFormat');
$productType->productUiLabelFormat = $this->request->getBodyParam('productUiLabelFormat');
$productType->productTitleTranslationMethod = $this->request->getBodyParam('productTitleTranslationMethod', $productType->productTitleTranslationMethod);
$productType->productTitleTranslationKeyFormat = $this->request->getBodyParam('productTitleTranslationKeyFormat', $productType->productTitleTranslationKeyFormat);
$productType->showSlugField = (bool)$this->request->getBodyParam('showSlugField', $productType->showSlugField);
Expand All @@ -152,6 +153,7 @@ public function actionSaveProductType(): ?Response
$productType->maxVariants = $this->request->getBodyParam('maxVariants') ?: null;
$productType->hasVariantTitleField = $this->request->getBodyParam('hasVariantTitleField', false);
$productType->variantTitleFormat = $this->request->getBodyParam('variantTitleFormat');
$productType->variantUiLabelFormat = $this->request->getBodyParam('variantUiLabelFormat');
$productType->variantTitleTranslationMethod = $this->request->getBodyParam('variantTitleTranslationMethod', $productType->variantTitleTranslationMethod);
$productType->variantTitleTranslationKeyFormat = $this->request->getBodyParam('variantTitleTranslationKeyFormat', $productType->variantTitleTranslationKeyFormat);
$productType->skuFormat = $this->request->getBodyParam('skuFormat');
Expand Down
2 changes: 1 addition & 1 deletion src/models/ProductType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ protected function defineRules(): array
['fieldLayout', 'validateFieldLayout'],
['variantFieldLayout', 'validateVariantFieldLayout'],
['siteSettings', 'required', 'message' => Craft::t('commerce','At least one site must be enabled for the product type.')],
[['isStructure', 'defaultPlacement', 'maxLevels', 'structureId'], 'safe'],
[['isStructure', 'defaultPlacement', 'maxLevels', 'structureId', 'productUiLabelFormat', 'variantUiLabelFormat'], 'safe'],
[['previewTargets'], 'validatePreviewTargets'],
];
}
Expand Down
Loading