Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Move dimensions-only projections to dimensions for push-to-Cube wrapper #9318

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

mcheshkov
Copy link
Member

@mcheshkov mcheshkov commented Mar 7, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Turns dimension-only member expressions in projection to dimensions, not measures
This helps with queries like SELECT dim1, ... dimN, mea1, ... meaM FROM cube, whether explicit or implicit (SQL API generate every member in SELECT for zero-member CubeScan in wrapper)

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 91.33858% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.76%. Comparing base (0ad6252) to head (7090a0d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 90.90% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9318   +/-   ##
=======================================
  Coverage   83.75%   83.76%           
=======================================
  Files         229      229           
  Lines       82613    82696   +83     
=======================================
+ Hits        69191    69267   +76     
- Misses      13422    13429    +7     
Flag Coverage Δ
cubesql 83.76% <91.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov force-pushed the sql-pushdown-ungrouped-dimensions branch from d8ebcb5 to d2c5c1e Compare March 8, 2025 16:37
@mcheshkov mcheshkov changed the title [WIP] feat(cubesql): Move dimensions-only projections to dimensions for push-to-Cube wrapper feat(cubesql): Move dimensions-only projections to dimensions for push-to-Cube wrapper Mar 8, 2025
@mcheshkov mcheshkov marked this pull request as ready for review March 10, 2025 11:10
@mcheshkov mcheshkov requested a review from a team as a code owner March 10, 2025 11:10
@mcheshkov mcheshkov force-pushed the sql-pushdown-ungrouped-dimensions branch from d2c5c1e to 7090a0d Compare March 10, 2025 15:08
@mcheshkov mcheshkov merged commit ca62aa0 into master Mar 10, 2025
83 checks passed
@mcheshkov mcheshkov deleted the sql-pushdown-ungrouped-dimensions branch March 10, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants