Skip to content

Conversation

@be-smith
Copy link
Contributor

Made edits to #1409 to pass tests and updated the plotting label to be the same as the previous mode

@be-smith be-smith force-pushed the bes/ben_edits_to_isabel branch from 00266e2 to d80de3d Compare November 10, 2025 22:43
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.17%. Comparing base (def36a7) to head (a8a8ce3).

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/apps/ftir/__init__.py 88.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
+ Coverage   80.14%   80.17%   +0.03%     
==========================================
  Files          70       70              
  Lines        4799     4827      +28     
==========================================
+ Hits         3846     3870      +24     
- Misses        953      957       +4     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/apps/ftir/__init__.py 92.10% <88.23%> (-3.73%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Nov 10, 2025

datalab    Run #4057

Run Properties:  status check passed Passed #4057  •  git commit a6ae397f3a ℹ️: Merge a8a8ce3492c0cd81354d33130f274bc1093774d1 into def36a7750f14f86c215cbae14e8...
Project datalab
Branch Review bes/ben_edits_to_isabel
Run status status check passed Passed #4057
Run duration 07m 08s
Commit git commit a6ae397f3a ℹ️: Merge a8a8ce3492c0cd81354d33130f274bc1093774d1 into def36a7750f14f86c215cbae14e8...
Committer Ben Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

424.339520 89.977578
426.268336 90.125637
428.197152 90.237869
430.125968 90.521532
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets this off at 450 1/cm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be deleted, should also check how it was even added

@ml-evs ml-evs added this to the v0.6.x milestone Nov 11, 2025
@be-smith be-smith linked an issue Nov 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable processing more FTIR file formats

4 participants