Skip to content

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Jul 28, 2025

Proposed changes

Migrated node package manager from npm to pnpm.

Resolves #3372 and #4311

  • install pnpm in copilot setup
  • research for previously included restriction regarding an initial weight of an upload artifact (probably we need to increase some version number)

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Jul 28, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Jul 28, 2025
@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Jul 28, 2025
Copy link
Contributor

@mfranzke mfranzke requested a review from Copilot August 5, 2025 21:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project's package manager from npm to pnpm across the entire monorepo. This is a comprehensive refactoring that updates all package.json scripts, workflow files, documentation, and configuration files to use pnpm commands instead of npm.

Key changes include:

  • Replaced npm workspace commands with pnpm filter syntax
  • Updated npm-run-all usage with pnpm's built-in parallel execution and regex patterns
  • Modified CI/CD workflows and GitHub Actions to use pnpm
  • Added pnpm workspace configuration and package manager specification

Reviewed Changes

Copilot reviewed 70 out of 72 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-workspace.yaml New pnpm workspace configuration file defining package locations
package.json Updated package manager field and removed npm workspaces config, added pnpm overrides
scripts/package.json Converted all npm workspace commands to pnpm filter syntax
showcases/*/package.json Updated npm-run-all patterns to pnpm regex patterns and npx to pnpm exec
.github/workflows/*.yml Updated all CI/CD workflows to use pnpm commands instead of npm
packages/*/package.json Converted build scripts from npm-run-all to pnpm regex patterns
docs/*.md Updated documentation examples to use pnpm exec instead of npx
Comments suppressed due to low confidence (1)

package.json:145

  • Missing closing brace for the 'pnpm' configuration object. The 'overrides' property should be nested within the 'pnpm' object, not at the root level.
    }

"private": true,
"scripts": {
"build": "npm-run-all build:*",
"build": "pnpm run '/^build:[^:]*$/'",
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern '/^build:[^:]$/' may not work as expected. Consider using 'build:' or testing this pattern thoroughly, as pnpm's regex support for script patterns might differ from npm-run-all.

Suggested change
"build": "pnpm run '/^build:[^:]*$/'",
"build": "pnpm run build:*",

Copilot uses AI. Check for mistakes.

Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: 37f7566

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🚢📀cicd Changes inside .github folder 📺showcases Changes to 1-n showcases 🛠️configuration 🏗foundations 🏘components labels Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚢📀cicd Changes inside .github folder 🏘components 🛠️configuration 📕documentation Improvements or additions to documentation 🏗foundations 🍄🆙improvement New feature or request 📺showcases Changes to 1-n showcases

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

Evaluate pnpm/yarn usage

1 participant