Skip to content

fix(card): removing obsolete, but harmful declaration regarding wrapping button and link styles #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

fix(card): removing obsolete, but harmful declaration regarding wrapping button and link styles #4935

wants to merge 10 commits into from

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Sep 8, 2025 •
edited
Loading

Proposed changes

Removed initial implementation by 6d72b42

Resolves #4934

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Sep 8, 2025
@mfranzke mfranzke added 🐛bug Something isn't working 👩‍👧‍👦communityFeedback Feedback from community labels Sep 8, 2025
@mfranzke mfranzke linked an issue Sep 8, 2025 that may be closed by this pull request
DBCard: global styles overwrite all inherit styles for DBCard #4934
Open
7 tasks
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 943258b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/4934-dbcard-global-styles-overwrite-all-inherit-styles-for-dbcard

@mfranzke mfranzke changed the title fix(card): removing obsolete, but harmful declaration fix(card): removing obsolete, but harmful declaration regarding button and link styles Sep 8, 2025
@mfranzke mfranzke changed the title fix(card): removing obsolete, but harmful declaration regarding button and link styles fix(card): removing obsolete, but harmful declaration regarding wrapping button and link styles Sep 8, 2025
@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Sep 8, 2025
@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏘components labels Sep 10, 2025
@mfranzke mfranzke marked this pull request as draft September 12, 2025 11:00
mfranzke and others added 6 commits September 12, 2025 20:37
@mfranzke
Merge branch 'main' into 4934-dbcard-global-styles-overwrite-all-inhe…
83c49c6 
…rit-styles-for-dbcard
@mfranzke
Merge branch 'main' into 4934-dbcard-global-styles-overwrite-all-inhe…
e7b1bc0 
…rit-styles-for-dbcard
@github-actions
auto update snapshots (#4980)
cf424aa 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke
Revert "fix(card): removing (most likely) obsolete, but harmful decla…
33c443f 
…ration"

This reverts commit b3bbd17.
@mfranzke
refactor: only disabling the minimum set of necessary declarations
fe292cb
@github-actions
auto update snapshots (#4991)
943258b 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmerget nmerget Awaiting requested review from nmerget

@michaelmkraus michaelmkraus Awaiting requested review from michaelmkraus

@sarahbrng sarahbrng Awaiting requested review from sarahbrng

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels

🐛bug Something isn't working 👩‍👧‍👦communityFeedback Feedback from community 🏘components 📕documentation Improvements or additions to documentation

Projects

UX Engineering Team Backlog
Status: 🏗 In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DBCard: global styles overwrite all inherit styles for DBCard

1 participant

@mfranzke