Skip to content

fix(card): removing obsolete, but harmful declaration regarding wrapping button and link styles #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 17, 2025
Merged

fix(card): removing obsolete, but harmful declaration regarding wrapping button and link styles #4935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b3bbd17
fix(card): removing (most likely) obsolete, but harmful declaration
mfranzke Sep 8, 2025
90a79ee
feat: added changeset
mfranzke Sep 8, 2025
de9d1c0
Merge branch 'main' into 4934-dbcard-global-styles-overwrite-all-inhe…
mfranzke Sep 10, 2025
ee861d2
Merge branch 'main' into 4934-dbcard-global-styles-overwrite-all-inhe…
mfranzke Sep 11, 2025
83c49c6
Merge branch 'main' into 4934-dbcard-global-styles-overwrite-all-inhe…
mfranzke Sep 12, 2025
e7b1bc0
Merge branch 'main' into 4934-dbcard-global-styles-overwrite-all-inhe…
mfranzke Sep 17, 2025
cf424aa
auto update snapshots (#4980)
github-actions[bot] Sep 17, 2025
33c443f
Revert "fix(card): removing (most likely) obsolete, but harmful decla…
mfranzke Sep 17, 2025
fe292cb
refactor: only disabling the minimum set of necessary declarations
mfranzke Sep 17, 2025
943258b
auto update snapshots (#4991)
github-actions[bot] Sep 17, 2025
7ec7d05
merge
mfranzke Oct 15, 2025
c4e21e6
auto update snapshots (#5269)
github-actions[bot] Oct 15, 2025
6755da8
Merge branch 'main' into 4934-dbcard-global-styles-overwrite-all-inhe…
mfranzke Oct 16, 2025
3c87f59
Merge branch 'main' into 4934-dbcard-global-styles-overwrite-all-inhe…
nmerget Oct 17, 2025
565f4f2
fix: issue with fonts
nmerget Oct 17, 2025
33b69ec
auto update snapshots (#5298)
github-actions[bot] Oct 17, 2025
85f447c
Update cool-bugs-chew.md
mfranzke Oct 17, 2025
832b0d0
Merge branch 'main' into 4934-dbcard-global-styles-overwrite-all-inhe…
mfranzke Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/cool-bugs-chew.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@db-ux/core-components": patch
"@db-ux/ngx-core-components": patch
"@db-ux/react-core-components": patch
"@db-ux/v-core-components": patch
"@db-ux/wc-core-components": patch
---

fix(card): Remove the obsolete but harmful declaration regarding wrapping button and link styles.
10 changes: 8 additions & 2 deletions packages/components/src/components/card/card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,15 @@
@use "@db-ux/core-foundations/build/styles/helpers";
@use "../../styles/internal/component";

:is(a, button) {
:is(a[href], button) {
// Resetting button and link specific declarations
&:has(.db-card) {
all: unset;
text-decoration: unset;
margin: unset;
border: unset;
background-color: transparent;
padding: unset;
font: inherit;
}

@include helpers.hover {
Expand Down
Loading