Skip to content

fix(button): enhance multi-line text support and update button styles #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

fix(button): enhance multi-line text support and update button styles #5003

wants to merge 30 commits into from

Conversation

@sarahbrng
Copy link
Contributor

@sarahbrng sarahbrng commented Sep 18, 2025 •
edited by github-actions bot
Loading

Proposed changes

  • Es ist gewünscht, dass Buttons mehrzeilig werden können und in der Höhe mitwachsen, wenn der Text umbricht.
  • fix: Button min-height statt fixed height

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

https://github.com/db-ux-design-system/core-team/issues/1064

❤️ Thank you!

image

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/1068-multiline-buttons

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f356f26

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@db-ux/core-web" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@github-actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/1068-multiline-buttons

@github-actions github-actions bot added 📺showcases Changes to 1-n showcases 🏘components labels Sep 18, 2025
@sarahbrng sarahbrng self-assigned this Sep 18, 2025
@github-actions
auto update snapshots (#5004)
a646908 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
michaelmkraus
michaelmkraus reviewed Sep 19, 2025
View reviewed changes
@sarahbrng sarahbrng enabled auto-merge (squash) September 24, 2025 10:36
sarahbrng and others added 3 commits September 24, 2025 16:37
@sarahbrng
Your commit message
955ae67
@sarahbrng
Merge branch 'main' into 1068-multiline-buttons
8cc87a5
@github-actions
auto update snapshots (#5052)
a260981 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nmerget
nmerget reviewed Sep 25, 2025
View reviewed changes
nmerget
nmerget reviewed Sep 25, 2025
View reviewed changes
nmerget
nmerget reviewed Sep 25, 2025
View reviewed changes
@mfranzke mfranzke moved this to 👀 In review in UX Engineering Team Backlog Sep 25, 2025
nmerget
nmerget reviewed Sep 25, 2025
View reviewed changes
nmerget
nmerget reviewed Sep 25, 2025
View reviewed changes
@nmerget nmerget added this to the 4.0.0 milestone Sep 25, 2025
sarahbrng and others added 2 commits September 26, 2025 13:37
@sarahbrng @nmerget
Update packages/components/src/components/button/button.scss
99bc9f7 
Co-authored-by: Nicolas Merget <[email protected]>
@github-actions
auto update snapshots (#5074)
2fcb678 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
auto update snapshots (#5196)
b505587 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke added this to the 4.1.0 milestone Oct 14, 2025
nmerget and others added 3 commits October 14, 2025 09:55
@nmerget
fix: angular and stencil issue with blank spaces
73b7a81
@github-actions
auto update snapshots (#5244)
240caef 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nmerget
Merge remote-tracking branch 'origin/main' into 1068-multiline-buttons
0a80801 
# Conflicts:
#	__snapshots__/switch/showcase/chromium-highContrast/DBSwitch-should-match-screenshot-1/DBSwitch-should-match-screenshot.png
#	__snapshots__/switch/showcase/chromium/DBSwitch-should-match-screenshot-1/DBSwitch-should-match-screenshot.png
#	__snapshots__/switch/showcase/firefox/DBSwitch-should-match-screenshot-1/DBSwitch-should-match-screenshot.png
#	__snapshots__/switch/showcase/mobile-chrome/DBSwitch-should-match-screenshot-1/DBSwitch-should-match-screenshot.png
mfranzke
mfranzke reviewed Oct 15, 2025
View reviewed changes
@nmerget nmerget marked this pull request as ready for review October 15, 2025 09:46
@nmerget nmerget enabled auto-merge (squash) October 15, 2025 09:48
@nmerget nmerget moved this from 🏗 In progress to 👀 Actively In Review in UX Engineering Team Backlog Oct 15, 2025
@nmerget nmerget self-requested a review October 15, 2025 09:48
@nmerget nmerget moved this from 👀 Actively In Review to 🎁 Ready for review in UX Engineering Team Backlog Oct 15, 2025
@github-actions
auto update snapshots (#5264)
e36de97 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nmerget nmerget requested a review from mfranzke October 15, 2025 13:30
@sarahbrng sarahbrng moved this from 🎁 Ready for review to 👀 Actively In Review in UX Engineering Team Backlog Oct 15, 2025
mfranzke
mfranzke reviewed Oct 15, 2025
View reviewed changes
...owcase/mobile-safari/DBButton-should-match-screenshot-1/DBButton-should-match-screenshot.png
Copy link
Collaborator

@mfranzke mfranzke Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the size of the "small" button (both height and width) has changed (most likely unintentionally) in this screenshot.

mfranzke
mfranzke reviewed Oct 15, 2025
View reviewed changes
...tton/showcase/webkit/DBButton-should-match-screenshot-1/DBButton-should-match-screenshot.png
Copy link
Collaborator

@mfranzke mfranzke Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the size of the "small" button (both height and width) has changed (most likely unintentionally) in this screenshot.

mfranzke
mfranzke reviewed Oct 15, 2025
View reviewed changes
@mfranzke mfranzke marked this pull request as draft October 15, 2025 15:54
auto-merge was automatically disabled October 15, 2025 15:54

Pull request was converted to draft

@mfranzke mfranzke moved this from 👀 Actively In Review to 🏗 In progress in UX Engineering Team Backlog Oct 15, 2025
@mfranzke mfranzke changed the title fix(button): enhance multi-line text support and update button styles feat(button): enhance multi-line text support and update button styles Oct 17, 2025
@mfranzke mfranzke changed the title feat(button): enhance multi-line text support and update button styles fix(button): enhance multi-line text support and update button styles Oct 17, 2025
nmerget and others added 2 commits October 17, 2025 09:47
@nmerget @mfranzke
Update packages/components/src/components/button/button.scss
7e85180 
Co-authored-by: Maximilian Franzke <[email protected]>
@github-actions
auto update snapshots (#5299)
f356f26 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nmerget
nmerget reviewed Oct 24, 2025
View reviewed changes
...showcase/mobile-safari/DBBadge-should-match-screenshot-1/DBBadge-should-match-screenshot.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside the placement section is some difference

@nmerget nmerget moved this from 🏗 In progress to 🎶 Waiting for feedback in UX Engineering Team Backlog Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfranzke mfranzke mfranzke left review comments

@nmerget nmerget nmerget left review comments

@michaelmkraus michaelmkraus michaelmkraus left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@sarahbrng sarahbrng

Labels

🏘components 📕documentation Improvements or additions to documentation 📺showcases Changes to 1-n showcases

Projects

Roadmap
Status: No status
UX Engineering Team Backlog
Status: 🎶 Waiting for feedback

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sarahbrng @mfranzke @nmerget @michaelmkraus