- 
        Couldn't load subscription status. 
- Fork 13
fix(button): enhance multi-line text support and update button styles #5003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
      
        
          +79
        
        
          −14
        
        
          
        
      
    
  
  
     Merged
                    Changes from 28 commits
      Commits
    
    
            Show all changes
          
          
            32 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      455a2cb
              
                fix(button): enhance multi-line text support and update button styles
              
              
                sarahbrng a646908
              
                auto update snapshots (#5004)
              
              
                github-actions[bot] b88d2d8
              
                Merge branch 'main' into 1068-multiline-buttons
              
              
                michaelmkraus c387526
              
                Update packages/components/src/components/button/button.scss
              
              
                sarahbrng 955ae67
              
                Your commit message
              
              
                sarahbrng 8cc87a5
              
                Merge branch 'main' into 1068-multiline-buttons
              
              
                sarahbrng a260981
              
                auto update snapshots (#5052)
              
              
                github-actions[bot] 99bc9f7
              
                Update packages/components/src/components/button/button.scss
              
              
                sarahbrng 2fcb678
              
                auto update snapshots (#5074)
              
              
                github-actions[bot] 7855b8a
              
                feat: improve button styles for multiline support
              
              
                sarahbrng 702dc1c
              
                auto update snapshots (#5079)
              
              
                github-actions[bot] 672d7c6
              
                Merge branch 'main' into 1068-multiline-buttons
              
              
                sarahbrng 5838cd1
              
                Merge remote-tracking branch 'refs/remotes/origin/main' into 1068-mul…
              
              
                nmerget 1abfb63
              
                chore: add changeset
              
              
                nmerget e4fcdf8
              
                auto update snapshots (#5156)
              
              
                github-actions[bot] afca40e
              
                Merge branch 'main' into 1068-multiline-buttons
              
              
                mfranzke 9fc576a
              
                chore: update from main
              
              
                nmerget e2e5dd1
              
                auto update snapshots (#5169)
              
              
                github-actions[bot] 36b5e2e
              
                Merge remote-tracking branch 'origin/main' into 1068-multiline-buttons
              
              
                nmerget b505587
              
                auto update snapshots (#5196)
              
              
                github-actions[bot] 73b7a81
              
                fix: angular and stencil issue with blank spaces
              
              
                nmerget 240caef
              
                auto update snapshots (#5244)
              
              
                github-actions[bot] 0a80801
              
                Merge remote-tracking branch 'origin/main' into 1068-multiline-buttons
              
              
                nmerget cdeb10a
              
                fix: issue with burger-button for stencil
              
              
                nmerget 2ae66c6
              
                Update .changeset/tricky-regions-agree.md
              
              
                nmerget 82614ca
              
                Merge branch 'main' into 1068-multiline-buttons
              
              
                nmerget 510b524
              
                fix: issue with small button
              
              
                nmerget e36de97
              
                auto update snapshots (#5264)
              
              
                github-actions[bot] 7e85180
              
                Update packages/components/src/components/button/button.scss
              
              
                nmerget f356f26
              
                auto update snapshots (#5299)
              
              
                github-actions[bot] e3714ef
              
                Merge branch 'main' into 1068-multiline-buttons
              
              
                sarahbrng 3f254c9
              
                Merge branch 'main' into 1068-multiline-buttons
              
              
                nmerget File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "@db-ux/core-components": patch | ||
| "@db-ux/ngx-core-components": patch | ||
| "@db-ux/react-core-components": patch | ||
| "@db-ux/v-core-components": patch | ||
| "@db-ux/wc-core-components": patch | ||
| --- | ||
|  | ||
| fix(button): Replace fixed height with min-height for buttons to allow dynamic height adjustment when text wraps | ||
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  ..._/accordion-item/patternhub/accordion-item-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/accordion/patternhub/accordion-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/badge/patternhub/badge-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/brand/patternhub/brand-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +1 Byte
                  (100%)
              
          
        
  __snapshots__/button/patternhub/button-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +19.3 KB
                  (130%)
              
          
        
  ...ontrast/DBButton-should-match-screenshot-1/DBButton-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
        
          
          Binary file modified
          
            BIN
              
                +21.8 KB
                  (130%)
              
          
        
  ...hromium/DBButton-should-match-screenshot-1/DBButton-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
        
          
          Binary file modified
          
            BIN
              
                +34.1 KB
                  (120%)
              
          
        
  ...firefox/DBButton-should-match-screenshot-1/DBButton-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
        
          
          Binary file modified
          
            BIN
              
                +16.7 KB
                  (130%)
              
          
        
  ...-chrome/DBButton-should-match-screenshot-1/DBButton-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
        
          
          Binary file modified
          
            BIN
              
                +26.3 KB
                  (130%)
              
          
        
  ...-safari/DBButton-should-match-screenshot-1/DBButton-should-match-screenshot.png
  
  
      
      
   
        
      
      
    |         
                  nmerget marked this conversation as resolved.
              Show resolved
            Hide resolved | 
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
        
          
          Binary file modified
          
            BIN
              
                +30.5 KB
                  (130%)
              
          
        
  .../webkit/DBButton-should-match-screenshot-1/DBButton-should-match-screenshot.png
  
  
      
      
   
        
      
      
    |         
                  nmerget marked this conversation as resolved.
              Show resolved
            Hide resolved | 
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/card/patternhub/card-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/checkbox/patternhub/checkbox-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  ...s__/custom-select/patternhub/custom-select-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                -8 Bytes
                  (100%)
              
          
        
  ...stomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/divider/patternhub/divider-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +4 Bytes
                  (100%)
              
          
        
  __snapshots__/drawer/patternhub/drawer-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                -2 Bytes
                  (100%)
              
          
        
  __snapshots__/header/patternhub/header-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +1 Byte
                  (100%)
              
          
        
  __snapshots__/infotext/patternhub/infotext-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/input/patternhub/input-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/link/patternhub/link-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  ...navigation-item/patternhub/navigation-item-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +1 Byte
                  (100%)
              
          
        
  ...apshots__/navigation/patternhub/navigation-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +1 Byte
                  (100%)
              
          
        
  ...ots__/notification/patternhub/notification-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/popover/patternhub/popover-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
          Binary file modified
          
            BIN
              
                +16.1 KB
                  (110%)
              
          
        
  ...trast/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +19 KB
                  (110%)
              
          
        
  ...omium/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +31.9 KB
                  (110%)
              
          
        
  ...refox/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +27.3 KB
                  (130%)
              
          
        
  ...hrome/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +50.1 KB
                  (130%)
              
          
        
  ...afari/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +30.3 KB
                  (110%)
              
          
        
  ...ebkit/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/radio/patternhub/radio-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +1 Byte
                  (100%)
              
          
        
  __snapshots__/section/patternhub/section-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +67 Bytes
                  (100%)
              
          
        
  __snapshots__/select/patternhub/select-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +1 Byte
                  (100%)
              
          
        
  __snapshots__/stack/patternhub/stack-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/switch/patternhub/switch-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/tab-item/patternhub/tab-item-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/tabs/patternhub/tabs-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                -155 Bytes
                  (82%)
              
          
        
  __snapshots__/tag/component/chromium/DBTag-should-be-a-button.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                -194 Bytes
                  (80%)
              
          
        
  __snapshots__/tag/component/firefox/DBTag-should-be-a-button.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                -155 Bytes
                  (82%)
              
          
        
  __snapshots__/tag/component/mobile-chrome/DBTag-should-be-a-button.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +1 Byte
                  (100%)
              
          
        
  __snapshots__/tag/patternhub/tag-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +0 Bytes
                  (100%)
              
          
        
  __snapshots__/textarea/patternhub/textarea-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
        
          
          Binary file modified
          
            BIN
              
                +1 Byte
                  (100%)
              
          
        
  __snapshots__/tooltip/patternhub/tooltip-overview-should-match-screenshot.png
  
  
      
      
   
        
      
      
    
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.