docs: Rename variant names: removing 'Label' for data-input components #5198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Default) Label Above → (Default) Above Floating Label → Floating
github-project-automation
bot
moved this to 🏗 In progress
in UX Engineering Team Backlog
|
github-actions
bot
added
📺showcases
leape
changed the title
mfranzke
moved this from 🏗 In progress
to 🎁 Ready for review
in UX Engineering Team Backlog
mfranzke
moved this from 🎁 Ready for review
to 🏗 In progress
in UX Engineering Team Backlog
(Default) Label Above → (Default) Above Floating Label → Floating
(Default) Label Above → (Default) Above Floating Label → Floating
(Default) Label Above → (Default) Above Floating Label → Floating
leape
changed the title
leape
moved this from 🏗 In progress
to 🎁 Ready for review
in UX Engineering Team Backlog
|
@mfranzke all variant names for the 4 respective data input components in this branch have been renamed. |
Great ! Next step will be that the pipeline regenerates the screenshots itself and afterwards I could review and approve this PR. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke
reviewed
Oct 10, 2025
...nput/showcase/chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nmerget
previously approved these changes
Oct 15, 2025
nmerget
moved this from 🎁 Ready for review
to 👀 Actively In Review
in UX Engineering Team Backlog
…riant-name # Conflicts: # __snapshots__/textarea/showcase/chromium/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png # __snapshots__/textarea/showcase/firefox/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png # __snapshots__/textarea/showcase/mobile-chrome/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke
reviewed
Oct 15, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke
approved these changes
Oct 15, 2025
github-project-automation
bot
moved this from 👀 Actively In Review
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
(Default) Label Above → (Default) Above
Floating Label → Floating
for: custom select, input, select, textarea
Resolves https://github.com/db-ux-design-system/core-team/issues/1182
Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/docs-input-changed-variant-name