Skip to content

docs: Rename variant names: removing 'Label' for data-input components #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 15, 2025
Merged

docs: Rename variant names: removing 'Label' for data-input components #5198

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
44bdf9c
docs: Rename variant names: removing 'Label'
leape Oct 10, 2025
7478f99
docs: Rename variant names: removing 'Label'
leape Oct 10, 2025
be3f258
docs: Rename variant names: removing 'Label'
leape Oct 10, 2025
65770d8
docs: Rename variant names: removing 'Label'
leape Oct 10, 2025
75cb8ed
Merge branch 'main' into docs-input-changed-variant-name
mfranzke Oct 10, 2025
0ce2e47
auto update snapshots (#5203)
github-actions[bot] Oct 10, 2025
4db5ebf
Update value in Floating input to 'Floating'
mfranzke Oct 10, 2025
becb533
Merge branch 'main' into docs-input-changed-variant-name
mfranzke Oct 10, 2025
030808c
auto update snapshots (#5204)
github-actions[bot] Oct 10, 2025
5b0c5eb
Merge remote-tracking branch 'origin/main' into docs-input-changed-va…
nmerget Oct 15, 2025
d9f9bfe
auto update snapshots (#5254)
github-actions[bot] Oct 15, 2025
4e8c7bd
Apply suggestion from @mfranzke
mfranzke Oct 15, 2025
55f0087
merge
mfranzke Oct 15, 2025
29830a7
auto update snapshots (#5259)
github-actions[bot] Oct 15, 2025
d70df2a
Merge branch 'main' into docs-input-changed-variant-name
mfranzke Oct 15, 2025
415b533
Merge branch 'main' into docs-input-changed-variant-name
mfranzke Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...stomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions ...ontrast/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@
- text: Option 5
- status
- link "Variant"
- text: (Default) Label Above
- text: (Default) Above
- group:
- article:
- radiogroup "id-10211-(Default) Label Above":
- radiogroup "id-10211-(Default) Above":
- list:
- listitem:
- radio "Option 1"
Expand All @@ -129,10 +129,10 @@
- radio "Option 5"
- text: Option 5
- status
- text: Floating Label
- text: Floating
- group:
- article:
- radiogroup "id-10212-Floating Label":
- radiogroup "id-10212-Floating":
- list:
- listitem:
- radio "Floating Label"
Expand Down
Binary file modified ...stomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions ...hromium/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@
- text: Option 5
- status
- link "Variant"
- text: (Default) Label Above
- text: (Default) Above
- group:
- article:
- radiogroup "id-10211-(Default) Label Above":
- radiogroup "id-10211-(Default) Above":
- list:
- listitem:
- radio "Option 1"
Expand All @@ -129,10 +129,10 @@
- radio "Option 5"
- text: Option 5
- status
- text: Floating Label
- text: Floating
- group:
- article:
- radiogroup "id-10212-Floating Label":
- radiogroup "id-10212-Floating":
- list:
- listitem:
- radio "Floating Label"
Expand Down
Binary file modified ...stomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions ...firefox/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@
- text: Option 5
- status
- link "Variant"
- text: (Default) Label Above
- text: (Default) Above
- group:
- article:
- radiogroup "id-10211-(Default) Label Above":
- radiogroup "id-10211-(Default) Above":
- list:
- listitem:
- radio "Option 1"
Expand All @@ -129,10 +129,10 @@
- radio "Option 5"
- text: Option 5
- status
- text: Floating Label
- text: Floating
- group:
- article:
- radiogroup "id-10212-Floating Label":
- radiogroup "id-10212-Floating":
- list:
- listitem:
- radio "Floating Label"
Expand Down
8 changes: 4 additions & 4 deletions ...-chrome/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@
- button "Close"
- status
- link "Variant"
- text: (Default) Label Above
- text: (Default) Above
- group:
- article:
- radiogroup "id-10211-(Default) Label Above":
- radiogroup "id-10211-(Default) Above":
- list:
- listitem:
- radio "Option 1"
Expand All @@ -135,10 +135,10 @@
- text: Option 5
- button "Close"
- status
- text: Floating Label
- text: Floating
- group:
- article:
- radiogroup "id-10212-Floating Label":
- radiogroup "id-10212-Floating":
- list:
- listitem:
- radio "Floating Label"
Expand Down
8 changes: 4 additions & 4 deletions ...-safari/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@
- button "Close"
- status
- link "Variant"
- text: (Default) Label Above
- text: (Default) Above
- group:
- article:
- radiogroup "id-10211-(Default) Label Above":
- radiogroup "id-10211-(Default) Above":
- list:
- listitem:
- radio "Option 1"
Expand All @@ -135,10 +135,10 @@
- text: Option 5
- button "Close"
- status
- text: Floating Label
- text: Floating
- group:
- article:
- radiogroup "id-10212-Floating Label":
- radiogroup "id-10212-Floating":
- list:
- listitem:
- radio "Floating Label"
Expand Down
8 changes: 4 additions & 4 deletions .../webkit/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@
- text: Option 5
- status
- link "Variant"
- text: (Default) Label Above
- text: (Default) Above
- group:
- article:
- radiogroup "id-10211-(Default) Label Above":
- radiogroup "id-10211-(Default) Above":
- list:
- listitem:
- radio "Option 1"
Expand All @@ -129,10 +129,10 @@
- radio "Option 5"
- text: Option 5
- status
- text: Floating Label
- text: Floating
- group:
- article:
- radiogroup "id-10212-Floating Label":
- radiogroup "id-10212-Floating":
- list:
- listitem:
- radio "Floating Label"
Expand Down
Binary file modified ...hContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ...m-highContrast/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
- textbox "Label"
- status
- text: Label
- textbox "Label": Floating Label
- textbox "Label": Floating
- status
- link "Show Label"
- text: Label
Expand Down
Binary file modified .../chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ...wcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
- textbox "Label"
- status
- text: Label
- textbox "Label": Floating Label
- textbox "Label": Floating
- status
- link "Show Label"
- text: Label
Expand Down
Binary file modified ...e/firefox/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ...owcase/firefox/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
- textbox "Label"
- status
- text: Label
- textbox "Label": Floating Label
- textbox "Label": Floating
- status
- link "Show Label"
- text: Label
Expand Down
Binary file modified ...le-chrome/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion .../mobile-chrome/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
- textbox "Label"
- status
- text: Label
- textbox "Label": Floating Label
- textbox "Label": Floating
- status
- link "Show Label"
- text: Label
Expand Down
2 changes: 1 addition & 1 deletion .../mobile-safari/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
- textbox "Label"
- status
- text: Label
- textbox "Label": Floating Label
- textbox "Label": Floating
- status
- link "Show Label"
- text: Label
Expand Down
2 changes: 1 addition & 1 deletion ...howcase/webkit/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
- textbox "Label"
- status
- text: Label
- textbox "Label": Floating Label
- textbox "Label": Floating
- status
- link "Show Label"
- text: Label
Expand Down
Binary file modified ...ontrast/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@
- option "Option 3"
- option "Option 4"
- option "Option 5"
- text: (Default) Label Above
- text: (Default) Above
- status
- text: Label
- combobox "Label":
- option
- option "Floating Label" [selected]
- option "Floating" [selected]
- option "Option 2"
- status
- link "Show Label"
Expand Down
Binary file modified ...hromium/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...case/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@
- option "Option 3"
- option "Option 4"
- option "Option 5"
- text: (Default) Label Above
- text: (Default) Above
- status
- text: Label
- combobox "Label":
- option
- option "Floating Label" [selected]
- option "Floating" [selected]
- option "Option 2"
- status
- link "Show Label"
Expand Down
Binary file modified ...firefox/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...wcase/firefox/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@
- option "Option 3"
- option "Option 4"
- option "Option 5"
- text: (Default) Label Above
- text: (Default) Above
- status
- text: Label
- combobox "Label":
- option
- option "Floating Label" [selected]
- option "Floating" [selected]
- option "Option 2"
- status
- link "Show Label"
Expand Down
Binary file modified ...-chrome/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@
- option "Option 3"
- option "Option 4"
- option "Option 5"
- text: (Default) Label Above
- text: (Default) Above
- status
- text: Label
- combobox "Label":
- option
- option "Floating Label" [selected]
- option "Floating" [selected]
- option "Option 2"
- status
- link "Show Label"
Expand Down
4 changes: 2 additions & 2 deletions ...mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@
- option "Option 3"
- option "Option 4"
- option "Option 5"
- text: (Default) Label Above
- text: (Default) Above
- status
- text: Label
- combobox "Label":
- option
- option "Floating Label" [selected]
- option "Floating" [selected]
- option "Option 2"
- status
- link "Show Label"
Expand Down
4 changes: 2 additions & 2 deletions ...owcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@
- option "Option 3"
- option "Option 4"
- option "Option 5"
- text: (Default) Label Above
- text: (Default) Above
- status
- text: Label
- combobox "Label":
- option
- option "Floating Label" [selected]
- option "Floating" [selected]
- option "Option 2"
- status
- link "Show Label"
Expand Down
Binary file modified ...ast/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ium/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...fox/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ome/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions showcases/shared/custom-select.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
"name": "Variant",
"examples": [
{
"name": "(Default) Label Above",
"name": "(Default) Above",
"style": {
"width": "200px"
},
Expand Down Expand Up @@ -219,7 +219,7 @@
"children": []
},
{
"name": "Floating Label",
"name": "Floating",
"style": {
"width": "200px"
},
Expand Down
6 changes: 3 additions & 3 deletions showcases/shared/input.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,17 @@
"name": "Variant",
"examples": [
{
"name": "(Default) Label Above",
"name": "(Default) Above",
"props": {
"label": "Label"
}
},
{
"name": "Floating Label",
"name": "Floating",
"props": {
"label": "Label",
"variant": "floating",
"value": "Floating Label"
"value": "Floating"
}
}
]
Expand Down
10 changes: 5 additions & 5 deletions showcases/shared/select.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"name": "Variant",
"examples": [
{
"name": "(Default) Label Above",
"name": "(Default) Above",
"style": {
"width": "300px"
},
Expand All @@ -115,7 +115,7 @@
}
],
"label": "Label",
"placeholder": "(Default) Label Above"
"placeholder": "(Default) Above"
}
},
{
Expand All @@ -126,7 +126,7 @@
"props": {
"options": [
{
"value": "Floating Label",
"value": "Floating",
"selected": true
},
{
Expand All @@ -135,8 +135,8 @@
],
"label": "Label",
"variant": "floating",
"value": "Floating Label",
"placeholder": "Floating Label"
"value": "Floating",
"placeholder": "Floating"
}
}
]
Expand Down
4 changes: 2 additions & 2 deletions showcases/shared/textarea.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@
"name": "Variant",
"examples": [
{
"name": "(Default) Label Above",
"name": "(Default) Above",
"props": {
"label": "Label"
}
},
{
"name": "Floating Label",
"name": "Floating",
"props": {
"label": "Label",
"variant": "floating",
Expand Down