Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert va-icons to replace FA in alerts #2329

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Insert va-icons to replace FA in alerts #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70dfefa
add va-icon to usa-alert elements
rmessina1010 Oct 25, 2024
98e6b0c
review and add icons
rmessina1010 Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/site/includes/gibs-down.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div id="top-of-page-alert-container">
<div id="top-of-page-alert" class="usa-alert usa-alert-warning">
<va-icon icon="warning" size="3" class="os-icon"></va-icon>
<div class="usa-alert-body">
<p class="usa-alert-text">We’re sorry. Something’s not working quite right with the GI Bill benefits tool. We’re working to fix the problem. If you encounter any errors, please try again later.</p>
</div>
Expand Down
1 change: 1 addition & 0 deletions src/site/paragraphs/react_widget.drupal.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
</span>
{% if entity.fieldErrorMessage != empty %}
<div class="usa-alert usa-alert-error sip-application-error vads-u-display--none" aria-hidden="true">
<va-icon icon="error" size="3" class="os-icon vads-u-color--error"></va-icon>
<div class="usa-alert-body">
{{ entity.fieldErrorMessage.value }}
</div>
Expand Down
1 change: 1 addition & 0 deletions src/site/tests/static-pages/static-page-widgets.unit.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const widgetContent = `
<a class="vads-c-action-link--green" href="/pension/application/527EZ">Apply for Veterans Pension Benefits</a>
</span>
<div class="usa-alert usa-alert-error sip-application-error vads-u-display--none" aria-hidden="true">
<va-icon icon="error" size={3} className="vads-u-color--error" />
<div class="usa-alert-body">
<strong>We’re sorry. Something went wrong when we tried to load your saved application.</strong><br>Please try refreshing your browser in a few minutes.
</div>
Expand Down
Loading