[Enhancement] Improve loading indicator animation loop and cleanup #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… function to stop the animation
3 tasks
|
This PR will be ready for review when #621 is approved. |
14 tasks
kimmccaskill-oddball
approved these changes
Feb 11, 2025
ATeal
approved these changes
Feb 17, 2025
| }).start(() => animate()) // Loop the animation | ||
| } | ||
| animate() | ||
| useNativeDriver: isAndroid() || isIOS(), |
There was a problem hiding this comment.
No, these components also work in a web environment (e.g., the Storybook).
oddballdave
deleted the
enhancement/618-ImproveLoadingIndicatorAnimationLoopAndCleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Replaced repetitive animation firing in the LoadingIndicator with a loop and added a cleanup function.
Testing Packages
Screenshots/Video
Testing
Tested library on Android, iOS and Web. Also incorporated package into VA Mobile app and performed manual tests as well as detox/e2e tests.
PR Checklist
Code reviewer validation:
changeloglabel applied if it's to be included in the changelogPublish
If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:
maininto branchmain