Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix VoiceOver for SegmentedControl #625

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

oddballdave
Copy link
Contributor

@oddballdave oddballdave commented Jan 22, 2025

Description of Change

On iOS, the SegmentedControl did not correctly announce the state or the role of each tab contained within it. After extensive research, this looks to be an issue with either React Native and/or iOS itself. To mitigate the problem the SegmentedControl was modified to supply the text that VoiceOver should speak. Note that this is not an issue on Android.

Testing Packages

N/A

Screenshots/Video

These videos were created using the Accessibility Inspector that comes with Xcode. Turn up your sound to hear the before/after differences with VoiceOver.

Before.mov
After.mov

Testing

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@oddballdave oddballdave linked an issue Jan 22, 2025 that may be closed by this pull request
5 tasks
@oddballdave oddballdave added changelog design-system DS-Bug Bug tickets specifically for the Design System labels Jan 22, 2025
@Eallan919
Copy link

These PR's are blocked because no one is available/authorized to review them: #622 & #625.

Copy link
Collaborator

@matt-guest-wilcore matt-guest-wilcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything works as expected. Nice work.

@oddballdave oddballdave marked this pull request as ready for review February 14, 2025 21:41
@oddballdave oddballdave requested a review from a team as a code owner February 14, 2025 21:41
@oddballdave oddballdave merged commit e8f40f3 into main Feb 17, 2025
4 of 5 checks passed
@oddballdave oddballdave deleted the bug/619-fix-voiceover-for-segmented-control branch February 17, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog design-system DS-Bug Bug tickets specifically for the Design System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - Sev-3 - iOS - VoiceOver not announcing role of SegmentedControl component
5 participants