Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Confirmation Page: Not completely successful submit flow (no claim id) #95241

Open
11 of 18 tasks
christinec-fftc opened this issue Oct 17, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/vets-website#33012
Open
11 of 18 tasks

New Confirmation Page: Not completely successful submit flow (no claim id) #95241

christinec-fftc opened this issue Oct 17, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/vets-website#33012
Assignees
@christinec-fftc
Labels
DBEX-TREX Disability Benefits Experience - Team T-Rex engineering Engineering topics frontend zero-silent-failures Work related to eliminating silent failures ZSF:UserExperience User experience changes on confirmation page/emails to clarify the status of the submission.

Comments

@christinec-fftc
Copy link
Contributor

christinec-fftc commented Oct 17, 2024 •
edited
Loading

Issue Description

Handle the scenario where submit_all_claim returns 200 success and submission_status returns 200(s) but no claim id. Utilizes changes from previous successful submit stories.
This is when the polling is done, but there was no claim id returned within the time frame.

mocks: https://www.figma.com/design/qyTtKDOTHZPGU59PAfqVhq/(526ez)-New-Confirmation-Page-and-Email-Touchpoints?node-id=8405-81028

  1. If toggle enabled, display (previously created) success alert, and blue card without claim id.
    Image

Front end tasks

  • Ensure the page is styled according to design spec.
  • Ensure the back end data from API is displayed in local and review instance
  • Ensure unit tests are available.
  • Ensure your code changes are covered by E2E tests
  • Run axe checks using the Chrome or Firefox browser plugin
  • Test for color contrast and color blindness issues
  • Zoom layouts to 400% at 1280px width
  • Test with 1 or 2 screen readers
  • Navigate using the keyboard only

Acceptance Criteria

  • Verify success alert is displayed and yellow alert does not display.
  • Verify blue card displays with claim info, but no claim id
  • Verify rest of the content on the page displays
  • Designer comments on this issue to approve page styling
  • Unit tests pass
  • E2E tests cover current code and regression
  • End-to-end tests show 0 violations.
  • The data returned matches API response (for given user or scenario)
  • All axe checks pass
  • All color contrast checks pass
  • All zoom testing passes
  • All keyboard checks pass
  • All screenreader checks pass

Appendix

Ensure your code changes are covered by E2E tests (expand)

  • Add E2E tests if none exist for this addition/change.

  • Update existing E2E tests if this code will change functionality.

  • Include axe checks, including hidden content

Run axe checks using the Chrome or Firefox browser plugin (expand)

  • Ensure no heading levels are skipped.

  • Ensure all buttons and labeled inputs use semantic HTML elements.

  • Ensure all buttons, labeled elements and images are identified using HTML semantic markers or ARIA roles.

  • Ensure form fields have clearly defined boundaries or outlines.

  • Ensure form fields do not use placeholder text.

  • Ensure form fields have highly visible and specific error states.

Test for color contrast and color blindness issues (expand) - All text has appropriate contrast.
Zoom layouts to 400% at 1280px width (expand) - Ensure readability and usability are supported when zoomed up to 400% at 1280px browser width - Ensure no content gets focused offscreen or is hidden from view.
Test with 1 or 2 screen readers (expand)

  • Ensure the page includes a skip navigation link.

  • Ensure all links are properly descriptive.

  • Ensure screen reader users can hear the text equivalent for each image conveying information.

  • Ensure screen reader users can hear the text equivalent for each image button.

  • Ensure screen reader users can hear labels and instructions for inputs.

  • Ensure purely decorative images are not announced by the screenreader.

Navigate using the keyboard only (expand)

  • Ensure all links (navigation, text and/or image), form controls and page functions can be reached with the tab key in a logical order.

  • Ensure all links (navigation, text and/or image), form controls and page functions can be triggered with the spacebar, enter key, or arrow keys.

  • Ensure all interactive elements can be reached with the tab key in a logical order

  • Ensure all interactive elements can be triggered with the spacebar, enter key, or arrow keys.

  • Ensure focus is always visible and appears in logical order.

  • Ensure each interactive element has visible focus state which appears in logical order.

How to configure this issue

  • Attached to a Milestone (when will this be completed?)
  • Attached to an Epic (what body of work is this a part of?)
  • Labeled with Team (product support, analytics-insights, operations, service-design, Console-Services, tools-fe)
  • Labeled with Practice Area (backend, frontend, devops, design, research, product, ia, qa, analytics, contact center, research, accessibility, content)
  • Labeled with Type (bug, request, discovery, documentation, etc.)
@christinec-fftc christinec-fftc added DBEX-TREX Disability Benefits Experience - Team T-Rex engineering Engineering topics frontend labels Oct 17, 2024
This was referenced Oct 17, 2024
Closed
Closed
@pacerwow pacerwow added zero-silent-failures Work related to eliminating silent failures ZSF:UserExperience User experience changes on confirmation page/emails to clarify the status of the submission. labels Oct 17, 2024
@pammicmac pammicmac mentioned this issue Nov 6, 2024
Open
3 tasks
@christinec-fftc christinec-fftc linked a pull request Nov 14, 2024 that will close this issue
95241 add 'no claim id' and BDD scenarios department-of-veterans-affairs/vets-website#33012
Draft
14 tasks
@christinec-fftc christinec-fftc linked a pull request Nov 14, 2024 that will close this issue
Draft
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christinec-fftc christinec-fftc

Labels
DBEX-TREX Disability Benefits Experience - Team T-Rex engineering Engineering topics frontend zero-silent-failures Work related to eliminating silent failures ZSF:UserExperience User experience changes on confirmation page/emails to clarify the status of the submission.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

95241 add 'no claim id' and BDD scenarios department-of-veterans-affairs/vets-website
3 participants
@emilytheis @christinec-fftc @pacerwow