Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update location of death page(s) #34470

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

ToddWebDev
Copy link
Contributor

@ToddWebDev ToddWebDev commented Feb 3, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes

Did you change site-wide styles, platform utilities or other infrastructure?

  • No
  • Yes

Summary

Update the 'Location of death' page on the Burial Benefits form (21P-530EZ) to a more accessible UI pattern.

Issue

Associated Pull Request(s)

How to run in local environment

  1. Check out this branch locally
  2. Run vets-website and vets-api
  3. In your local environment, set the burial_location_of_death_update flipper to 'enabled' at http://localhost:3000/flipper/features/burial_location_of_death_update
  4. Go to http://localhost:3001/burials-memorials/veterans-burial-allowance/apply-for-allowance-form-21p-530ez/ in your browser

How to verify

Location of Death page

  1. Sign in
  2. Go to the /location-of-death-v2 page

At Home

  1. Select 'At home' and then 'Continue'
  2. Verify that the 'Veteran death location information' page is NOT displayed

In a nursing home or facility that VA doesn't pay for

  1. Select 'In a nursing home or facility that VA doesn't pay for' and then 'Continue'
  2. Verify that the 'Veteran death location information' page is displayed with the correct field labels

In a nursing home or facility that VA pays for

  1. Select 'In a nursing home or facility that VA pays for' and then 'Continue'
  2. Verify that the 'Veteran death location information' page is displayed with the correct field labels

In a VA medical center

  1. Select 'In a VA medical center' and then 'Continue'
  2. Verify that the 'Veteran death location information' page is displayed with the correct field labels

In a state Veterans facility

  1. Select 'In a state Veterans facility' and then 'Continue'
  2. Verify that the 'Veteran death location information' page is displayed with the correct field labels

Other

  1. Select 'Other' and then 'Continue'
  2. Verify that 'Other' is a required field
  3. Enter text into 'Other' field and then 'Continue'
  4. Verify that the 'Veteran death location information' page is NOT displayed

Review and submit

  1. Sign in
  2. Load data into the 'Save in progress' menu
  3. Return to the /review-and-submit page
  4. Expand the 'Deceased Veteran information' accordion
  5. Verify that the 'Veteran death location' data is correct
  6. Verify that the 'Veteran death location information' is correct
  7. Verify that only the active 'Veteran death location information' is included in the submission

What areas of the site does it impact?

Burial Benefits Application

Screenshots

Location of death page(s)

Before After After
Screenshot 2025-02-03 at 8 20 39 AM Screenshot 2025-02-03 at 1 48 42 PM Screenshot 2025-02-03 at 1 50 10 PM

Review and submit page

Before After
Screenshot 2025-02-03 at 3 36 47 PM Screenshot 2025-02-04 at 8 54 59 AM

Quality Assurance & Testing

  • New unit tests (if applicable)
  • New E2E tests added (if applicable)
  • Existing unit tests and integration tests are passing
  • Existing E2E tests are passing
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot style, layout and content matches the design references
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@ToddWebDev ToddWebDev added the burial-benefits Label used for Pull Requests that impact Burial claims (530) label Feb 3, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to master/burial-80105-location-of-death-updates/main February 4, 2025 02:14 Inactive
Copy link
Contributor

@balexandr balexandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ToddWebDev ToddWebDev marked this pull request as ready for review February 4, 2025 17:24
@ToddWebDev ToddWebDev requested review from a team as code owners February 4, 2025 17:24
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
burial-benefits Label used for Pull Requests that impact Burial claims (530)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Consistency] User encounters a component or pattern that isn't considered a best practice.
4 participants