Skip to content

Update item page #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 27, 2025
Merged

Update item page #49

merged 8 commits into from
Mar 27, 2025

Conversation

oliverroick
Copy link
Member

  • Updates page header to match other pages
  • Adds links (ref [STAC] Add Assets list and Links in HTML item page #43).
  • Adds items assets (ref [STAC] Add Assets list and Links in HTML item page #43). The asset display is the same as the one on the collection page. Additional properties are shown in a disclosure, otherwise the page would be very long and convoluted.
  • Updates the styling of item properties using columns and pretty print for property values, which makes complex JSON object more readable. (I'll update other pages to match this once the change is approved here)
  • Update map positioning, it now stays in place when you scroll. (I'll update other pages to match this once the change is approved here)

Copy link
Contributor

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few ideas for improving the asset details formatting, but nothing big. I love the sticky map when you scroll through the item/asset properties!

Comment on lines 52 to 53
<p class="small text-monospace text-muted mb-0">{{ key }}</p>
{% if asset.title %}<p class="mb-0"><b>{{ asset.title }}</b></p>{% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about skipping the title if it is the same as the asset key? I also think it would look good to make the asset key normal size and bolded, then italicize the title or something like that.
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not pleased with how that looks either. It's very convoluted and I'd like to revisit that at some point, maybe we can get some help from a designer.

In the meantime, I've tried your suggestion and it looks ... ok.

Screenshot 2025-03-27 at 10 16 30 am

I've tried some other options as well.

Option A
Screenshot 2025-03-27 at 10 18 43 am

Option B
Screenshot 2025-03-27 at 10 15 10 am

Option C
Screenshot 2025-03-27 at 10 14 16 am

I like Option A, because it has a clear header. What do you think?

Copy link
Contributor

@hrodmn hrodmn Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option A looks good to me!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could get a designer to contribute to https://github.com/developmentseed/stac-fastapi-html-middleware

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option A looks good to me!

Pushed the update with that option

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could get a designer to contribute to https://github.com/developmentseed/stac-fastapi-html-middleware

I'll forward the change to the templates 😄

Copy link
Member

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@vincentsarago vincentsarago merged commit 36e0618 into main Mar 27, 2025
2 checks passed
@vincentsarago vincentsarago deleted the update-item-page branch March 27, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants