generated from developmentseed/eoapi-template
-
Notifications
You must be signed in to change notification settings - Fork 3
Update item page #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update item page #49
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fb575b0
Update item page header
oliverroick 3665b3b
Add item links
oliverroick 91cad73
Add asset display
oliverroick c4940f7
Style item properties
oliverroick 73bde6d
Stick map to position
oliverroick c0eaf63
Extend item page from base.html
oliverroick 4c446a4
Skip description from asset props
oliverroick b0b8403
Update asset title layout
oliverroick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about skipping the

title
if it is the same as the assetkey
? I also think it would look good to make the assetkey
normal size and bolded, then italicize the title or something like that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not pleased with how that looks either. It's very convoluted and I'd like to revisit that at some point, maybe we can get some help from a designer.
In the meantime, I've tried your suggestion and it looks ... ok.
I've tried some other options as well.
Option A

Option B

Option C

I like Option A, because it has a clear header. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option A looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could get a designer to contribute to https://github.com/developmentseed/stac-fastapi-html-middleware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed the update with that option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll forward the change to the templates 😄