Skip to content

patches: point gcov_gcno_file at apple_support#693, match rules_rust#4433 feature list (part of #12977) - #13795

Merged
TrapsterDK merged 1 commit into
mainfrom
issue-12977-patch-upstream
Nov 19, 2026
Merged

TrapsterDK merged 1 commit into
mainfrom
issue-12977-patch-upstream

Conversation

@TrapsterDK

@TrapsterDK TrapsterDK commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Part of #12977.

  • patches/apple_support/gcov_gcno_file.patch: Upstream: bazelbuild/apple_support#693 (merged 2026-11-18, after 2.12.0), so patch-upstream.yml reports it once released.
  • patches/rules_rust/cargo_build_script_no_coverage.patch: same five unsupported features as cargo_build_script: don't configure cc coverage features for build scripts bazelbuild/rules_rust#4433 (adds coverage_enabled, coverage_instrumented). Single-line change, hunk header unchanged, so later patches still apply.
  • patches/README.md: rows name both upstream PRs.

Remaining for #12977: once a rules_rust release has #4433 and an apple_support release has #693, bump both, drop the two patches and their references (MODULE.bazel, patches/rules_rust/BUILD.bazel, deploy/private/release/tests/BUILD.bazel, tools/testing/nested/src/compose.rs, RULES_RUST_PATCHES 11 -> 10).

Tests (Linux, local):

  • bazel test --keep_going //patches/... //rust/tests/fixtures/native_call/...: 34 pass, 24 skipped (platform), 1 fails to build: //patches:update_readme_test fails on main too ("patches/README.md: no section for capnproto names repo_relative_labels.patch, which MODULE.bazel applies"), unrelated to this diff.
  • bazel coverage //rust/tests/fixtures/native_call:native_cc_test: PASSED.
  • bazel run //patches:upstream (with GH token): empty report, so gcov_gcno_file.patch is neither missing nor unreadable.
  • Nested-Bazel and consumer tests not run locally.

macOS evidence: pending, run https://github.com/devhusdk/rules_dx/actions/runs/44481715306

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hvgPbKqbuDgsTasg7K

…4433 feature list (part of #12977)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hvgPbKqbuDgsTasg7K
@TrapsterDK TrapsterDK added the needs-review Touches review paths; needs a second-session Review: comment label Nov 19, 2026
@TrapsterDK
TrapsterDK merged commit b2a4e6a into main Nov 19, 2026
5 of 8 checks passed
@TrapsterDK
TrapsterDK deleted the issue-12977-patch-upstream branch November 19, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Touches review paths; needs a second-session Review: comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant