fix aliasing UB, layout UB, and incorrect initialization UB#939
Open
Morgane55440 wants to merge 1 commit into
Open
fix aliasing UB, layout UB, and incorrect initialization UB#939Morgane55440 wants to merge 1 commit into
Morgane55440 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
get_disjoint_mut-likes are aliasing UB under the current memory model.for more info, see the internal code of
get_disjoint_mutand the relevant history.as_vectoronRigidBodyVelocityis UB because it is not#[repr(C)]reset_buffercan cause incorrect initialization UB because it initializeslenbytes, but it says it has initializedlen * size_of:::<T>bytes.the
get_disjoint_mut-likes have been checked to result in the same assembly after fix :the asm for
reset_bufferis slightly different, but it still usesmemsetwhich is the important part.