Remove deprecated methods from ParserResult and the SingleSelectExecutor class
#12195
+19
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
force-pushed
the
drop-deprecated-parser-result-methods
branch
from
9a68fbf to
e02d232
Compare
Closed
greg0ire
reviewed
Oct 7, 2025
mpdude
changed the title
ParserResultParserResult and the SingleSelectExecutor class
|
The PHPStan baseline needs an update: Lines 2319 to 2323 in cdc52b2 |
mpdude
force-pushed
the
drop-deprecated-parser-result-methods
branch
from
41d021f to
1814d10
Compare
greg0ire
reviewed
Oct 7, 2025
mpdude
force-pushed
the
drop-deprecated-parser-result-methods
branch
from
1814d10 to
ac45a1c
Compare
|
fixed |
|
Moar conflicts 😭 |
mpdude
force-pushed
the
drop-deprecated-parser-result-methods
branch
from
ac45a1c to
8f95375
Compare
|
Needs |
mpdude
force-pushed
the
drop-deprecated-parser-result-methods
branch
from
75c0189 to
c5c66e5
Compare
I'm not sure I agree… did you remove this test because it broke? If yes, there should be instructions in UPGRADE.md explaining what's needed to update from 3 to 4… clearing a cache, I guess. |
|
IIRC yes – unserializing an old (2.x) ParserResult caused a notice, since it contained fields that now are no longer present in the class. I'll definetly add an upgrade notice. |
…ecutor` class This removes methods that have been deprecated in 2.20.x via doctrine#11188 and/or got deprecation notices added in doctrine#12196.
mpdude
force-pushed
the
drop-deprecated-parser-result-methods
branch
from
c5c66e5 to
713c985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes methods that have been deprecated in 2.20.x via #11188 and/or got deprecation notices added in #12196.