Skip to content

Conversation

@mpdude
Copy link
Contributor

@mpdude mpdude commented Oct 7, 2025

This PR triggers deprecation notices for methods and class constructors that were only annotated as being @deprecated in #11188.

These methods will be removed in 4.0.0 via #12195.

@mpdude mpdude changed the title Add deprecation messages for two methods that were only annotated as being @deprecated Add deprecation messages for methods that were only annotated as being @deprecated Oct 7, 2025
stof
stof previously approved these changes Oct 7, 2025
@greg0ire
Copy link
Member

greg0ire commented Oct 7, 2025

There are conflicts

mpdude added a commit to mpdude/doctrine2 that referenced this pull request Oct 7, 2025
…ecutor` class

This removes methods that have been deprecated in 2.20.x via doctrine#11188 and/or got deprecation notices added in doctrine#12196.
@mpdude mpdude force-pushed the deprecation-notice-parser-result branch from 5cfeea6 to 5fa6520 Compare October 8, 2025 08:01
mpdude added a commit to mpdude/doctrine2 that referenced this pull request Oct 8, 2025
…ecutor` class

This removes methods that have been deprecated in 2.20.x via doctrine#11188 and/or got deprecation notices added in doctrine#12196.
derrabus
derrabus previously approved these changes Oct 8, 2025
@mpdude mpdude force-pushed the deprecation-notice-parser-result branch from 760cf90 to 1a4add9 Compare October 8, 2025 09:20
@mpdude
Copy link
Contributor Author

mpdude commented Oct 8, 2025

Feedback taken care of, conflicts resolved. TY

@mpdude mpdude force-pushed the deprecation-notice-parser-result branch 2 times, most recently from e0f1733 to 3ec804c Compare October 8, 2025 10:00
@greg0ire
Copy link
Member

greg0ire commented Oct 8, 2025

You need to run vendor/bin/phpcbf

mpdude added a commit to mpdude/doctrine2 that referenced this pull request Oct 8, 2025
…ecutor` class

This removes methods that have been deprecated in 2.20.x via doctrine#11188 and/or got deprecation notices added in doctrine#12196.
@mpdude mpdude force-pushed the deprecation-notice-parser-result branch from 3ec804c to f1a8ee1 Compare October 8, 2025 21:09
mpdude added a commit to mpdude/doctrine2 that referenced this pull request Oct 11, 2025
…ecutor` class

This removes methods that have been deprecated in 2.20.x via doctrine#11188 and/or got deprecation notices added in doctrine#12196.
@greg0ire greg0ire added this to the 3.6.0 milestone Oct 12, 2025
@greg0ire greg0ire merged commit 28d9472 into doctrine:3.6.x Oct 12, 2025
86 of 87 checks passed
@greg0ire
Copy link
Member

Thanks @mpdude !

@mpdude mpdude deleted the deprecation-notice-parser-result branch October 12, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants